[ResponseOps][Cases] Add timing metrics to cases SO by umbopepato · Pull Request #219070 · elastic/kibana

umbopepato · 2025-04-24T11:17:51Z

Summary

Adds the in_progress_at timestamp to Cases Saved Objects
Adds the time_to_acknowledge, time_to_investigate and time_to_resolve timing metrics to Cases Saved Objects

References

Closes #217638

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

Unit or functional tests were updated or added to match the most common scenarios
Flaky Test Runner was used on any tests changed (passed ✅)

…te --fix'

… src/core/server/integration_tests/ci_checks'

…-status-changes-metrics

elasticmachine · 2025-05-06T14:14:48Z

Pinging @elastic/response-ops (Team:ResponseOps)

… params

…-status-changes-metrics

kibanamachine · 2025-05-06T19:51:31Z

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#8243

[✅] x-pack/test/cases_api_integration/security_and_spaces/config_basic.ts: 50/50 tests passed.

see run history

jloleysens

Nice work @umbopepato , I focussed review on the new SO additions and left a question I'd like to get your thoughts on before approving 👍🏻

x-pack/platform/plugins/shared/cases/server/saved_object_types/cases/model_versions.ts

…-status-changes-metrics

x-pack/platform/plugins/shared/cases/server/client/cases/utils.ts

...m/plugins/shared/cases/server/saved_object_types/cases/model_versions/model_versions.test.ts

x-pack/platform/plugins/shared/cases/common/types/domain/case/v1.ts

cnasikas

LGTM! I left some comments.

x-pack/test/cases_api_integration/security_and_spaces/tests/common/cases/patch_cases.ts

x-pack/platform/plugins/shared/cases/common/types/domain/case/v1.ts

...m/plugins/shared/cases/server/saved_object_types/cases/model_versions/model_versions.test.ts

x-pack/platform/plugins/shared/cases/server/services/cases/index.test.ts

x-pack/platform/plugins/shared/cases/server/client/cases/utils.ts

cnasikas · 2025-06-17T11:41:52Z

x-pack/platform/plugins/shared/cases/server/client/cases/utils.ts

+      ) {
+        if (inProgressAtMillis == null) {
+          // When a case transitions directly from 'open' to 'closed', set inProgressAt to
+          // updatedAtMillis to reflect the implicit start of progress


I am not sure about this. I think it is better to omit the calculation and let them be null. So, only newly created cases will be able to have these fields populated.

Don't know how common it is, but you could jump directly from open to closed. If users do this a lot we would lose a lot of metrics in new cases too, are we ok with this?

I thought about it more, and you are right. I changed the code to mark the time_to_acknowledge same as the time_to_resolve and the time_to_investigate to zero if the in_progress_at is not defined.

x-pack/platform/plugins/shared/cases/server/client/cases/utils.ts

Co-authored-by: Christos Nasikas <xristosnasikas@gmail.com>

…mbopepato/kibana into 217638-cases-so-status-changes-metrics

…-status-changes-metrics

…mbopepato/kibana into 217638-cases-so-status-changes-metrics

elasticmachine · 2025-06-18T20:16:31Z

💔 Build Failed

Buildkite Build
Commit: 0261f29

Failed CI Steps

Check Types

History

💔 Build #310041 failed 37bc757
💛 Build #309837 was flaky 69c0fa2
💔 Build #309781 failed 037c6fa
💚 Build #308816 succeeded 58bf0f2
💔 Build #308748 failed d977cb7

adcoelho

LGTM, left two small comments 👍

adcoelho · 2025-06-20T07:26:03Z

x-pack/platform/plugins/shared/cases/server/client/cases/bulk_update.test.ts

+      clientArgs.services.attachmentService.getter.getCaseCommentStats.mockResolvedValue(new Map());
+    });
+
+    it('calculates metrics correctly', async () => {


nit: should we have a similar test for the function that calculates in_progress_at?

x-pack/platform/plugins/shared/cases/server/client/cases/utils.ts

kibanamachine · 2025-06-20T09:34:51Z

Starting backport for target branches: 8.19

https://github.com/elastic/kibana/actions/runs/15775951233

## Summary - Adds the `in_progress_at` timestamp to Cases Saved Objects - Adds the `time_to_acknowledge`, `time_to_investigate` and `time_to_resolve` timing metrics to Cases Saved Objects ## References Closes elastic#217638 ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed (passed ✅) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Christos Nasikas <xristosnasikas@gmail.com> Co-authored-by: Christos Nasikas <christos.nasikas@elastic.co> (cherry picked from commit b0aa031)

kibanamachine · 2025-06-20T09:41:11Z

💚 All backports created successfully

Status	Branch	Result
✅	8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…224651) # Backport This will backport the following commits from `main` to `8.19`: - [[ResponseOps][Cases] Add timing metrics to cases SO (#219070)](#219070)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)  Co-authored-by: Umberto Pepato <umbopepato@users.noreply.github.com> Co-authored-by: Christos Nasikas <xristosnasikas@gmail.com> Co-authored-by: Christos Nasikas <christos.nasikas@elastic.co>

## Summary - Adds the `in_progress_at` timestamp to Cases Saved Objects - Adds the `time_to_acknowledge`, `time_to_investigate` and `time_to_resolve` timing metrics to Cases Saved Objects ## References Closes elastic#217638 ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed (passed ✅) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Christos Nasikas <xristosnasikas@gmail.com> Co-authored-by: Christos Nasikas <christos.nasikas@elastic.co>

umbopepato and others added 6 commits April 24, 2025 13:15

Add timing metrics to cases SO

f8769dd

[CI] Auto-commit changed files from 'node scripts/check_mappings_upda…

de36e81

…te --fix'

[CI] Auto-commit changed files from 'node scripts/jest_integration -u…

6936143

… src/core/server/integration_tests/ci_checks'

Make new properties optional in schema

fe38f2d

Fix failing tests, add new timing metric tests

37850f7

Merge branch 'main' of github.com:elastic/kibana into 217638-cases-so…

a80d713

…-status-changes-metrics

umbopepato force-pushed the 217638-cases-so-status-changes-metrics branch from 23491a2 to a80d713 Compare May 6, 2025 14:10

umbopepato added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// backport:version Backport to applied version labels v9.1.0 v8.19.0 labels May 6, 2025

umbopepato marked this pull request as ready for review May 6, 2025 14:14

umbopepato requested review from a team as code owners May 6, 2025 14:14

umbopepato added 6 commits May 6, 2025 17:20

Add timing metric utils unit tests, improve getTimingMetricsForUpdate…

fbdbacd

… params

Merge branch 'main' of github.com:elastic/kibana into 217638-cases-so…

8f71cb0

…-status-changes-metrics

Fix types

86a85ce

Merge branch 'main' of github.com:elastic/kibana into 217638-cases-so…

5eabf17

…-status-changes-metrics

Fix test

0304961

Merge branch 'main' of github.com:elastic/kibana into 217638-cases-so…

f9fc009

…-status-changes-metrics

jloleysens reviewed May 23, 2025

View reviewed changes

x-pack/platform/plugins/shared/cases/server/saved_object_types/cases/model_versions.ts Outdated Show resolved Hide resolved

umbopepato and others added 2 commits May 27, 2025 15:30

Merge branch 'main' into 217638-cases-so-status-changes-metrics

15c3084

Merge branch 'main' of github.com:elastic/kibana into 217638-cases-so…

0f494f1

…-status-changes-metrics

cnasikas mentioned this pull request May 29, 2025

[ResponseOps] Cases analytics index creation and backfill #219211

Merged

umbopepato and others added 3 commits May 30, 2025 12:22

Merge branch 'main' into 217638-cases-so-status-changes-metrics

1b2a002

Remove unneeded mappings

59c4cb6

Merge branch 'main' of github.com:elastic/kibana into 217638-cases-so…

18a8e17

…-status-changes-metrics

umbopepato added 4 commits June 16, 2025 10:34

Merge branch 'main' of github.com:elastic/kibana into 217638-cases-so…

f03b688

…-status-changes-metrics

Fix tests

d977cb7

Fix test

d13f1b0

Merge branch 'main' of github.com:elastic/kibana into 217638-cases-so…

58bf0f2

…-status-changes-metrics

adcoelho reviewed Jun 17, 2025

View reviewed changes

x-pack/platform/plugins/shared/cases/server/client/cases/utils.ts Outdated Show resolved Hide resolved

adcoelho reviewed Jun 17, 2025

View reviewed changes

...m/plugins/shared/cases/server/saved_object_types/cases/model_versions/model_versions.test.ts Outdated Show resolved Hide resolved

adcoelho reviewed Jun 17, 2025

View reviewed changes

x-pack/platform/plugins/shared/cases/common/types/domain/case/v1.ts Outdated Show resolved Hide resolved

cnasikas reviewed Jun 17, 2025

View reviewed changes

umbopepato and others added 9 commits June 18, 2025 10:22

Remove duplicated attribute

8dfc6bd

Co-authored-by: Christos Nasikas <xristosnasikas@gmail.com>

Implement suggested changes

4e64cb1

Merge branch '217638-cases-so-status-changes-metrics' of github.com:u…

8cf7d4d

…mbopepato/kibana into 217638-cases-so-status-changes-metrics

Merge branch 'main' of github.com:elastic/kibana into 217638-cases-so…

037c6fa

…-status-changes-metrics

Fix type error

69c0fa2

Remove duplicated test

37bc757

Simplify integration tests

b606933

Add more unit tests

5858994

Merge branch '217638-cases-so-status-changes-metrics' of github.com:u…

0261f29

…mbopepato/kibana into 217638-cases-so-status-changes-metrics

cnasikas requested a review from a team as a code owner June 18, 2025 19:58

cnasikas added 2 commits June 19, 2025 10:08

Fix types

f851859

Improve metrics

6f4547e

adcoelho approved these changes Jun 20, 2025

View reviewed changes

cnasikas merged commit b0aa031 into elastic:main Jun 20, 2025
11 checks passed

kibanamachine mentioned this pull request Jun 20, 2025

[8.19] [ResponseOps][Cases] Add timing metrics to cases SO (#219070) #224651

Merged

michaelolo24 mentioned this pull request Sep 5, 2025

[Cases] - Update Incremental ID Mapping #234054

Merged

Comments

Conversation

umbopepato commented Apr 24, 2025 • edited by kibanamachine Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

References

Checklist

Uh oh!

elasticmachine commented May 6, 2025

Uh oh!

kibanamachine commented May 6, 2025

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#8243

Uh oh!

jloleysens left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cnasikas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cnasikas Jun 17, 2025

Choose a reason for hiding this comment

Uh oh!

umbopepato Jun 18, 2025

Choose a reason for hiding this comment

Uh oh!

cnasikas Jun 19, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

elasticmachine commented Jun 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💔 Build Failed

Failed CI Steps

History

Uh oh!

adcoelho left a comment

Choose a reason for hiding this comment

Uh oh!

adcoelho Jun 20, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

kibanamachine commented Jun 20, 2025

Uh oh!

kibanamachine commented Jun 20, 2025

💚 All backports created successfully

Questions ?

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

umbopepato commented Apr 24, 2025 •

edited by kibanamachine

Loading

elasticmachine commented Jun 18, 2025 •

edited

Loading