Skip to content

[Advanced settings] Fix boolean input accessibility #218961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SoniaSanzV merged 7 commits into from
Apr 29, 2025
Merged

[Advanced settings] Fix boolean input accessibility #218961

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5070361
Fix boolean input accessibility
SoniaSanzV Apr 23, 2025
f714792
Fix i18n
SoniaSanzV Apr 23, 2025
8916a7d
Merge branch 'main' into advanced_settings-boolean_input_accessibility
alexwizp Apr 24, 2025
bf81eac
Merge branch 'main' into advanced_settings-boolean_input_accessibility
SoniaSanzV Apr 24, 2025
c3f348c
Fix strings
SoniaSanzV Apr 24, 2025
fba3eb1
Merge branch 'main' into advanced_settings-boolean_input_accessibility
alexwizp Apr 24, 2025
23b2c75
Merge branch 'main' into advanced_settings-boolean_input_accessibility
SoniaSanzV Apr 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions ...rm/packages/shared/kbn-management/settings/components/field_input/input/boolean_input.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
import React from 'react';

import { EuiSwitch, EuiSwitchProps } from '@elastic/eui';
import { FormattedMessage } from '@kbn/i18n-react';

import { getFieldInputValue, useUpdate } from '@kbn/management-settings-utilities';

Expand Down Expand Up @@ -44,13 +43,7 @@ export const BooleanInput = ({

return (
<EuiSwitch
label={
!!value ? (
<FormattedMessage id="management.settings.onLabel" defaultMessage="On" />
) : (
<FormattedMessage id="management.settings.offLabel" defaultMessage="Off" />
)
}
label={name}
aria-label={ariaLabel}
aria-describedby={ariaDescribedBy}
checked={!!value}
Expand Down
2 changes: 0 additions & 2 deletions x-pack/platform/plugins/private/translations/translations/fr-FR.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6375,8 +6375,6 @@
"management.settings.globalCalloutTitle": "Les modifications auront une incidence sur tous les paramètres utilisateur dans l'ensemble des espaces",
"management.settings.globalSettingsTabTitle": "Paramètres généraux",
"management.settings.helpText": "Ce paramètre est défini par le serveur Kibana et ne peut pas être modifié.",
"management.settings.offLabel": "Désactivé",
"management.settings.onLabel": "Activé",
"management.settings.resetToDefaultLinkText": "Réinitialiser à la valeur par défaut",
"management.settings.searchBar.unableToParseQueryErrorMessage": "Impossible d'analyser la requête",
"management.settings.searchBarPlaceholder": "Rechercher dans les paramètres avancés",
Expand Down
2 changes: 0 additions & 2 deletions x-pack/platform/plugins/private/translations/translations/ja-JP.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6369,8 +6369,6 @@
"management.settings.globalCalloutTitle": "変更はすべてのスペースのすべてのユーザー設定に影響します",
"management.settings.globalSettingsTabTitle": "グローバル設定",
"management.settings.helpText": "この設定は Kibana サーバーにより上書きされ、変更することはできません。",
"management.settings.offLabel": "オフ",
"management.settings.onLabel": "オン",
"management.settings.resetToDefaultLinkText": "デフォルトにリセット",
"management.settings.searchBar.unableToParseQueryErrorMessage": "クエリーをパースできません",
"management.settings.searchBarPlaceholder": "高度な設定を検索",
Expand Down
2 changes: 0 additions & 2 deletions x-pack/platform/plugins/private/translations/translations/zh-CN.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6379,8 +6379,6 @@
"management.settings.globalCalloutTitle": "更改将影响所有工作区的所有用户设置",
"management.settings.globalSettingsTabTitle": "常规设置",
"management.settings.helpText": "此设置已由 Kibana 服务器覆盖，无法更改。",
"management.settings.offLabel": "关闭",
"management.settings.onLabel": "开启",
"management.settings.resetToDefaultLinkText": "重置为默认值",
"management.settings.searchBar.unableToParseQueryErrorMessage": "无法解析查询",
"management.settings.searchBarPlaceholder": "搜索高级设置",
Expand Down