[Advanced settings] Fix boolean input accessibility#218961
Merged
SoniaSanzV merged 7 commits intoelastic:mainfrom Apr 29, 2025
Merged
[Advanced settings] Fix boolean input accessibility#218961SoniaSanzV merged 7 commits intoelastic:mainfrom
SoniaSanzV merged 7 commits intoelastic:mainfrom
Conversation
SoniaSanzV
added
Feature:Kibana Management
Contributor
|
Pinging @elastic/kibana-management (Team:Kibana Management) |
alexwizp
reviewed
Apr 24, 2025
SoniaSanzV
force-pushed
the
advanced_settings-boolean_input_accessibility
branch
from
2090f1f to
c3f348c
Compare
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]Async chunks
History
cc @SoniaSanzV |
mattkime
approved these changes
Apr 29, 2025
Contributor
mattkime
left a comment
mattkime
left a comment
There was a problem hiding this comment.
code changes look good and work well
Contributor
|
Starting backport for target branches: 9.0 https://github.com/elastic/kibana/actions/runs/14725080895 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 29, 2025
Closes: elastic#217913 **Description** Set correct label for Advanced Settings boolean input component. --------- Co-authored-by: Alexey Antonov <alexwizp@gmail.com> (cherry picked from commit cbf239a)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Apr 29, 2025
…219484) # Backport This will backport the following commits from `main` to `9.0`: - [[Advanced settings] Fix boolean input accessibility (#218961)](#218961) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Sonia Sanz Vivas","email":"sonia.sanzvivas@elastic.co"},"sourceCommit":{"committedDate":"2025-04-29T06:47:52Z","message":"[Advanced settings] Fix boolean input accessibility (#218961)\n\nCloses: https://github.com/elastic/kibana/issues/217913\n\n**Description**\nSet correct label for Advanced Settings boolean input component.\n\n---------\n\nCo-authored-by: Alexey Antonov <alexwizp@gmail.com>","sha":"cbf239a512b2787f71fc8efb949af3cc52a02730","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Kibana Management","Team:Kibana Management","release_note:skip","backport:prev-minor","v9.1.0"],"title":"[Advanced settings] Fix boolean input accessibility","number":218961,"url":"https://github.com/elastic/kibana/pull/218961","mergeCommit":{"message":"[Advanced settings] Fix boolean input accessibility (#218961)\n\nCloses: https://github.com/elastic/kibana/issues/217913\n\n**Description**\nSet correct label for Advanced Settings boolean input component.\n\n---------\n\nCo-authored-by: Alexey Antonov <alexwizp@gmail.com>","sha":"cbf239a512b2787f71fc8efb949af3cc52a02730"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/218961","number":218961,"mergeCommit":{"message":"[Advanced settings] Fix boolean input accessibility (#218961)\n\nCloses: https://github.com/elastic/kibana/issues/217913\n\n**Description**\nSet correct label for Advanced Settings boolean input component.\n\n---------\n\nCo-authored-by: Alexey Antonov <alexwizp@gmail.com>","sha":"cbf239a512b2787f71fc8efb949af3cc52a02730"}}]}] BACKPORT--> Co-authored-by: Sonia Sanz Vivas <sonia.sanzvivas@elastic.co> Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
akowalska622
pushed a commit
to akowalska622/kibana
that referenced
this pull request
May 29, 2025
Closes: elastic#217913 **Description** Set correct label for Advanced Settings boolean input component. --------- Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #217913
Description
Set correct label for Advanced Settings boolean input component.