[9.0] RenamesrenderReactTestingLibraryWithI18n to renderWithI18n (#218371)#218714
Merged
kibanamachine merged 2 commits intoelastic:9.0from Apr 21, 2025
Merged
[9.0] RenamesrenderReactTestingLibraryWithI18n to renderWithI18n (#218371)#218714kibanamachine merged 2 commits intoelastic:9.0from
renderReactTestingLibraryWithI18n to renderWithI18n (#218371)#218714kibanamachine merged 2 commits intoelastic:9.0from
Conversation
…ic#218371) ## Summary This PR only renames the helper, no test implementations were changed. Why now? Migrating tests from Enzyme to RTL means that all usage of `mountWithIntl` has to change and will likely be replaced by the helper that wraps RTL render with I18n. [A shorter name improves devEx](url). ATM, consumption is limited to a few tests, reducing the number of codeowner reviews required. ### Identify risks - [x] In progress work and open PRs might fail. Updating from main will prompt an undefined function that will need to be renamed. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 1fe09dc)
botelastic
bot
added
Team:Fleet
1 task
Contributor
|
Pinging @elastic/fleet (Team:Fleet) |
Contributor
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
|
Dosant
added a commit
that referenced
this pull request
Jun 12, 2025
…#218371) (#223516) # Backport This will backport the following commits from `main` to `8.19`: - [Renames`renderReactTestingLibraryWithI18n` to `renderWithI18n` (#218371)](#218371) <!--- Backport version: 10.0.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Christiane (Tina) Heiligers","email":"christiane.heiligers@elastic.co"},"sourceCommit":{"committedDate":"2025-04-21T07:21:59Z","message":"Renames`renderReactTestingLibraryWithI18n` to `renderWithI18n` (#218371)\n\n## Summary\n\nThis PR only renames the helper, no test implementations were changed.\n\nWhy now?\n\nMigrating tests from Enzyme to RTL means that all usage of\n`mountWithIntl` has to change and will likely be replaced by the helper\nthat wraps RTL render with I18n. [A shorter name improves devEx](url).\n\nATM, consumption is limited to a few tests, reducing the number of\ncodeowner reviews required.\n\n### Identify risks\n\n- [x] In progress work and open PRs might fail. Updating from main will\nprompt an undefined function that will need to be renamed.\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"1fe09dcff4ec20ff877e17a181ed77c28e3e05d1","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["chore","release_note:skip","Team:Fleet","backport:prev-minor","Team:obs-ux-infra_services","v9.1.0","v9.0.1"],"title":"Renames`renderReactTestingLibraryWithI18n` to `renderWithI18n`","number":218371,"url":"https://github.com/elastic/kibana/pull/218371","mergeCommit":{"message":"Renames`renderReactTestingLibraryWithI18n` to `renderWithI18n` (#218371)\n\n## Summary\n\nThis PR only renames the helper, no test implementations were changed.\n\nWhy now?\n\nMigrating tests from Enzyme to RTL means that all usage of\n`mountWithIntl` has to change and will likely be replaced by the helper\nthat wraps RTL render with I18n. [A shorter name improves devEx](url).\n\nATM, consumption is limited to a few tests, reducing the number of\ncodeowner reviews required.\n\n### Identify risks\n\n- [x] In progress work and open PRs might fail. Updating from main will\nprompt an undefined function that will need to be renamed.\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"1fe09dcff4ec20ff877e17a181ed77c28e3e05d1"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/218371","number":218371,"mergeCommit":{"message":"Renames`renderReactTestingLibraryWithI18n` to `renderWithI18n` (#218371)\n\n## Summary\n\nThis PR only renames the helper, no test implementations were changed.\n\nWhy now?\n\nMigrating tests from Enzyme to RTL means that all usage of\n`mountWithIntl` has to change and will likely be replaced by the helper\nthat wraps RTL render with I18n. [A shorter name improves devEx](url).\n\nATM, consumption is limited to a few tests, reducing the number of\ncodeowner reviews required.\n\n### Identify risks\n\n- [x] In progress work and open PRs might fail. Updating from main will\nprompt an undefined function that will need to be renamed.\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"1fe09dcff4ec20ff877e17a181ed77c28e3e05d1"}},{"branch":"9.0","label":"v9.0.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/218714","number":218714,"state":"MERGED","mergeCommit":{"sha":"2af22f2f0422d3038caa56dcc154b8db20eb6554","message":"[9.0] Renames`renderReactTestingLibraryWithI18n` to `renderWithI18n` (#218371) (#218714)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.0`:\n- [Renames`renderReactTestingLibraryWithI18n` to `renderWithI18n`\n(#218371)](https://github.com/elastic/kibana/pull/218371)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\n---------\n\nCo-authored-by: Christiane (Tina) Heiligers <christiane.heiligers@elastic.co>"}}]}] BACKPORT--> --------- Co-authored-by: Christiane (Tina) Heiligers <christiane.heiligers@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.0:renderReactTestingLibraryWithI18ntorenderWithI18n(#218371)Questions ?
Please refer to the Backport tool documentation