[8.19] RenamesrenderReactTestingLibraryWithI18n to renderWithI18n (#218371)#223516
Merged
Dosant merged 2 commits intoelastic:8.19from Jun 12, 2025
Merged
[8.19] RenamesrenderReactTestingLibraryWithI18n to renderWithI18n (#218371)#223516Dosant merged 2 commits intoelastic:8.19from
renderReactTestingLibraryWithI18n to renderWithI18n (#218371)#223516Dosant merged 2 commits intoelastic:8.19from
Conversation
…ic#218371) ## Summary This PR only renames the helper, no test implementations were changed. Why now? Migrating tests from Enzyme to RTL means that all usage of `mountWithIntl` has to change and will likely be replaced by the helper that wraps RTL render with I18n. [A shorter name improves devEx](url). ATM, consumption is limited to a few tests, reducing the number of codeowner reviews required. ### Identify risks - [x] In progress work and open PRs might fail. Updating from main will prompt an undefined function that will need to be renamed. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 1fe09dc) # Conflicts: # src/core/packages/apps/browser-internal/src/status/components/status_table.test.tsx
botelastic
bot
added
Team:Fleet
Contributor
|
Pinging @elastic/fleet (Team:Fleet) |
Contributor
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
1 task
Contributor
💔 Build Failed
Failed CI StepsHistory |
afharo
approved these changes
Jun 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.19:renderReactTestingLibraryWithI18ntorenderWithI18n(#218371)Questions ?
Please refer to the Backport tool documentation