Skip to content

Comments

[8.x] fix: [ML] Data Frame Analytics: Analytics selection flyout missing title from announcement (#217666)#218259

Merged
kibanamachine merged 2 commits intoelastic:8.xfrom
kibanamachine:backport/8.x/pr-217666
Apr 16, 2025
Merged

[8.x] fix: [ML] Data Frame Analytics: Analytics selection flyout missing title from announcement (#217666)#218259
kibanamachine merged 2 commits intoelastic:8.xfrom
kibanamachine:backport/8.x/pr-217666

Conversation

@kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…tle from announcement (elastic#217666)

Closes: elastic#217511

**Description**
Dialog modal, flyout, field visible title should be announced for the
users, especially using assistive technology to know what dialog modal,
flyout opened, what field is active and what is needed to enter in it.

**Changes made:**
1. Set correct value for `aria-labelledby` attr.

(cherry picked from commit 4399248)
@kibanamachine kibanamachine merged commit a597682 into elastic:8.x Apr 16, 2025
8 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #1 / TableListView url state should update the URL when changing a tag from the filter dropdown

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 5.4MB 5.4MB +54.0B

History

cc @alexwizp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants