fix: [ML] Data Frame Analytics: Analytics selection flyout missing title from announcement#217666
Merged
alexwizp merged 6 commits intoelastic:mainfrom Apr 15, 2025
Merged
fix: [ML] Data Frame Analytics: Analytics selection flyout missing title from announcement#217666alexwizp merged 6 commits intoelastic:mainfrom
alexwizp merged 6 commits intoelastic:mainfrom
Conversation
…tle from announcement Closes: elastic#217511
alexwizp
added
Project:Accessibility
release_note:skip
Contributor
|
Pinging @elastic/kibana-accessibility (Project:Accessibility) |
Contributor
|
Pinging @elastic/ml-ui (:ml) |
peteharverson
added
the
Feature:Data Frame Analytics
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
peteharverson
approved these changes
Apr 15, 2025
Contributor
peteharverson
left a comment
peteharverson
left a comment
There was a problem hiding this comment.
LGTM. Verified with Safari / VoiceOver.
Contributor
|
Starting backport for target branches: 8.16, 8.17, 8.18, 8.x https://github.com/elastic/kibana/actions/runs/14469186447 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 15, 2025
…tle from announcement (elastic#217666) Closes: elastic#217511 **Description** Dialog modal, flyout, field visible title should be announced for the users, especially using assistive technology to know what dialog modal, flyout opened, what field is active and what is needed to enter in it. **Changes made:** 1. Set correct value for `aria-labelledby` attr. (cherry picked from commit 4399248)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 15, 2025
…tle from announcement (elastic#217666) Closes: elastic#217511 **Description** Dialog modal, flyout, field visible title should be announced for the users, especially using assistive technology to know what dialog modal, flyout opened, what field is active and what is needed to enter in it. **Changes made:** 1. Set correct value for `aria-labelledby` attr. (cherry picked from commit 4399248)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 15, 2025
…tle from announcement (elastic#217666) Closes: elastic#217511 **Description** Dialog modal, flyout, field visible title should be announced for the users, especially using assistive technology to know what dialog modal, flyout opened, what field is active and what is needed to enter in it. **Changes made:** 1. Set correct value for `aria-labelledby` attr. (cherry picked from commit 4399248)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 15, 2025
…tle from announcement (elastic#217666) Closes: elastic#217511 **Description** Dialog modal, flyout, field visible title should be announced for the users, especially using assistive technology to know what dialog modal, flyout opened, what field is active and what is needed to enter in it. **Changes made:** 1. Set correct value for `aria-labelledby` attr. (cherry picked from commit 4399248)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Apr 15, 2025
…sing title from announcement (#217666) (#218257) # Backport This will backport the following commits from `main` to `8.17`: - [fix: [ML] Data Frame Analytics: Analytics selection flyout missing title from announcement (#217666)](#217666) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Alexey Antonov","email":"alexwizp@gmail.com"},"sourceCommit":{"committedDate":"2025-04-15T12:17:20Z","message":"fix: [ML] Data Frame Analytics: Analytics selection flyout missing title from announcement (#217666)\n\nCloses: https://github.com/elastic/kibana/issues/217511\n\n**Description**\nDialog modal, flyout, field visible title should be announced for the\nusers, especially using assistive technology to know what dialog modal,\nflyout opened, what field is active and what is needed to enter in it.\n\n**Changes made:**\n1. Set correct value for `aria-labelledby` attr.","sha":"4399248cf013552902af726e61b0da5b2ed23b2e","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility",":ml","release_note:skip","Feature:Data Frame Analytics","backport:prev-major","v9.1.0"],"title":"fix: [ML] Data Frame Analytics: Analytics selection flyout missing title from announcement","number":217666,"url":"https://github.com/elastic/kibana/pull/217666","mergeCommit":{"message":"fix: [ML] Data Frame Analytics: Analytics selection flyout missing title from announcement (#217666)\n\nCloses: https://github.com/elastic/kibana/issues/217511\n\n**Description**\nDialog modal, flyout, field visible title should be announced for the\nusers, especially using assistive technology to know what dialog modal,\nflyout opened, what field is active and what is needed to enter in it.\n\n**Changes made:**\n1. Set correct value for `aria-labelledby` attr.","sha":"4399248cf013552902af726e61b0da5b2ed23b2e"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/217666","number":217666,"mergeCommit":{"message":"fix: [ML] Data Frame Analytics: Analytics selection flyout missing title from announcement (#217666)\n\nCloses: https://github.com/elastic/kibana/issues/217511\n\n**Description**\nDialog modal, flyout, field visible title should be announced for the\nusers, especially using assistive technology to know what dialog modal,\nflyout opened, what field is active and what is needed to enter in it.\n\n**Changes made:**\n1. Set correct value for `aria-labelledby` attr.","sha":"4399248cf013552902af726e61b0da5b2ed23b2e"}}]}] BACKPORT--> Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
kibanamachine
added a commit
that referenced
this pull request
Apr 15, 2025
…sing title from announcement (#217666) (#218256) # Backport This will backport the following commits from `main` to `8.16`: - [fix: [ML] Data Frame Analytics: Analytics selection flyout missing title from announcement (#217666)](#217666) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Alexey Antonov","email":"alexwizp@gmail.com"},"sourceCommit":{"committedDate":"2025-04-15T12:17:20Z","message":"fix: [ML] Data Frame Analytics: Analytics selection flyout missing title from announcement (#217666)\n\nCloses: https://github.com/elastic/kibana/issues/217511\n\n**Description**\nDialog modal, flyout, field visible title should be announced for the\nusers, especially using assistive technology to know what dialog modal,\nflyout opened, what field is active and what is needed to enter in it.\n\n**Changes made:**\n1. Set correct value for `aria-labelledby` attr.","sha":"4399248cf013552902af726e61b0da5b2ed23b2e","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility",":ml","release_note:skip","Feature:Data Frame Analytics","backport:prev-major","v9.1.0"],"title":"fix: [ML] Data Frame Analytics: Analytics selection flyout missing title from announcement","number":217666,"url":"https://github.com/elastic/kibana/pull/217666","mergeCommit":{"message":"fix: [ML] Data Frame Analytics: Analytics selection flyout missing title from announcement (#217666)\n\nCloses: https://github.com/elastic/kibana/issues/217511\n\n**Description**\nDialog modal, flyout, field visible title should be announced for the\nusers, especially using assistive technology to know what dialog modal,\nflyout opened, what field is active and what is needed to enter in it.\n\n**Changes made:**\n1. Set correct value for `aria-labelledby` attr.","sha":"4399248cf013552902af726e61b0da5b2ed23b2e"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/217666","number":217666,"mergeCommit":{"message":"fix: [ML] Data Frame Analytics: Analytics selection flyout missing title from announcement (#217666)\n\nCloses: https://github.com/elastic/kibana/issues/217511\n\n**Description**\nDialog modal, flyout, field visible title should be announced for the\nusers, especially using assistive technology to know what dialog modal,\nflyout opened, what field is active and what is needed to enter in it.\n\n**Changes made:**\n1. Set correct value for `aria-labelledby` attr.","sha":"4399248cf013552902af726e61b0da5b2ed23b2e"}}]}] BACKPORT--> Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
Contributor
|
This PR didn't make it into the latest 8.17.5 BC. Updating the labels. |
1 task
kibanamachine
added a commit
that referenced
this pull request
Apr 16, 2025
…ing title from announcement (#217666) (#218259) # Backport This will backport the following commits from `main` to `8.x`: - [fix: [ML] Data Frame Analytics: Analytics selection flyout missing title from announcement (#217666)](#217666) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Alexey Antonov","email":"alexwizp@gmail.com"},"sourceCommit":{"committedDate":"2025-04-15T12:17:20Z","message":"fix: [ML] Data Frame Analytics: Analytics selection flyout missing title from announcement (#217666)\n\nCloses: https://github.com/elastic/kibana/issues/217511\n\n**Description**\nDialog modal, flyout, field visible title should be announced for the\nusers, especially using assistive technology to know what dialog modal,\nflyout opened, what field is active and what is needed to enter in it.\n\n**Changes made:**\n1. Set correct value for `aria-labelledby` attr.","sha":"4399248cf013552902af726e61b0da5b2ed23b2e","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility",":ml","release_note:skip","Feature:Data Frame Analytics","backport:prev-major","v9.1.0"],"title":"fix: [ML] Data Frame Analytics: Analytics selection flyout missing title from announcement","number":217666,"url":"https://github.com/elastic/kibana/pull/217666","mergeCommit":{"message":"fix: [ML] Data Frame Analytics: Analytics selection flyout missing title from announcement (#217666)\n\nCloses: https://github.com/elastic/kibana/issues/217511\n\n**Description**\nDialog modal, flyout, field visible title should be announced for the\nusers, especially using assistive technology to know what dialog modal,\nflyout opened, what field is active and what is needed to enter in it.\n\n**Changes made:**\n1. Set correct value for `aria-labelledby` attr.","sha":"4399248cf013552902af726e61b0da5b2ed23b2e"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/217666","number":217666,"mergeCommit":{"message":"fix: [ML] Data Frame Analytics: Analytics selection flyout missing title from announcement (#217666)\n\nCloses: https://github.com/elastic/kibana/issues/217511\n\n**Description**\nDialog modal, flyout, field visible title should be announced for the\nusers, especially using assistive technology to know what dialog modal,\nflyout opened, what field is active and what is needed to enter in it.\n\n**Changes made:**\n1. Set correct value for `aria-labelledby` attr.","sha":"4399248cf013552902af726e61b0da5b2ed23b2e"}}]}] BACKPORT--> Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
kibanamachine
added a commit
that referenced
this pull request
Apr 16, 2025
…sing title from announcement (#217666) (#218258) # Backport This will backport the following commits from `main` to `8.18`: - [fix: [ML] Data Frame Analytics: Analytics selection flyout missing title from announcement (#217666)](#217666) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Alexey Antonov","email":"alexwizp@gmail.com"},"sourceCommit":{"committedDate":"2025-04-15T12:17:20Z","message":"fix: [ML] Data Frame Analytics: Analytics selection flyout missing title from announcement (#217666)\n\nCloses: https://github.com/elastic/kibana/issues/217511\n\n**Description**\nDialog modal, flyout, field visible title should be announced for the\nusers, especially using assistive technology to know what dialog modal,\nflyout opened, what field is active and what is needed to enter in it.\n\n**Changes made:**\n1. Set correct value for `aria-labelledby` attr.","sha":"4399248cf013552902af726e61b0da5b2ed23b2e","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility",":ml","release_note:skip","Feature:Data Frame Analytics","backport:prev-major","v9.1.0"],"title":"fix: [ML] Data Frame Analytics: Analytics selection flyout missing title from announcement","number":217666,"url":"https://github.com/elastic/kibana/pull/217666","mergeCommit":{"message":"fix: [ML] Data Frame Analytics: Analytics selection flyout missing title from announcement (#217666)\n\nCloses: https://github.com/elastic/kibana/issues/217511\n\n**Description**\nDialog modal, flyout, field visible title should be announced for the\nusers, especially using assistive technology to know what dialog modal,\nflyout opened, what field is active and what is needed to enter in it.\n\n**Changes made:**\n1. Set correct value for `aria-labelledby` attr.","sha":"4399248cf013552902af726e61b0da5b2ed23b2e"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/217666","number":217666,"mergeCommit":{"message":"fix: [ML] Data Frame Analytics: Analytics selection flyout missing title from announcement (#217666)\n\nCloses: https://github.com/elastic/kibana/issues/217511\n\n**Description**\nDialog modal, flyout, field visible title should be announced for the\nusers, especially using assistive technology to know what dialog modal,\nflyout opened, what field is active and what is needed to enter in it.\n\n**Changes made:**\n1. Set correct value for `aria-labelledby` attr.","sha":"4399248cf013552902af726e61b0da5b2ed23b2e"}}]}] BACKPORT--> Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #217511
Description
Dialog modal, flyout, field visible title should be announced for the users, especially using assistive technology to know what dialog modal, flyout opened, what field is active and what is needed to enter in it.
Changes made:
aria-labelledbyattr.