Skip to content

[upgrade assistant] Stop rollup jobs before reindexing - forwardport to 9.1#218049

Merged
mattkime merged 6 commits intoelastic:mainfrom
mattkime:upgrade_assistant_rollup_support_forward_port
Apr 21, 2025
Merged

[upgrade assistant] Stop rollup jobs before reindexing - forwardport to 9.1#218049
mattkime merged 6 commits intoelastic:mainfrom
mattkime:upgrade_assistant_rollup_support_forward_port

Conversation

@mattkime
Copy link
Contributor

@mattkime mattkime commented Apr 14, 2025

Summary

forward port of #212815


This PR improve support for rollup indices. Rollup indices can be handled like normal indices but jobs should be stopped before reindexing begins or index is marked read only. Also handles case where the rollup job is already stopped.

To review: Mark the following read only and make sure rollup jobs are handled as appropriate: Rollup index with and without job running, normal index.

Follow up to #212592 and #214656

Closes: #211850

@mattkime mattkime self-assigned this Apr 14, 2025
@mattkime mattkime added Feature:Upgrade Assistant Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// backport:prev-minor labels Apr 14, 2025
@mattkime mattkime changed the title forward port of rollup support [upgrade assistant] Stop rollup jobs before reindexing - forwardport to 9.1 Apr 14, 2025
@mattkime mattkime marked this pull request as ready for review April 14, 2025 22:09
@mattkime mattkime requested a review from a team as a code owner April 14, 2025 22:09
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

@mattkime mattkime added the release_note:skip Skip the PR/issue when compiling release notes label Apr 15, 2025
@mattkime mattkime requested a review from sabarasaba April 15, 2025 03:45
@mattkime mattkime enabled auto-merge (squash) April 21, 2025 12:47
@mattkime mattkime merged commit fcee0a8 into elastic:main Apr 21, 2025
9 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 9.0

https://github.com/elastic/kibana/actions/runs/14575521384

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

cc @mattkime

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
9.0 Backport failed because of merge conflicts

You might need to backport the following PRs to 9.0:
- [Obs AI Assistant]fixing error - Display results and Visualize query Bedrock Error (#218213)
- RenamesrenderReactTestingLibraryWithI18n to renderWithI18n (#218371)
- [Security Solution] [Detections] Clarify result of missing read-index privileges on index patterns for a given rule (#215941)
- Advanced policy opt-out for scan-on-event (#218354)
- [Security Solution][Telemetry] Add index metadata EBT event (#218546)

Manual backport

To create the backport manually run:

node scripts/backport --pr 218049

Questions ?

Please refer to the Backport tool documentation

pgayvallet pushed a commit to pgayvallet/kibana that referenced this pull request Apr 22, 2025
…to 9.1 (elastic#218049)

## Summary

forward port of elastic#212815

---

This PR improve support for rollup indices. Rollup indices can be
handled like normal indices but jobs should be stopped before reindexing
begins or index is marked read only. Also handles case where the rollup
job is already stopped.

To review: Mark the following read only and make sure rollup jobs are
handled as appropriate: Rollup index with and without job running,
normal index.

Follow up to elastic#212592 and
elastic#214656

Closes: elastic#211850
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 22, 2025
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 218049 locally

1 similar comment
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 218049 locally

@kibanamachine kibanamachine added backport:skip This PR does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Apr 23, 2025
akowalska622 pushed a commit to akowalska622/kibana that referenced this pull request May 29, 2025
…to 9.1 (elastic#218049)

## Summary

forward port of elastic#212815

---

This PR improve support for rollup indices. Rollup indices can be
handled like normal indices but jobs should be stopped before reindexing
begins or index is marked read only. Also handles case where the rollup
job is already stopped.

To review: Mark the following read only and make sure rollup jobs are
handled as appropriate: Rollup index with and without job running,
normal index.

Follow up to elastic#212592 and
elastic#214656

Closes: elastic#211850
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Feature:Upgrade Assistant release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[upgrade assistant] Rollup jobs need to be stopped before rollup indices are reindexed

4 participants