Skip to content

[Security Solution] [Detections] Clarify result of missing read-index privileges on index patterns for a given rule#215941

Merged
dhurley14 merged 17 commits intoelastic:mainfrom
dhurley14:change-text-read-priv-warning
Apr 18, 2025
Merged

[Security Solution] [Detections] Clarify result of missing read-index privileges on index patterns for a given rule#215941
dhurley14 merged 17 commits intoelastic:mainfrom
dhurley14:change-text-read-priv-warning

Conversation

@dhurley14
Copy link
Contributor

@dhurley14 dhurley14 commented Mar 25, 2025 •
edited by kibanamachine
Loading

Summary

Ref: #193204

Updates the text shown when a rule may not have read privileges to a given index pattern.

Given a user with read privileges to packetbeat-*, and data available in auditbeat-* and packetbeat-*, the following error would appear if given a rule querying both index patterns.

read_warning_text_de_2

@dhurley14 dhurley14 changed the title change text warning user about possibly missing read-index privileges… [Security Solution] [Detections] Clarify result of missing read-index privileges on index patterns for a given rule Mar 25, 2025
@dhurley14 dhurley14 added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 backport:version Backport to applied version labels v9.1.0 v9.0.1 labels Mar 25, 2025
@dhurley14 dhurley14 marked this pull request as ready for review March 25, 2025 20:33
@dhurley14 dhurley14 requested a review from a team as a code owner March 25, 2025 20:33
@dhurley14 dhurley14 requested review from rylnd and yctercero and removed request for rylnd March 25, 2025 20:33
@yctercero yctercero requested review from a team, nastasha-solomon and nkhristinin March 26, 2025 16:17
@dhurley14 dhurley14 self-assigned this Mar 26, 2025
@dhurley14 dhurley14 requested review from a team as code owners April 7, 2025 20:10
@dhurley14 dhurley14 enabled auto-merge (squash) April 15, 2025 14:26
@yctercero
Copy link
Contributor

yctercero commented Apr 15, 2025

@dhurley14 hey! Not sure if it's already fixed in the code, but I think we're concatenating different errors using , and it results in a grammatical error [...] not created., This rule's [...] .

image

@dhurley14 dhurley14 disabled auto-merge April 15, 2025 20:35
@dhurley14
Copy link
Contributor Author

dhurley14 commented Apr 16, 2025

@yctercero I believe this is responsible for the incorrect punctuation. I can try to make the change in this PR.

@dhurley14
Copy link
Contributor Author

dhurley14 commented Apr 17, 2025

@yctercero How does this look?

Screenshot 2025-04-17 at 9 35 23 AM

@yctercero
Copy link
Contributor

yctercero commented Apr 17, 2025

@yctercero How does this look?

Screenshot 2025-04-17 at 9 35 23 AM

I like that a lot better!

cc @approksiu

@elasticmachine
Copy link
Contributor

elasticmachine commented Apr 18, 2025 •
edited
Loading

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiAssistantManagementSelection 63.9KB 64.0KB +63.0B
lists 110.6KB 110.7KB +63.0B
total +126.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 435.4KB 435.5KB +63.0B

History

cc @dhurley14

@dhurley14 dhurley14 removed the v9.0.0 label Apr 18, 2025
@dhurley14 dhurley14 merged commit 6e4a06e into elastic:main Apr 18, 2025
10 checks passed
@kibanamachine
Copy link
Contributor

kibanamachine commented Apr 18, 2025

Starting backport for target branches: 9.0

https://github.com/elastic/kibana/actions/runs/14539678922

@kibanamachine
Copy link
Contributor

kibanamachine commented Apr 18, 2025

💔 All backports failed

Status Branch Result
❌ 9.0 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 215941

Questions ?

Please refer to the Backport tool documentation

This was referenced Apr 21, 2025
Merged
Merged
davismcphee pushed a commit to davismcphee/kibana that referenced this pull request Apr 22, 2025
@dhurley14 @davismcphee
[Security Solution] [Detections] Clarify result of missing read-index…
003cbcf 
… privileges on index patterns for a given rule (elastic#215941)

## Summary

Ref: elastic#193204

Updates the text shown when a rule may not have read privileges to a
given index pattern.
@dhurley14 dhurley14 mentioned this pull request Apr 22, 2025
Merged
dhurley14 added a commit to dhurley14/kibana that referenced this pull request Apr 22, 2025
@dhurley14
[Security Solution] [Detections] Clarify result of missing read-index…
7dd85ac 
… privileges on index patterns for a given rule (elastic#215941)

## Summary

Ref: elastic#193204

Updates the text shown when a rule may not have read privileges to a
given index pattern.

(cherry picked from commit 6e4a06e)

# Conflicts:
#	x-pack/solutions/security/plugins/security_solution/server/lib/detection_engine/rule_types/utils/utils.ts
@dhurley14 dhurley14 mentioned this pull request Apr 22, 2025
Merged
@dhurley14
Copy link
Contributor Author

dhurley14 commented Apr 22, 2025

💚 All backports created successfully

Status Branch Result
✅ 9.0
✅ 8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

dhurley14 added a commit to dhurley14/kibana that referenced this pull request Apr 22, 2025
@dhurley14
[Security Solution] [Detections] Clarify result of missing read-index…
09ea0ff 
… privileges on index patterns for a given rule (elastic#215941)

## Summary

Ref: elastic#193204

Updates the text shown when a rule may not have read privileges to a
given index pattern.

(cherry picked from commit 6e4a06e)

# Conflicts:
#	src/platform/packages/shared/kbn-doc-links/src/get_doc_links.ts
#	x-pack/solutions/security/plugins/security_solution/server/lib/detection_engine/rule_types/create_security_rule_type_wrapper.ts
dhurley14 added a commit that referenced this pull request Apr 23, 2025
@dhurley14
[9.0] [Security Solution] [Detections] Clarify result of missing read…
04e210d 
…-index privileges on index patterns for a given rule (#215941) (#218878)

# Backport

This will backport the following commits from `main` to `9.0`:
- [[Security Solution] [Detections] Clarify result of missing read-index
privileges on index patterns for a given rule
(#215941)](#215941)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Devin W.
Hurley","email":"devin.hurley@elastic.co"},"sourceCommit":{"committedDate":"2025-04-18T18:14:45Z","message":"[Security
Solution] [Detections] Clarify result of missing read-index privileges
on index patterns for a given rule (#215941)\n\n## Summary\n\nRef:
https://github.com/elastic/kibana/issues/193204\n\nUpdates the text
shown when a rule may not have read privileges to a\ngiven index
pattern.","sha":"6e4a06ee0f1f2f9e6a45ce064643be323066b66c","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","ci:cloud-deploy","ci:cloud-redeploy","backport:version","v9.1.0","v8.19.0","v9.0.1"],"title":"[Security
Solution] [Detections] Clarify result of missing read-index privileges
on index patterns for a given
rule","number":215941,"url":"https://github.com/elastic/kibana/pull/215941","mergeCommit":{"message":"[Security
Solution] [Detections] Clarify result of missing read-index privileges
on index patterns for a given rule (#215941)\n\n## Summary\n\nRef:
https://github.com/elastic/kibana/issues/193204\n\nUpdates the text
shown when a rule may not have read privileges to a\ngiven index
pattern.","sha":"6e4a06ee0f1f2f9e6a45ce064643be323066b66c"}},"sourceBranch":"main","suggestedTargetBranches":["8.19","9.0"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/215941","number":215941,"mergeCommit":{"message":"[Security
Solution] [Detections] Clarify result of missing read-index privileges
on index patterns for a given rule (#215941)\n\n## Summary\n\nRef:
https://github.com/elastic/kibana/issues/193204\n\nUpdates the text
shown when a rule may not have read privileges to a\ngiven index
pattern.","sha":"6e4a06ee0f1f2f9e6a45ce064643be323066b66c"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
dhurley14 added a commit that referenced this pull request Apr 23, 2025
@dhurley14
[8.19] [Security Solution] [Detections] Clarify result of missing rea…
fc39e86 
…d-index privileges on index patterns for a given rule (#215941) (#218882)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[Security Solution] [Detections] Clarify result of missing read-index
privileges on index patterns for a given rule
(#215941)](#215941)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Devin W.
Hurley","email":"devin.hurley@elastic.co"},"sourceCommit":{"committedDate":"2025-04-18T18:14:45Z","message":"[Security
Solution] [Detections] Clarify result of missing read-index privileges
on index patterns for a given rule (#215941)\n\n## Summary\n\nRef:
https://github.com/elastic/kibana/issues/193204\n\nUpdates the text
shown when a rule may not have read privileges to a\ngiven index
pattern.","sha":"6e4a06ee0f1f2f9e6a45ce064643be323066b66c","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","ci:cloud-deploy","ci:cloud-redeploy","backport:version","v9.1.0","v8.19.0","v9.0.1"],"title":"[Security
Solution] [Detections] Clarify result of missing read-index privileges
on index patterns for a given
rule","number":215941,"url":"https://github.com/elastic/kibana/pull/215941","mergeCommit":{"message":"[Security
Solution] [Detections] Clarify result of missing read-index privileges
on index patterns for a given rule (#215941)\n\n## Summary\n\nRef:
https://github.com/elastic/kibana/issues/193204\n\nUpdates the text
shown when a rule may not have read privileges to a\ngiven index
pattern.","sha":"6e4a06ee0f1f2f9e6a45ce064643be323066b66c"}},"sourceBranch":"main","suggestedTargetBranches":["8.19","9.0"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/215941","number":215941,"mergeCommit":{"message":"[Security
Solution] [Detections] Clarify result of missing read-index privileges
on index patterns for a given rule (#215941)\n\n## Summary\n\nRef:
https://github.com/elastic/kibana/issues/193204\n\nUpdates the text
shown when a rule may not have read privileges to a\ngiven index
pattern.","sha":"6e4a06ee0f1f2f9e6a45ce064643be323066b66c"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
akowalska622 pushed a commit to akowalska622/kibana that referenced this pull request May 29, 2025
@dhurley14 @akowalska622
[Security Solution] [Detections] Clarify result of missing read-index…
faf6f9b 
… privileges on index patterns for a given rule (elastic#215941)

## Summary

Ref: elastic#193204

Updates the text shown when a rule may not have read privileges to a
given index pattern.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wajihaparvez wajihaparvez wajihaparvez left review comments

@yctercero yctercero yctercero approved these changes

@nastasha-solomon nastasha-solomon nastasha-solomon approved these changes

@nkhristinin nkhristinin Awaiting requested review from nkhristinin

Assignees

@dhurley14 dhurley14

Labels

backport:version Backport to applied version labels ci:cloud-deploy Create or update a Cloud deployment ci:cloud-redeploy Always create a new Cloud deployment release_note:skip Skip the PR/issue when compiling release notes v8.19.0 v9.0.1 v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@dhurley14 @yctercero @elasticmachine @kibanamachine @nkhristinin @nastasha-solomon @wajihaparvez