[8.x] [ftr] split feature controls tests into v1/v2 configs (#217458)#217634
Closed
dmlemeshko wants to merge 1 commit intoelastic:8.xfrom
Closed
[8.x] [ftr] split feature controls tests into v1/v2 configs (#217458)#217634dmlemeshko wants to merge 1 commit intoelastic:8.xfrom
dmlemeshko wants to merge 1 commit intoelastic:8.xfrom
Conversation
## Summary Splitting long running config: `x-pack/test/functional/apps/saved_query_management/config.ts` **~57 min** into - x-pack/test/functional/apps/saved_query_management/config.ts 35m - x-pack/test/functional/apps/saved_query_management/config.v2.ts 25m 17s ideally we need to split both even more, but I will leave it for the later (probably Data-Discovery Team have some ideas how to re-org it?) (cherry picked from commit a234f36) # Conflicts: # x-pack/test/functional/apps/saved_query_management/feature_controls/security.ts
Contributor
|
We introduced v2 only in 9.x. So I don't think it needs to be backported to 8.x. I will disable auto merge for now. |
Contributor
💔 Build Failed
Failed CI Steps |
Contributor
Author
|
Backport contains only v1 tests, but with a new structure. I was hoping it may simplify backporting of test logic in the future. If it is redundant, happy to close it. |
Contributor
|
@jughosta Thanks for the heads up, I overlooked the backport label in my review. I think we're ok to leave things as they are in 8.x and close this one out. If it becomes an obstacle in the future, we could pick it back up. |
Contributor
Author
|
Thanks for checking, closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation