[ftr] split feature controls tests into v1/v2 configs#217458
Merged
dmlemeshko merged 4 commits intoelastic:mainfrom Apr 8, 2025
Merged
[ftr] split feature controls tests into v1/v2 configs#217458dmlemeshko merged 4 commits intoelastic:mainfrom
dmlemeshko merged 4 commits intoelastic:mainfrom
Conversation
dmlemeshko
added
FTR
v9.1.0
v8.19.0
v9.0.1
release_note:skip
jbudz
approved these changes
Apr 8, 2025
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
cc @dmlemeshko |
davismcphee
approved these changes
Apr 8, 2025
Contributor
davismcphee
left a comment
davismcphee
left a comment
There was a problem hiding this comment.
LGTM, thanks 👍 If we wanted to break it down further, we could do it by app instead, but I think by version like you have here makes sense too.
Contributor
|
Starting backport for target branches: 8.x, 9.0 https://github.com/elastic/kibana/actions/runs/14344416439 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 8, 2025
## Summary Splitting long running config: `x-pack/test/functional/apps/saved_query_management/config.ts` **~57 min** into - x-pack/test/functional/apps/saved_query_management/config.ts 35m - x-pack/test/functional/apps/saved_query_management/config.v2.ts 25m 17s ideally we need to split both even more, but I will leave it for the later (probably Data-Discovery Team have some ideas how to re-org it?) (cherry picked from commit a234f36)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Apr 8, 2025
…#217593) # Backport This will backport the following commits from `main` to `9.0`: - [[ftr] split feature controls tests into v1/v2 configs (#217458)](#217458) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Dzmitry Lemechko","email":"dzmitry.lemechko@elastic.co"},"sourceCommit":{"committedDate":"2025-04-08T22:01:06Z","message":"[ftr] split feature controls tests into v1/v2 configs (#217458)\n\n## Summary\n\nSplitting long running config:\n`x-pack/test/functional/apps/saved_query_management/config.ts` **~57\nmin** into\n\n - x-pack/test/functional/apps/saved_query_management/config.ts 35m \n- x-pack/test/functional/apps/saved_query_management/config.v2.ts 25m\n17s\n\nideally we need to split both even more, but I will leave it for the\nlater (probably Data-Discovery Team have some ideas how to re-org it?)","sha":"a234f3646c8076f7b285ebba589e2ccf4fc45c54","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","FTR","backport:version","v9.1.0","v8.19.0","v9.0.1"],"title":"[ftr] split feature controls tests into v1/v2 configs","number":217458,"url":"https://github.com/elastic/kibana/pull/217458","mergeCommit":{"message":"[ftr] split feature controls tests into v1/v2 configs (#217458)\n\n## Summary\n\nSplitting long running config:\n`x-pack/test/functional/apps/saved_query_management/config.ts` **~57\nmin** into\n\n - x-pack/test/functional/apps/saved_query_management/config.ts 35m \n- x-pack/test/functional/apps/saved_query_management/config.v2.ts 25m\n17s\n\nideally we need to split both even more, but I will leave it for the\nlater (probably Data-Discovery Team have some ideas how to re-org it?)","sha":"a234f3646c8076f7b285ebba589e2ccf4fc45c54"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","9.0"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/217458","number":217458,"mergeCommit":{"message":"[ftr] split feature controls tests into v1/v2 configs (#217458)\n\n## Summary\n\nSplitting long running config:\n`x-pack/test/functional/apps/saved_query_management/config.ts` **~57\nmin** into\n\n - x-pack/test/functional/apps/saved_query_management/config.ts 35m \n- x-pack/test/functional/apps/saved_query_management/config.v2.ts 25m\n17s\n\nideally we need to split both even more, but I will leave it for the\nlater (probably Data-Discovery Team have some ideas how to re-org it?)","sha":"a234f3646c8076f7b285ebba589e2ccf4fc45c54"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Dzmitry Lemechko <dzmitry.lemechko@elastic.co>
dmlemeshko
added a commit
to dmlemeshko/kibana
that referenced
this pull request
Apr 9, 2025
## Summary Splitting long running config: `x-pack/test/functional/apps/saved_query_management/config.ts` **~57 min** into - x-pack/test/functional/apps/saved_query_management/config.ts 35m - x-pack/test/functional/apps/saved_query_management/config.v2.ts 25m 17s ideally we need to split both even more, but I will leave it for the later (probably Data-Discovery Team have some ideas how to re-org it?) (cherry picked from commit a234f36) # Conflicts: # x-pack/test/functional/apps/saved_query_management/feature_controls/security.ts
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Splitting long running config:
x-pack/test/functional/apps/saved_query_management/config.ts~57 min intoideally we need to split both even more, but I will leave it for the later (probably Data-Discovery Team have some ideas how to re-org it?)