Skip to content

[A11y][APM] Add missing aria-label for some services buttons #217325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rmyz merged 1 commit into from
Apr 9, 2025
Merged

[A11y][APM] Add missing aria-label for some services buttons #217325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...servability/plugins/apm/public/components/app/service_groups/service_groups_list/sort.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@ export function Sort({ type, onChange }: Props) {
return (
<EuiSelect
data-test-subj="apmSortSelect"
aria-label={i18n.translate('xpack.apm.serviceGroups.list.sort.ariaLabel', {
defaultMessage: 'Sort service groups by',
})}
options={options}
value={type}
onChange={(e) => onChange(e.target.value as ServiceGroupsSortType)}
Expand Down
27 changes: 23 additions & 4 deletions ...utions/observability/plugins/apm/public/components/shared/key_value_filter_list/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import { i18n } from '@kbn/i18n';
import React, { Fragment } from 'react';
import styled from '@emotion/styled';
import { isEmpty } from 'lodash';
import { css } from '@emotion/react';

interface KeyValue {
key: string;
Expand Down Expand Up @@ -79,23 +80,41 @@ export function KeyValueFilterList({
<Fragment key={key}>
<EuiDescriptionListTitle
className="descriptionList__title"
style={{ height: '40px' }}
css={css`
height: 40px;
`}
>
<EuiText size="s" style={{ fontWeight: 'bold' }}>
<EuiText
size="s"
css={css`
font-weight: bold;
`}
>
{key}
</EuiText>
</EuiDescriptionListTitle>
<EuiDescriptionListDescription
className="descriptionList__description"
style={{ height: '40px' }}
css={css`
height: 40px;
`}
>
<EuiFlexGroup alignItems="baseline" responsive={false} gutterSize="none">
<EuiFlexItem style={{ minWidth: '32px' }} grow={false}>
<EuiFlexItem
css={css`
min-width: 32px;
`}
grow={false}
>
{isFilterable && (
<EuiButtonEmpty
onClick={() => {
onClickFilter({ key, value });
}}
aria-label={i18n.translate(
'xpack.apm.keyValueFilterList.actionFilterLabel',
{ defaultMessage: 'Filter by value' }
Copy link
Copy Markdown
Member

@jennypavlova jennypavlova Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: Why do we have filter by key in the test subject and filter by value in the aria label

Copy link
Copy Markdown
Contributor Author

@rmyz rmyz Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @jennypavlova, I used the same text we have for the tooltip.
Where did you see this filter by key? I was searching in https://github.com/elastic/kibana/blob/main/x-pack/solutions/observability/plugins/apm/public/components/shared/key_value_filter_list/key_value_filter_list.test.tsx but couldn't find it

Copy link
Copy Markdown
Member

@jennypavlova jennypavlova Apr 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On line 118 we have data-test-subj={filter_by_${key}} but I guess this is fine - also in the test you shared we have filter by foo not foo value but I guess the purpose there is to be unique so that's why we use the key, I was just wondering

Copy link
Copy Markdown
Contributor Author

@rmyz rmyz Apr 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see, I suppose that is used for the testing, and we need to know which field we want to target explicitly, that's why we use the key for

)}
data-test-subj={`filter_by_${key}`}
>
<EuiToolTip
Expand Down