[A11y][APM] Add missing aria-label for some services buttons#217325
Merged
rmyz merged 1 commit intoelastic:mainfrom Apr 9, 2025
Merged
[A11y][APM] Add missing aria-label for some services buttons#217325rmyz merged 1 commit intoelastic:mainfrom
aria-label for some services buttons#217325rmyz merged 1 commit intoelastic:mainfrom
Conversation
rmyz
added
release_note:fix
apm
Team:obs-ux-infra_services - DEPRECATED
Contributor
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
jennypavlova
approved these changes
Apr 8, 2025
| }} | ||
| aria-label={i18n.translate( | ||
| 'xpack.apm.keyValueFilterList.actionFilterLabel', | ||
| { defaultMessage: 'Filter by value' } |
Member
There was a problem hiding this comment.
Q: Why do we have filter by key in the test subject and filter by value in the aria label
Contributor
Author
There was a problem hiding this comment.
hey @jennypavlova, I used the same text we have for the tooltip.
Where did you see this filter by key? I was searching in https://github.com/elastic/kibana/blob/main/x-pack/solutions/observability/plugins/apm/public/components/shared/key_value_filter_list/key_value_filter_list.test.tsx but couldn't find it
Member
There was a problem hiding this comment.
On line 118 we have data-test-subj={filter_by_${key}} but I guess this is fine - also in the test you shared we have filter by foo not foo value but I guess the purpose there is to be unique so that's why we use the key, I was just wondering
Contributor
Author
There was a problem hiding this comment.
Oh, I see, I suppose that is used for the testing, and we need to know which field we want to target explicitly, that's why we use the key for
Contributor
|
Starting backport for target branches: 8.18, 8.x, 9.0 https://github.com/elastic/kibana/actions/runs/14351020437 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 9, 2025
…ic#217325) ## Summary Fixes elastic#212264 This PR adds a couple of `aria-label` attributes to buttons that do not have a screen-reader announcement under the Services and Services Groups pages. (cherry picked from commit 749f57c)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 9, 2025
…ic#217325) ## Summary Fixes elastic#212264 This PR adds a couple of `aria-label` attributes to buttons that do not have a screen-reader announcement under the Services and Services Groups pages. (cherry picked from commit 749f57c)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 9, 2025
…ic#217325) ## Summary Fixes elastic#212264 This PR adds a couple of `aria-label` attributes to buttons that do not have a screen-reader announcement under the Services and Services Groups pages. (cherry picked from commit 749f57c)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Apr 9, 2025
…217325) (#217615) # Backport This will backport the following commits from `main` to `9.0`: - [[A11y][APM] Add missing `aria-label` for some services buttons (#217325)](#217325) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Sergi Romeu","email":"sergi.romeu@elastic.co"},"sourceCommit":{"committedDate":"2025-04-09T07:02:15Z","message":"[A11y][APM] Add missing `aria-label` for some services buttons (#217325)\n\n## Summary\n\nFixes #212264\n\nThis PR adds a couple of `aria-label` attributes to buttons that do not\nhave a screen-reader announcement under the Services and Services Groups\npages.","sha":"749f57c12f685eee1f380644a39732773dcd7ab7","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","apm","Team:obs-ux-infra_services","backport:version","a11y","v8.18.0","v9.1.0","v8.19.0","v9.0.1"],"title":"[A11y][APM] Add missing `aria-label` for some services buttons","number":217325,"url":"https://github.com/elastic/kibana/pull/217325","mergeCommit":{"message":"[A11y][APM] Add missing `aria-label` for some services buttons (#217325)\n\n## Summary\n\nFixes #212264\n\nThis PR adds a couple of `aria-label` attributes to buttons that do not\nhave a screen-reader announcement under the Services and Services Groups\npages.","sha":"749f57c12f685eee1f380644a39732773dcd7ab7"}},"sourceBranch":"main","suggestedTargetBranches":["8.18","8.x","9.0"],"targetPullRequestStates":[{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/217325","number":217325,"mergeCommit":{"message":"[A11y][APM] Add missing `aria-label` for some services buttons (#217325)\n\n## Summary\n\nFixes #212264\n\nThis PR adds a couple of `aria-label` attributes to buttons that do not\nhave a screen-reader announcement under the Services and Services Groups\npages.","sha":"749f57c12f685eee1f380644a39732773dcd7ab7"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Sergi Romeu <sergi.romeu@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Apr 9, 2025
…#217325) (#217613) # Backport This will backport the following commits from `main` to `8.18`: - [[A11y][APM] Add missing `aria-label` for some services buttons (#217325)](#217325) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Sergi Romeu","email":"sergi.romeu@elastic.co"},"sourceCommit":{"committedDate":"2025-04-09T07:02:15Z","message":"[A11y][APM] Add missing `aria-label` for some services buttons (#217325)\n\n## Summary\n\nFixes #212264\n\nThis PR adds a couple of `aria-label` attributes to buttons that do not\nhave a screen-reader announcement under the Services and Services Groups\npages.","sha":"749f57c12f685eee1f380644a39732773dcd7ab7","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","apm","Team:obs-ux-infra_services","backport:version","a11y","v8.18.0","v9.1.0","v8.19.0","v9.0.1"],"title":"[A11y][APM] Add missing `aria-label` for some services buttons","number":217325,"url":"https://github.com/elastic/kibana/pull/217325","mergeCommit":{"message":"[A11y][APM] Add missing `aria-label` for some services buttons (#217325)\n\n## Summary\n\nFixes #212264\n\nThis PR adds a couple of `aria-label` attributes to buttons that do not\nhave a screen-reader announcement under the Services and Services Groups\npages.","sha":"749f57c12f685eee1f380644a39732773dcd7ab7"}},"sourceBranch":"main","suggestedTargetBranches":["8.18","8.x","9.0"],"targetPullRequestStates":[{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/217325","number":217325,"mergeCommit":{"message":"[A11y][APM] Add missing `aria-label` for some services buttons (#217325)\n\n## Summary\n\nFixes #212264\n\nThis PR adds a couple of `aria-label` attributes to buttons that do not\nhave a screen-reader announcement under the Services and Services Groups\npages.","sha":"749f57c12f685eee1f380644a39732773dcd7ab7"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Sergi Romeu <sergi.romeu@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Apr 9, 2025
…217325) (#217614) # Backport This will backport the following commits from `main` to `8.x`: - [[A11y][APM] Add missing `aria-label` for some services buttons (#217325)](#217325) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Sergi Romeu","email":"sergi.romeu@elastic.co"},"sourceCommit":{"committedDate":"2025-04-09T07:02:15Z","message":"[A11y][APM] Add missing `aria-label` for some services buttons (#217325)\n\n## Summary\n\nFixes #212264\n\nThis PR adds a couple of `aria-label` attributes to buttons that do not\nhave a screen-reader announcement under the Services and Services Groups\npages.","sha":"749f57c12f685eee1f380644a39732773dcd7ab7","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","apm","Team:obs-ux-infra_services","backport:version","a11y","v8.18.0","v9.1.0","v8.19.0","v9.0.1"],"title":"[A11y][APM] Add missing `aria-label` for some services buttons","number":217325,"url":"https://github.com/elastic/kibana/pull/217325","mergeCommit":{"message":"[A11y][APM] Add missing `aria-label` for some services buttons (#217325)\n\n## Summary\n\nFixes #212264\n\nThis PR adds a couple of `aria-label` attributes to buttons that do not\nhave a screen-reader announcement under the Services and Services Groups\npages.","sha":"749f57c12f685eee1f380644a39732773dcd7ab7"}},"sourceBranch":"main","suggestedTargetBranches":["8.18","8.x","9.0"],"targetPullRequestStates":[{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/217325","number":217325,"mergeCommit":{"message":"[A11y][APM] Add missing `aria-label` for some services buttons (#217325)\n\n## Summary\n\nFixes #212264\n\nThis PR adds a couple of `aria-label` attributes to buttons that do not\nhave a screen-reader announcement under the Services and Services Groups\npages.","sha":"749f57c12f685eee1f380644a39732773dcd7ab7"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Sergi Romeu <sergi.romeu@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #212264
This PR adds a couple of
aria-labelattributes to buttons that do not have a screen-reader announcement under the Services and Services Groups pages.