Skip to content

[ES|QL] Makes the controls values clearable#217132

Merged
stratoula merged 3 commits intoelastic:mainfrom
stratoula:controls-clearable-combobox
Apr 8, 2025
Merged

[ES|QL] Makes the controls values clearable#217132
stratoula merged 3 commits intoelastic:mainfrom
stratoula:controls-clearable-combobox

Conversation

@stratoula
Copy link
Contributor

@stratoula stratoula commented Apr 4, 2025

Summary

Closes #217077

Adds a clear button in the values dropdowns

image image

@stratoula stratoula added v9.1.0 v8.19.0 Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana t// release_note:skip Skip the PR/issue when compiling release notes backport:version Backport to applied version labels labels Apr 4, 2025
@stratoula stratoula marked this pull request as ready for review April 4, 2025 06:37
@stratoula stratoula requested a review from a team as a code owner April 4, 2025 06:37
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #5 / useFetchIntegrationPolicyList() hook should call the correct fleet api with the query data provided

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
esql 243.7KB 243.9KB +221.0B

History

overflow-y: auto;
.euiFormControlLayoutIcons {
align-items: flex-start;
padding-block-start: 1ch;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ch... TIL

@stratoula stratoula merged commit 400a914 into elastic:main Apr 8, 2025
9 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/14326089925

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 8, 2025
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Apr 8, 2025
# Backport

This will backport the following commits from `main` to `8.x`:
- [[ES|QL] Makes the controls values clearable
(#217132)](#217132)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Stratoula
Kalafateli","email":"efstratia.kalafateli@elastic.co"},"sourceCommit":{"committedDate":"2025-04-08T05:47:43Z","message":"[ES|QL]
Makes the controls values clearable (#217132)\n\n## Summary\n\nCloses
https://github.com/elastic/kibana/issues/217077\n\nAdds a clear button
in the values dropdowns\n\n<img width=\"400\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/79d3f615-9ce1-4caa-be65-99895bb35d49\"\n/>\n\n\n<img
width=\"373\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/d4edab35-18a4-477c-afb3-a4b316db1a40\"\n/>","sha":"400a91464dbe6dd4a930eef92ea7a322922b149d","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Feature:ES|QL","Team:ESQL","backport:version","v9.1.0","v8.19.0"],"title":"[ES|QL]
Makes the controls values
clearable","number":217132,"url":"https://github.com/elastic/kibana/pull/217132","mergeCommit":{"message":"[ES|QL]
Makes the controls values clearable (#217132)\n\n## Summary\n\nCloses
https://github.com/elastic/kibana/issues/217077\n\nAdds a clear button
in the values dropdowns\n\n<img width=\"400\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/79d3f615-9ce1-4caa-be65-99895bb35d49\"\n/>\n\n\n<img
width=\"373\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/d4edab35-18a4-477c-afb3-a4b316db1a40\"\n/>","sha":"400a91464dbe6dd4a930eef92ea7a322922b149d"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/217132","number":217132,"mergeCommit":{"message":"[ES|QL]
Makes the controls values clearable (#217132)\n\n## Summary\n\nCloses
https://github.com/elastic/kibana/issues/217077\n\nAdds a clear button
in the values dropdowns\n\n<img width=\"400\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/79d3f615-9ce1-4caa-be65-99895bb35d49\"\n/>\n\n\n<img
width=\"373\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/d4edab35-18a4-477c-afb3-a4b316db1a40\"\n/>","sha":"400a91464dbe6dd4a930eef92ea7a322922b149d"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:ESQL ES|QL related features in Kibana t// v8.19.0 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ES|QL] Filtering time with controls

4 participants