-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[WorkChat] Change index selector to a ComboBox for the "Index Source" integration #216998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
3902358
WIP
artem-shelkovnikov 5e364e2
Brush up the code
artem-shelkovnikov d597ee3
Lost data-test-subj
artem-shelkovnikov 7ccda8c
Merge branch 'main' into artem/add-index-search-combobox
artem-shelkovnikov 970452f
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine a4dc3cb
Merge branch 'main' into artem/add-index-search-combobox
artem-shelkovnikov 29e8970
One step forward
artem-shelkovnikov 55ba1d2
Sigh
artem-shelkovnikov 723b745
A bit better try/catch
artem-shelkovnikov 0620d01
Drop unused vars
artem-shelkovnikov f39a8f4
onChange fix
artem-shelkovnikov 152818c
Adjust implementation a bit
artem-shelkovnikov bbdec70
Merge branch 'main' into artem/add-index-search-combobox
artem-shelkovnikov afe2534
Merge branch 'main' into artem/add-index-search-combobox
artem-shelkovnikov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56 changes: 56 additions & 0 deletions
56
x-pack/solutions/chat/plugins/wci-index-source/public/hooks/use_index_name_autocomplete.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0; you may not use this file except in compliance with the Elastic License | ||
| * 2.0. | ||
| */ | ||
|
|
||
| import { useQuery } from '@tanstack/react-query'; | ||
| import { useState } from 'react'; | ||
| import useDebounce from 'react-use/lib/useDebounce'; | ||
| import type { CoreStart } from '@kbn/core/public'; | ||
| import { useKibana } from '@kbn/kibana-react-plugin/public'; | ||
| import type { SearchIndicesResponse } from '../../common/http_api/configuration'; | ||
|
|
||
| export const useIndexNameAutocomplete = ({ query }: { query: string }) => { | ||
| const { | ||
| services: { http, notifications }, | ||
| } = useKibana<CoreStart>(); | ||
|
|
||
| const [debouncedQuery, setDebounceQuery] = useState<string>(query); | ||
|
|
||
| useDebounce( | ||
| () => { | ||
| setDebounceQuery(query); | ||
| }, | ||
| 250, | ||
| [query] | ||
| ); | ||
|
|
||
| const { isLoading, data } = useQuery({ | ||
| queryKey: ['index-name-autocomplete', debouncedQuery], | ||
| queryFn: async () => { | ||
| if (query.length < 3) { | ||
| return []; | ||
| } | ||
| const response = await http.get<SearchIndicesResponse>( | ||
| `/internal/wci-index-source/indices-autocomplete`, | ||
| { | ||
| query: { | ||
| index: query, | ||
| }, | ||
| } | ||
| ); | ||
| return response.indexNames; | ||
| }, | ||
| initialData: [], | ||
| onError: (err: any) => { | ||
| notifications.toasts.addError(err, { title: 'Error fetching indices' }); | ||
| }, | ||
| }); | ||
|
|
||
| return { | ||
| isLoading, | ||
| data, | ||
| }; | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are surfacing the error in a toast, we should wrap the error string with the i18n logic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've copied it over from another WorkChat component - none of components are using i18n, so it should be fine to not do it here? Or should I change this everywhere in the code within the PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think it should be fine to not worry about i18n at this stage