[WorkChat] Change index selector to a ComboBox for the "Index Source" integration#216998
Conversation
pgayvallet
left a comment
There was a problem hiding this comment.
Functionally, it's looking okay!
Added comments / suggestions on improvements (note: those can be ignored if this is meant to be something temporary. I have no idea how much we're thinking of fully trashing the current UI for integration configurations)
| return response.indexNames; | ||
| }, | ||
| onError: (err: any) => { | ||
| notifications.toasts.addError(err, { title: 'Error fetching indices' }); |
There was a problem hiding this comment.
If we are surfacing the error in a toast, we should wrap the error string with the i18n logic
There was a problem hiding this comment.
I've copied it over from another WorkChat component - none of components are using i18n, so it should be fine to not do it here? Or should I change this everywhere in the code within the PR?
There was a problem hiding this comment.
i think it should be fine to not worry about i18n at this stage
💚 Build Succeeded
Metrics [docs]Module Count
Page load bundle
History
|
Closes https://github.com/elastic/search-team/issues/9656
Summary
This PR adds changes the input that allows user enter the index when configuring a WorkChat integration with "Index Source".
The video is better than a thousand words:
Before:
Screen.Recording.2025-04-04.at.18.23.52.mov
After:
Screen.Recording.2025-04-11.at.18.26.07.mov
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelines