Skip to content

[7.17] [Vega] Fix update vega spec in functional tests (#216620) #216749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
markov00 wants to merge 1 commit into from
Closed

[7.17] [Vega] Fix update vega spec in functional tests (#216620) #216749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion test/functional/apps/visualize/_vega_chart.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,11 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
});

it('should render different data in response to filter change', async function () {
await PageObjects.vegaChart.typeInSpec('"config": { "kibana": {"renderer": "svg"} },');
const { spec, isValid } = await PageObjects.vegaChart.getSpecAsJSON();
expect(isValid).to.be(true);
// add SVG renderer to read the Y axis labels
const updatedSpec = { ...spec, config: { kibana: { renderer: 'svg' } } };
await PageObjects.vegaChart.fillSpec(JSON.stringify(updatedSpec, null, 2));
await PageObjects.visEditor.clickGo();
await PageObjects.visChart.waitForVisualizationRenderingStabilized();
const fullDataLabels = await PageObjects.vegaChart.getYAxisLabels();
Expand Down
20 changes: 12 additions & 8 deletions test/functional/page_objects/vega_chart_page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
*/

import expect from '@kbn/expect';
import hjson from 'hjson';
import { FtrService } from '../ftr_provider_context';

const compareSpecs = (first: string, second: string) => {
Expand Down Expand Up @@ -74,14 +75,17 @@ export class VegaChartPageObject extends FtrService {
});
}

public async typeInSpec(text: string) {
const aceGutter = await this.getAceGutterContainer();

await aceGutter.doubleClick();
await this.browser.pressKeys(this.browser.keys.RIGHT);
await this.browser.pressKeys(this.browser.keys.LEFT);
await this.browser.pressKeys(this.browser.keys.LEFT);
await this.browser.pressKeys(text);
public async getSpecAsJSON() {
const text = await this.getSpec();
try {
const spec = hjson.parse(text, { legacyRoot: false, keepWsc: true });
return {
spec,
isValid: true,
};
} catch (err) {
return { spec: text, isValid: false };
}
}

public async cleanSpec() {
Expand Down