[7.17] [Vega] Fix update vega spec in functional tests (#216620)#216749
Closed
markov00 wants to merge 1 commit intoelastic:7.17from
Closed
[7.17] [Vega] Fix update vega spec in functional tests (#216620)#216749markov00 wants to merge 1 commit intoelastic:7.17from
markov00 wants to merge 1 commit intoelastic:7.17from
Conversation
## Summary This PR fixes a flaky test practice that was causing issues in 7.17 branch. The flakiness was introduced long ago when the choosen method to update/add more content to the Vega Spec was done by manually clicking in the Vega spec editor the left border (where the editor shows the line numbers) to select all the text in the editor and go to the last line but a char before the end of the text (right before the closing bracket). The failure highlighted by elastic#213646 where caused the added `config` text positioned in the wrong line/column due to the Konami Code like type of functional test operation. The fix instead provides a more robust method: it takes the written text in the editor, parse it to JSON, update the JSON and write it back again to the editor. Will fix the issue elastic#213646 when backported to 7.17. (cherry picked from commit 200ec10) # Conflicts: # test/functional/apps/visualize/_vega_chart.ts # test/functional/page_objects/vega_chart_page.ts # x-pack/test_serverless/functional/test_suites/common/visualizations/group1/vega_chart.ts
Contributor
⏳ Build in-progress, with failures
Failed CI StepsTest Failures
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto7.17:Questions ?
Please refer to the Backport tool documentation
\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Marco Vettorello "}},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com//pull/216620","number":216620,"mergeCommit":{"message":"[Vega] Fix update vega spec in functional tests (#216620)\n\n## Summary\n\nThis PR fixes a flaky test practice that was causing issues in 7.17\nbranch.\nThe flakiness was introduced long ago when the choosen method to\nupdate/add more content to the Vega Spec was done by manually clicking\nin the Vega spec editor the left border (where the editor shows the line\nnumbers) to select all the text in the editor and go to the last line\nbut a char before the end of the text (right before the closing\nbracket).\n\nThe failure highlighted by\nhttps://github.com//issues/213646 where caused the added\n`config` text positioned in the wrong line/column due to the Konami Code\nlike type of functional test operation.\n\n\nThe fix instead provides a more robust method: it takes the written text\nin the editor, parse it to JSON, update the JSON and write it back again\nto the editor.\n\nWill fix the issue https://github.com//issues/213646 when\nbackported to 7.17.","sha":"200ec10593480edc3ef7b0d0ea77b29c787d1382"}},{"url":"https://github.com//pull/216670","number":216670,"branch":"8.16","state":"OPEN"},{"url":"https://github.com//pull/216672","number":216672,"branch":"8.17","state":"OPEN"},{"url":"https://github.com//pull/216673","number":216673,"branch":"8.18","state":"OPEN"},{"url":"https://github.com//pull/216675","number":216675,"branch":"8.x","state":"OPEN"}]}] BACKPORT-->