[8.x] [ResponseOps][Rules] Create Rules APIs package (#214187)#216006
Merged
umbopepato merged 7 commits intoelastic:8.xfrom Mar 26, 2025
Merged
[8.x] [ResponseOps][Rules] Create Rules APIs package (#214187)#216006umbopepato merged 7 commits intoelastic:8.xfrom
umbopepato merged 7 commits intoelastic:8.xfrom
Conversation
## Summary - Creates a `@kbn/response-ops-rules-apis` package, following the proposed structure for ResponseOps Management Experiences package. - Moves relevant rules API fetchers and react-query hooks to the new package. - Adds an internal variant of the `/api/alerting/rule_types` endpoint (`/internal/alerting/_rule_types`), that returns the same value as the public one + the newly added internal [`solution` field](elastic#212017), that we don't want to expose publicly. ## Verification steps 1. Create rules that fire alerts 2. Verify the usages of the moved/changed hooks, with limited privileges as well (i.e. only `Rules Settings` but not `Stack Rules`): 2.1. Stack management and Observability rules, rule details and alerts pages 2.2. Rules tab in the Connector editor flyout 2.3. Alerts table row actions (••• icon) 2.4. Tags filter in the rules list page 3. Using the DevTools, compare the response of the public and internal `rule_types` endpoins: ``` GET kbn:/api/alerting/rule_types GET kbn:/internal/alerting/_rule_types ``` Checking that the `solution` field is present only in the internal one ## References Closes elastic#213059 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 7aac590) # Conflicts: # .github/CODEOWNERS # x-pack/platform/plugins/shared/alerting/common/routes/rule/apis/list_types/schemas/v1.ts # x-pack/test/alerting_api_integration/security_and_spaces/group1/tests/alerting/rule_types_internal.ts # x-pack/test/alerting_api_integration/security_and_spaces/group5/tests/alerting/index.ts # x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group1/get_rule_tags.ts
botelastic
bot
added
the
Team:actionable-obs
1 task
Contributor
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
cnasikas
approved these changes
Mar 26, 2025
…#216047) ## Summary Quick fix to a lint error present in main after elastic#212508 - probably a case of merge race condition see: https://buildkite.com/elastic/kibana-on-merge/builds/65208#0195d2a4-1f65-4ecc-9c45-25b789d8ca79
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
ESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation