Fix: APM should not have a hard requirement on kuery_autocomplete#21539
Merged
lukasolson merged 1 commit intoelastic:masterfrom Aug 1, 2018
Merged
Fix: APM should not have a hard requirement on kuery_autocomplete#21539lukasolson merged 1 commit intoelastic:masterfrom
lukasolson merged 1 commit intoelastic:masterfrom
Conversation
sorenlouv
approved these changes
Aug 1, 2018
lukasolson
added a commit
to lukasolson/kibana
that referenced
this pull request
Aug 1, 2018
lukasolson
added a commit
that referenced
this pull request
Aug 1, 2018
Contributor
Author
Contributor
💔 Build Failed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was thinking about #21249 and while APM does use Kuery's autocomplete, the plugin itself should not have a hard requirement on the
kuery_autocompletesince it can (and does) handle the situation when no autocomplete providers are registered for kuery.This PR simply removes the hard requirement so that if someone disables the
kuery_autocompleteplugin, it doesn't prevent Kibana from starting completely, and the query bar in APM still works but just doesn't show suggestions.