Fix Kuery autocomplete in APM#21249
Merged
lukasolson merged 1 commit intoelastic:masterfrom Jul 25, 2018
Merged
Conversation
sorenlouv
approved these changes
Jul 25, 2018
Member
sorenlouv
left a comment
sorenlouv
left a comment
There was a problem hiding this comment.
Thanks for fixing this so quickly 👍
spalger
approved these changes
Jul 25, 2018
Contributor
💔 Build Failed |
lukasolson
added a commit
to lukasolson/kibana
that referenced
this pull request
Jul 25, 2018
lukasolson
added a commit
to lukasolson/kibana
that referenced
this pull request
Jul 25, 2018
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When #20747 was implemented, it was done at first in a hack, which meant it was loaded on every page (even in APM). However, when it was changed to its own UI export type, this meant we needed to load it in the APM plugin. That's exactly what this PR does, so that autocomplete once again works.