[8.x] [Discover] Enable consistent-type-imports eslint rule (#212293)

.eslintrc.js

@@ -1614,10 +1614,11 @@ module.exports = {
      */
     {
       files: [
-        'src/platform/plugins/shared/discover/**/*.{ts,tsx}',
-        'src/platform/plugins/shared/saved_search/**/*.{ts,tsx}',
+        'src/platform/plugins/shared/discover/**/*.{js,mjs,ts,tsx}',
+        'src/platform/plugins/shared/saved_search/**/*.{js,mjs,ts,tsx}',
       ],
       rules: {
+        '@typescript-eslint/consistent-type-imports': 'error',
         '@typescript-eslint/no-explicit-any': 'error',
         '@typescript-eslint/ban-ts-comment': [
           'error',

src/platform/plugins/shared/discover/common/app_locator.test.ts

@@ -15,7 +15,7 @@ import {
 import { mockStorage } from '@kbn/kibana-utils-plugin/public/storage/hashed_item_store/mock';
 import { FilterStateStore } from '@kbn/es-query';
 import { DiscoverAppLocatorDefinition } from './app_locator';
-import { SerializableRecord } from '@kbn/utility-types';
+import type { SerializableRecord } from '@kbn/utility-types';
 import { createDataViewDataSource, createEsqlDataSource } from './data_sources';
 
 const dataViewId: string = 'c367b774-a4c2-11ea-bb37-0242ac130002';

src/platform/plugins/shared/discover/common/app_locator.ts

@@ -8,13 +8,14 @@
  */
 
 import type { SerializableRecord } from '@kbn/utility-types';
-import { Filter, TimeRange, Query, AggregateQuery, isOfAggregateQueryType } from '@kbn/es-query';
+import type { Filter, TimeRange, Query, AggregateQuery } from '@kbn/es-query';
+import { isOfAggregateQueryType } from '@kbn/es-query';
 import type { GlobalQueryStateFromUrl, RefreshInterval } from '@kbn/data-plugin/public';
 import type { LocatorDefinition, LocatorPublic } from '@kbn/share-plugin/public';
 import type { DiscoverGridSettings } from '@kbn/saved-search-plugin/common';
-import { DataViewSpec } from '@kbn/data-views-plugin/common';
-import { setStateToKbnUrl } from '@kbn/kibana-utils-plugin/common';
-import { VIEW_MODE } from './constants';
+import type { DataViewSpec } from '@kbn/data-views-plugin/common';
+import type { setStateToKbnUrl } from '@kbn/kibana-utils-plugin/common';
+import type { VIEW_MODE } from './constants';
 import type { DiscoverAppState } from '../public';
 import { createDataViewDataSource, createEsqlDataSource } from './data_sources';
 

src/platform/plugins/shared/discover/common/embeddable/search_inject_extract.test.ts

@@ -7,7 +7,7 @@
  * License v3.0 only", or the "Server Side Public License, v 1".
  */
 
-import { SavedSearchByValueAttributes } from '@kbn/saved-search-plugin/public';
+import type { SavedSearchByValueAttributes } from '@kbn/saved-search-plugin/public';
 import { extract, inject } from './search_inject_extract';
 
 describe('search inject extract', () => {

src/platform/plugins/shared/discover/common/embeddable/search_inject_extract.ts

@@ -8,7 +8,7 @@
  */
 
 import type { SavedObjectReference } from '@kbn/core-saved-objects-server';
-import { EmbeddableStateWithType } from '@kbn/embeddable-plugin/common';
+import type { EmbeddableStateWithType } from '@kbn/embeddable-plugin/common';
 import type { SavedSearchByValueAttributes } from '@kbn/saved-search-plugin/public';
 
 export const inject = (

src/platform/plugins/shared/discover/common/esql_locator.ts

@@ -8,8 +8,8 @@
  */
 
 import { DISCOVER_ESQL_LOCATOR } from '@kbn/deeplinks-analytics';
-import { LocatorDefinition, LocatorPublic } from '@kbn/share-plugin/common';
-import { SerializableRecord } from '@kbn/utility-types';
+import type { LocatorDefinition, LocatorPublic } from '@kbn/share-plugin/common';
+import type { SerializableRecord } from '@kbn/utility-types';
 import { getIndexForESQLQuery, getInitialESQLQuery, getESQLAdHocDataview } from '@kbn/esql-utils';
 import type { DataViewsPublicPluginStart } from '@kbn/data-views-plugin/public';
 

src/platform/plugins/shared/discover/common/utils/sorting/get_es_query_sort.test.ts

@@ -16,7 +16,7 @@ import {
   getTieBreakerFieldName,
 } from './get_es_query_sort';
 import { CONTEXT_TIE_BREAKER_FIELDS_SETTING } from '@kbn/discover-utils';
-import { IUiSettingsClient } from '@kbn/core-ui-settings-browser';
+import type { IUiSettingsClient } from '@kbn/core-ui-settings-browser';
 
 const dataView = createStubDataView({
   spec: {

src/platform/plugins/shared/discover/common/utils/sorting/get_sort.ts

@@ -7,7 +7,7 @@
  * License v3.0 only", or the "Server Side Public License, v 1".
  */
 
-import { DataView } from '@kbn/data-views-plugin/common';
+import type { DataView } from '@kbn/data-views-plugin/common';
 import type { SortOrder } from '@kbn/saved-search-plugin/public';
 import { isPlainObject } from 'lodash';
 

src/platform/plugins/shared/discover/public/__mocks__/__storybook_mocks__/get_data_view_mock.tsx

@@ -7,7 +7,7 @@
  * License v3.0 only", or the "Server Side Public License, v 1".
  */
 
-import { DataView } from '@kbn/data-views-plugin/common';
+import type { DataView } from '@kbn/data-views-plugin/common';
 
 export function getDataViewMock(isTimebased = true) {
   const fields = [

src/platform/plugins/shared/discover/public/__mocks__/__storybook_mocks__/with_discover_services.tsx

@@ -7,12 +7,13 @@
  * License v3.0 only", or the "Server Side Public License, v 1".
  */
 
-import React, { FunctionComponent, ReactNode } from 'react';
+import type { FunctionComponent, ReactNode } from 'react';
+import React from 'react';
 import { action } from '@storybook/addon-actions';
 import { BehaviorSubject, Observable, of } from 'rxjs';
 import { FieldFormat } from '@kbn/field-formats-plugin/common';
 import { identity } from 'lodash';
-import { IUiSettingsClient } from '@kbn/core/public';
+import type { IUiSettingsClient } from '@kbn/core/public';
 import {
   DEFAULT_COLUMNS_SETTING,
   DOC_TABLE_LEGACY,
@@ -23,9 +24,9 @@ import {
   SHOW_MULTIFIELDS,
 } from '@kbn/discover-utils';
 import { LocalStorageMock } from '../local_storage_mock';
-import { DiscoverServices } from '../../build_services';
+import type { DiscoverServices } from '../../build_services';
 import { KibanaContextProvider } from '@kbn/kibana-react-plugin/public';
-import { SavedQuery } from '@kbn/data-plugin/public';
+import type { SavedQuery } from '@kbn/data-plugin/public';
 
 interface DiscoverServicesProviderProps {
   children: ReactNode;

src/platform/plugins/shared/discover/public/__mocks__/config.ts

@@ -7,7 +7,7 @@
  * License v3.0 only", or the "Server Side Public License, v 1".
  */
 
-import { IUiSettingsClient } from '@kbn/core/public';
+import type { IUiSettingsClient } from '@kbn/core/public';
 import { SORT_DEFAULT_ORDER_SETTING } from '@kbn/discover-utils';
 
 export const configMock = {

src/platform/plugins/shared/discover/public/__mocks__/data_view_complex.ts

@@ -7,7 +7,7 @@
  * License v3.0 only", or the "Server Side Public License, v 1".
  */
 
-import { DataView } from '@kbn/data-views-plugin/public';
+import type { DataView } from '@kbn/data-views-plugin/public';
 import { buildDataViewMock } from '@kbn/discover-utils/src/__mocks__';
 
 const fields = [

src/platform/plugins/shared/discover/public/__mocks__/data_view_esql.ts

@@ -8,7 +8,7 @@
  */
 
 import { buildDataViewMock } from '@kbn/discover-utils/src/__mocks__';
-import { DataView } from '@kbn/data-views-plugin/common';
+import type { DataView } from '@kbn/data-views-plugin/common';
 
 const fields = [
   {

src/platform/plugins/shared/discover/public/__mocks__/data_view_no_timefield.ts

@@ -7,7 +7,7 @@
  * License v3.0 only", or the "Server Side Public License, v 1".
  */
 
-import { DataView } from '@kbn/data-views-plugin/public';
+import type { DataView } from '@kbn/data-views-plugin/public';
 import { buildDataViewMock } from '@kbn/discover-utils/src/__mocks__';
 
 const fields = [

src/platform/plugins/shared/discover/public/__mocks__/data_view_with_timefield.ts

@@ -8,7 +8,7 @@
  */
 
 import { fieldList } from '@kbn/data-views-plugin/common';
-import { FieldSpec } from '@kbn/data-views-plugin/public';
+import type { FieldSpec } from '@kbn/data-views-plugin/public';
 import { buildDataViewMock } from '@kbn/discover-utils/src/__mocks__';
 
 const fields = [

src/platform/plugins/shared/discover/public/__mocks__/data_views.ts

@@ -7,7 +7,7 @@
  * License v3.0 only", or the "Server Side Public License, v 1".
  */
 
-import { DataViewsContract } from '@kbn/data-views-plugin/public';
+import type { DataViewsContract } from '@kbn/data-views-plugin/public';
 import { dataViewMock } from '@kbn/discover-utils/src/__mocks__';
 import { dataViewComplexMock } from './data_view_complex';
 import { dataViewWithTimefieldMock } from './data_view_with_timefield';

src/platform/plugins/shared/discover/public/__mocks__/discover_state.mock.ts

@@ -11,12 +11,10 @@ import { createBrowserHistory } from 'history';
 import { getDiscoverStateContainer } from '../application/main/state_management/discover_state';
 import { savedSearchMockWithTimeField, savedSearchMock } from './saved_search';
 import { discoverServiceMock } from './services';
-import { SavedSearch } from '@kbn/saved-search-plugin/public';
+import type { SavedSearch } from '@kbn/saved-search-plugin/public';
 import { mockCustomizationContext } from '../customizations/__mocks__/customization_context';
-import {
-  RuntimeStateManager,
-  createRuntimeStateManager,
-} from '../application/main/state_management/redux';
+import type { RuntimeStateManager } from '../application/main/state_management/redux';
+import { createRuntimeStateManager } from '../application/main/state_management/redux';
 
 export function getDiscoverStateMock({
   isTimeBased = true,

src/platform/plugins/shared/discover/public/__mocks__/saved_search.ts

@@ -7,7 +7,7 @@
  * License v3.0 only", or the "Server Side Public License, v 1".
  */
 
-import { SavedSearch } from '@kbn/saved-search-plugin/public';
+import type { SavedSearch } from '@kbn/saved-search-plugin/public';
 import { createSearchSourceMock } from '@kbn/data-plugin/public/mocks';
 import { dataViewMock } from '@kbn/discover-utils/src/__mocks__';
 import { dataViewWithTimefieldMock } from './data_view_with_timefield';

src/platform/plugins/shared/discover/public/__mocks__/search_session.ts

@@ -9,7 +9,7 @@
 
 import { createMemoryHistory } from 'history';
 import { dataPluginMock } from '@kbn/data-plugin/public/mocks';
-import { DataPublicPluginStart } from '@kbn/data-plugin/public';
+import type { DataPublicPluginStart } from '@kbn/data-plugin/public';
 import { DiscoverSearchSessionManager } from '../application/main/state_management/discover_search_session';
 
 export function createSearchSessionMock(

src/platform/plugins/shared/discover/public/__mocks__/services.ts

@@ -7,8 +7,9 @@
  * License v3.0 only", or the "Server Side Public License, v 1".
  */
 
-import { BehaviorSubject, Observable, of } from 'rxjs';
-import { DiscoverServices } from '../build_services';
+import type { Observable } from 'rxjs';
+import { BehaviorSubject, of } from 'rxjs';
+import type { DiscoverServices } from '../build_services';
 import { dataPluginMock } from '@kbn/data-plugin/public/mocks';
 import { uiActionsPluginMock } from '@kbn/ui-actions-plugin/public/mocks';
 import { expressionsPluginMock } from '@kbn/expressions-plugin/public/mocks';
@@ -41,8 +42,8 @@ import { fieldFormatsMock } from '@kbn/field-formats-plugin/common/mocks';
 import { embeddablePluginMock } from '@kbn/embeddable-plugin/public/mocks';
 import { LocalStorageMock } from './local_storage_mock';
 import { createDiscoverDataViewsMock } from './data_views';
-import { SearchSourceDependencies } from '@kbn/data-plugin/common';
-import { SearchResponse } from '@elastic/elasticsearch/lib/api/types';
+import type { SearchSourceDependencies } from '@kbn/data-plugin/common';
+import type { SearchResponse } from '@elastic/elasticsearch/lib/api/types';
 import { createElement } from 'react';
 import { createContextAwarenessMocks } from '../context_awareness/__mocks__';
 import { DiscoverEBTManager } from '../services/discover_ebt_manager';

src/platform/plugins/shared/discover/public/__mocks__/start_contract.ts

@@ -7,7 +7,7 @@
  * License v3.0 only", or the "Server Side Public License, v 1".
  */
 
-import { ApplicationStart, PublicAppInfo } from '@kbn/core/public';
+import type { ApplicationStart, PublicAppInfo } from '@kbn/core/public';
 import { deepFreeze } from '@kbn/std';
 import { BehaviorSubject, Subject } from 'rxjs';
 

src/platform/plugins/shared/discover/public/__mocks__/ui_settings.ts

@@ -7,7 +7,7 @@
  * License v3.0 only", or the "Server Side Public License, v 1".
  */
 
-import { IUiSettingsClient } from '@kbn/core/public';
+import type { IUiSettingsClient } from '@kbn/core/public';
 import {
   CONTEXT_TIE_BREAKER_FIELDS_SETTING,
   DEFAULT_COLUMNS_SETTING,

src/platform/plugins/shared/discover/public/__mocks__/url_tracker.mock.ts

@@ -7,7 +7,7 @@
  * License v3.0 only", or the "Server Side Public License, v 1".
  */
 
-import { UrlTracker } from '../build_services';
+import type { UrlTracker } from '../build_services';
 
 export const createUrlTrackerMock = () =>
   ({

src/platform/plugins/shared/discover/public/application/context/components/action_bar/action_bar.test.tsx

@@ -9,7 +9,8 @@
 
 import React from 'react';
 import { mountWithIntl } from '@kbn/test-jest-helpers';
-import { ActionBar, ActionBarProps } from './action_bar';
+import type { ActionBarProps } from './action_bar';
+import { ActionBar } from './action_bar';
 import { findTestSubject } from '@elastic/eui/lib/test';
 import { MAX_CONTEXT_SIZE, MIN_CONTEXT_SIZE } from '../../services/constants';
 import { SurrDocType } from '../../services/context';

src/platform/plugins/shared/discover/public/application/context/components/context_error_message/context_error_message.test.tsx

@@ -9,7 +9,7 @@
 
 import React from 'react';
 import { mountWithIntl } from '@kbn/test-jest-helpers';
-import { ReactWrapper } from 'enzyme';
+import type { ReactWrapper } from 'enzyme';
 import { ContextErrorMessage } from './context_error_message';
 import { FailureReason, LoadingStatus } from '../../services/context_query_state';
 import { findTestSubject } from '@elastic/eui/lib/test';

src/platform/plugins/shared/discover/public/application/context/components/context_error_message/context_error_message.tsx

@@ -10,11 +10,8 @@
 import React from 'react';
 import { EuiCallOut, EuiText } from '@elastic/eui';
 import { FormattedMessage } from '@kbn/i18n-react';
-import {
-  FailureReason,
-  LoadingStatus,
-  LoadingStatusEntry,
-} from '../../services/context_query_state';
+import type { LoadingStatusEntry } from '../../services/context_query_state';
+import { FailureReason, LoadingStatus } from '../../services/context_query_state';
 
 export interface ContextErrorMessageProps {
   /**

src/platform/plugins/shared/discover/public/application/context/context_app.test.tsx

@@ -15,7 +15,7 @@ import { mockTopNavMenu } from './__mocks__/top_nav_menu';
 import { ContextAppContent } from './context_app_content';
 import { dataViewMock } from '@kbn/discover-utils/src/__mocks__';
 import { ContextApp } from './context_app';
-import { DiscoverServices } from '../../build_services';
+import type { DiscoverServices } from '../../build_services';
 import { dataViewsMock } from '../../__mocks__/data_views';
 import { act } from 'react-dom/test-utils';
 import { uiSettingsMock } from '../../__mocks__/ui_settings';

src/platform/plugins/shared/discover/public/application/context/context_app.tsx

@@ -14,22 +14,24 @@ import { FormattedMessage } from '@kbn/i18n-react';
 import { EuiText, EuiPage, EuiPageBody, EuiSpacer, useEuiPaddingSize } from '@elastic/eui';
 import { css } from '@emotion/react';
 import { cloneDeep } from 'lodash';
-import { DataView, DataViewField } from '@kbn/data-views-plugin/public';
+import type { DataView, DataViewField } from '@kbn/data-views-plugin/public';
 import { useExecutionContext } from '@kbn/kibana-react-plugin/public';
 import { generateFilters } from '@kbn/data-plugin/public';
 import { i18n } from '@kbn/i18n';
 import { reportPerformanceMetricEvent } from '@kbn/ebt-tools';
+import type { UseColumnsProps } from '@kbn/unified-data-table';
+import { popularizeField, useColumns } from '@kbn/unified-data-table';
+import type { DocViewFilterFn } from '@kbn/unified-doc-viewer/types';
+import type { DiscoverGridSettings } from '@kbn/saved-search-plugin/common';
 import {
   DOC_TABLE_LEGACY,
   SEARCH_FIELDS_FROM_SOURCE,
   SORT_DEFAULT_ORDER_SETTING,
 } from '@kbn/discover-utils';
-import { UseColumnsProps, popularizeField, useColumns } from '@kbn/unified-data-table';
-import { DocViewFilterFn } from '@kbn/unified-doc-viewer/types';
-import { DiscoverGridSettings } from '@kbn/saved-search-plugin/common';
 import { ContextErrorMessage } from './components/context_error_message';
 import { LoadingStatus } from './services/context_query_state';
-import { AppState, GlobalState, isEqualFilters } from './services/context_state';
+import type { AppState, GlobalState } from './services/context_state';
+import { isEqualFilters } from './services/context_state';
 import { useContextAppState } from './hooks/use_context_app_state';
 import { useContextAppFetch } from './hooks/use_context_app_fetch';
 import { ContextAppContent } from './context_app_content';

src/platform/plugins/shared/discover/public/application/context/context_app_content.test.tsx

@@ -11,18 +11,19 @@ import React from 'react';
 import { EuiProvider } from '@elastic/eui';
 import { mountWithIntl } from '@kbn/test-jest-helpers';
 import { findTestSubject } from '@elastic/eui/lib/test';
-import { ActionBar } from './components/action_bar/action_bar';
-import { GetStateReturn } from './services/context_state';
-import { SortDirection } from '@kbn/data-plugin/public';
+import type { GetStateReturn } from './services/context_state';
+import type { SortDirection } from '@kbn/data-plugin/public';
 import { UnifiedDataTable } from '@kbn/unified-data-table';
-import { ContextAppContent, ContextAppContentProps } from './context_app_content';
+import type { ContextAppContentProps } from './context_app_content';
+import { ContextAppContent } from './context_app_content';
 import { LoadingStatus } from './services/context_query_state';
 import { discoverServiceMock } from '../../__mocks__/services';
 import { DocTableWrapper } from '../../components/doc_table/doc_table_wrapper';
 import { KibanaContextProvider } from '@kbn/kibana-react-plugin/public';
 import { buildDataTableRecord } from '@kbn/discover-utils';
 import { act } from 'react-dom/test-utils';
 import { buildDataViewMock, deepMockedFields } from '@kbn/discover-utils/src/__mocks__';
+import { ActionBar } from './components/action_bar/action_bar';
 
 const dataViewMock = buildDataViewMock({
   name: 'the-data-view',

src/platform/plugins/shared/discover/public/application/context/context_app_content.tsx

@@ -7,8 +7,8 @@
  * License v3.0 only", or the "Server Side Public License, v 1".
  */
 
-import React, { Fragment, useCallback, useMemo, useState, FC } from 'react';
-import { FormattedMessage } from '@kbn/i18n-react';
+import type { FC } from 'react';
+import React, { Fragment, useCallback, useMemo, useState } from 'react';
 import { EuiSpacer, EuiText, useEuiPaddingSize } from '@elastic/eui';
 import { css } from '@emotion/react';
 import type { DataView } from '@kbn/data-views-plugin/public';
@@ -28,21 +28,18 @@ import {
   ROW_HEIGHT_OPTION,
   SHOW_MULTIFIELDS,
 } from '@kbn/discover-utils';
-import {
-  DataLoadingState,
-  UnifiedDataTableProps,
-  getDataGridDensity,
-  getRowHeight,
-} from '@kbn/unified-data-table';
-import { DocViewFilterFn } from '@kbn/unified-doc-viewer/types';
+import type { UnifiedDataTableProps } from '@kbn/unified-data-table';
+import { DataLoadingState, getDataGridDensity, getRowHeight } from '@kbn/unified-data-table';
+import type { DocViewFilterFn } from '@kbn/unified-doc-viewer/types';
 import { useQuerySubscriber } from '@kbn/unified-field-list';
 import useObservable from 'react-use/lib/useObservable';
 import { map } from 'rxjs';
+import { FormattedMessage } from '@kbn/i18n-react';
 import { DiscoverGrid } from '../../components/discover_grid';
 import { getDefaultRowsPerPage } from '../../../common/constants';
 import { LoadingStatus } from './services/context_query_state';
 import { ActionBar } from './components/action_bar/action_bar';
-import { AppState } from './services/context_state';
+import type { AppState } from './services/context_state';
 import { SurrDocType } from './services/context';
 import { MAX_CONTEXT_SIZE, MIN_CONTEXT_SIZE } from './services/constants';
 import { DocTableContext } from '../../components/doc_table/doc_table_context';