[8.x] [Discover] Enable consistent-type-imports eslint rule (#212293)#214641
Merged
davismcphee merged 2 commits intoelastic:8.xfrom Mar 14, 2025
Merged
[8.x] [Discover] Enable consistent-type-imports eslint rule (#212293)#214641davismcphee merged 2 commits intoelastic:8.xfrom
consistent-type-imports eslint rule (#212293)#214641davismcphee merged 2 commits intoelastic:8.xfrom
Conversation
## Summary This PR enables the `@typescript-eslint/consistent-type-imports` eslint rule for the Discover and saved search plugins. The benefits are that it keeps things a bit cleaner, but more importantly ensures we aren't accidentally importing more than types when all we need is types, which can cause side effects. I've added `backport:prev-major` and `backport:prev-minor` labels to the PR because I figure backporting this is safe and would reduce merge conflicts in future backports. We should consider enabling this for all of our plugins and packages, although that list might harder to maintain. I'm also curious if anyone knows of other eslint rules we don't currently use that we'd benefit from enabling. ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit c398102) # Conflicts: # src/platform/plugins/shared/discover/public/application/context/context_app.tsx # src/platform/plugins/shared/discover/public/application/context/context_app_content.test.tsx # src/platform/plugins/shared/discover/public/application/context/context_app_content.tsx # src/platform/plugins/shared/discover/public/application/doc/components/doc.test.tsx # src/platform/plugins/shared/discover/public/application/main/components/layout/discover_layout.tsx # src/platform/plugins/shared/discover/public/application/main/components/loading_spinner/loading_spinner.tsx # src/platform/plugins/shared/discover/public/application/main/components/top_nav/on_save_search.tsx # src/platform/plugins/shared/discover/public/application/main/data_fetching/update_search_source.ts # src/platform/plugins/shared/discover/public/application/main/discover_main_route.test.tsx # src/platform/plugins/shared/discover/public/application/main/discover_main_route.tsx # src/platform/plugins/shared/discover/public/application/main/state_management/discover_state.ts # src/platform/plugins/shared/discover/public/application/main/state_management/utils/get_state_defaults.ts # src/platform/plugins/shared/discover/public/components/data_types/traces/summary_column.tsx # src/platform/plugins/shared/discover/public/context_awareness/profile_providers/observability/traces_data_source_profile/accessors/get_doc_viewer.tsx # src/platform/plugins/shared/discover/public/context_awareness/profile_providers/observability/traces_data_source_profile/profile.test.ts # src/platform/plugins/shared/discover/public/context_awareness/profile_providers/observability/traces_data_source_profile/profile.ts # src/platform/plugins/shared/discover/public/context_awareness/profile_providers/security/accessors/get_cell_renderer_accessor.test.tsx # src/platform/plugins/shared/discover/public/context_awareness/profile_providers/security/accessors/get_cell_renderer_accessor.tsx # src/platform/plugins/shared/discover/public/context_awareness/profile_providers/security/security_root_profile/profile.tsx # src/platform/plugins/shared/discover/public/embeddable/components/search_embeddable_grid_component.tsx # src/platform/plugins/shared/discover/public/plugin.tsx # src/platform/plugins/shared/discover/server/locator/columns_from_locator.ts
7 tasks
davismcphee
added
the
Team:DataDiscovery
Contributor
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
cc @davismcphee |
lukasolson
approved these changes
Mar 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:consistent-type-importseslint rule (#212293)Questions ?
Please refer to the Backport tool documentation