Skip to content

[8.x] [dashboard] clean up dashboard setup and start contracts (#212968)#214233

Merged
nreese merged 3 commits intoelastic:8.xfrom
nreese:backport/8.x/pr-212968
Mar 13, 2025
Merged

[8.x] [dashboard] clean up dashboard setup and start contracts (#212968)#214233
nreese merged 3 commits intoelastic:8.xfrom
nreese:backport/8.x/pr-212968

Conversation

@nreese
Copy link
Contributor

@nreese nreese commented Mar 12, 2025

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@nreese
[dashboard] clean up dashboard setup and start contracts (elastic#212968
32c68a9 
)

* remove `locator` from setup and start contract
* remove `dashboardFeatureFlagConfig` from start contract

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
(cherry picked from commit 377a812)

# Conflicts:
#	x-pack/platform/plugins/private/monitoring/tsconfig.json
#	x-pack/platform/plugins/shared/ml/public/application/jobs/new_job/job_from_dashboard/quick_create_job_base.ts
#	x-pack/platform/plugins/shared/stack_connectors/tsconfig.json
#	x-pack/solutions/observability/plugins/apm/tsconfig.json
@nreese nreese requested a review from kibanamachine as a code owner March 12, 2025 16:50
@nreese nreese added the backport This PR is a backport of another PR label Mar 12, 2025
@nreese nreese enabled auto-merge (squash) March 12, 2025 16:50
@botelastic botelastic bot added Feature:Drilldowns Embeddable panel Drilldowns Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation. Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. labels Mar 12, 2025
@nreese nreese mentioned this pull request Mar 12, 2025
Merged
@elasticmachine
Copy link
Contributor

elasticmachine commented Mar 12, 2025

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@elasticmachine
Copy link
Contributor

elasticmachine commented Mar 12, 2025

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@nreese nreese merged commit 1ff85c2 into elastic:8.x Mar 13, 2025
8 checks passed
@elasticmachine
Copy link
Contributor

elasticmachine commented Mar 13, 2025

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1918 1920 +2
dashboardEnhanced 85 87 +2
infra 1739 1741 +2
ml 2450 2452 +2
monitoring 732 734 +2
securitySolution 7122 7124 +2
stackConnectors 324 326 +2
total +14

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
dashboard 98 92 -6
dashboardEnhanced 51 50 -1
triggersActionsUi 529 530 +1
total -6

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 2.6MB 2.6MB +60.0B
infra 1.6MB 1.6MB +60.0B
ml 5.4MB 5.4MB +11.6KB
monitoring 664.7KB 664.8KB +77.0B
securitySolution 9.1MB 9.1MB +6.0B
stackConnectors 611.8KB 611.9KB +42.0B
total +11.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dashboard 17.5KB 17.3KB -244.0B
dashboardEnhanced 15.1KB 15.1KB +30.0B
ml 80.0KB 80.0KB -21.0B
total -235.0B
Unknown metric groups

API count

id before after diff
dashboard 101 95 -6
dashboardEnhanced 54 53 -1
triggersActionsUi 537 538 +1
total -6

async chunk count

id before after diff
ml 112 111 -1

ESLint disabled line counts

id before after diff
dashboard 13 14 +1

References to deprecated APIs

id before after diff
apm 27 26 -1
dashboardEnhanced 12 11 -1
infra 3 2 -1
ml 60 55 -5
monitoring 5 4 -1
securitySolution 470 469 -1
stackConnectors 2 0 -2
total -12

Total ESLint disabled count

id before after diff
dashboard 13 14 +1

Unreferenced deprecated APIs

id before after diff
dashboard 1 0 -1

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ThomThomson ThomThomson ThomThomson approved these changes

@kibanamachine kibanamachine Awaiting requested review from kibanamachine

Assignees

No one assigned

Labels

backport This PR is a backport of another PR Feature:Drilldowns Embeddable panel Drilldowns Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nreese @elasticmachine @ThomThomson @kibanamachine