[dashboard] clean up dashboard setup and start contracts by nreese · Pull Request #212968 · elastic/kibana

nreese · 2025-03-03T18:11:29Z

remove locator from setup and start contract
remove dashboardFeatureFlagConfig from start contract

…ntract

nreese · 2025-03-03T18:11:59Z

/ci

nreese · 2025-03-03T18:31:42Z

/ci

nreese · 2025-03-03T20:08:13Z

/ci

nreese · 2025-03-03T20:20:52Z

/ci

nreese · 2025-03-03T21:26:41Z

/ci

nreese · 2025-03-03T21:38:26Z

/ci

…-fix'

nreese · 2025-03-06T19:12:23Z

@elasticmachine merge upstream

elasticmachine · 2025-03-06T19:12:26Z

merge conflict between base and head

nreese · 2025-03-06T19:25:34Z

/ci

nreese · 2025-03-06T19:37:50Z

/ci

…apping'

…-fix'

nreese · 2025-03-06T20:19:54Z

/ci

nreese · 2025-03-06T22:06:09Z

/ci

nreese · 2025-03-06T22:21:12Z

/ci

…-fix'

elasticmachine · 2025-03-10T09:26:09Z

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

elasticmachine · 2025-03-10T09:26:10Z

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

ThomThomson

Presentation team changes LGTM!

ThomThomson · 2025-03-10T15:52:11Z

src/platform/plugins/shared/dashboard/public/plugin.tsx

      registerActions({
        plugins,
-        allowByValueEmbeddables: this.dashboardFeatureFlagConfig?.allowByValueEmbeddables,
+        allowByValueEmbeddables:


Linking this here as we should't forget to remove this setting.

darnautov

ML changes LGTM

afharo

kibana.jsonc changes LGTM

jennypavlova

APM / Infra Changes LGTM!

nreese · 2025-03-11T12:03:21Z

@elasticmachine merge upstream

consulthys

LGT Stack Monitoring

elasticmachine · 2025-03-12T15:40:21Z

💚 Build Succeeded

Buildkite Build
Commit: 68b0198

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`apm`	1886	1888	+2
`dashboardEnhanced`	85	87	+2
`infra`	1451	1453	+2
`ml`	2417	2419	+2
`monitoring`	653	655	+2
`stackConnectors`	325	327	+2
total			+12

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`dashboard`	97	91	-6
`dashboardEnhanced`	51	50	-1
`triggersActionsUi`	524	525	+1
total			-6

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`apm`	2.5MB	2.5MB	+57.0B
`infra`	1.2MB	1.2MB	+60.0B
`ml`	5.4MB	5.4MB	+11.6KB
`monitoring`	642.3KB	642.3KB	+77.0B
`stackConnectors`	615.2KB	615.3KB	+42.0B
total			+11.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`dashboard`	17.5KB	17.3KB	-244.0B
`dashboardEnhanced`	15.1KB	15.1KB	+30.0B
`ml`	79.6KB	79.5KB	-21.0B
total			-235.0B

Unknown metric groups

API count

id	before	after	diff
`dashboard`	101	95	-6
`dashboardEnhanced`	54	53	-1
`triggersActionsUi`	530	531	+1
total			-6

async chunk count

id	before	after	diff
`ml`	112	111	-1

ESLint disabled line counts

id	before	after	diff
`dashboard`	12	13	+1

References to deprecated APIs

id	before	after	diff
`apm`	27	26	-1
`dashboardEnhanced`	12	11	-1
`infra`	2	1	-1
`ml`	60	55	-5
`monitoring`	5	4	-1
`stackConnectors`	2	0	-2
total			-11

Total ESLint disabled count

id	before	after	diff
`dashboard`	12	13	+1

Unreferenced deprecated APIs

id	before	after	diff
`dashboard`	1	0	-1

History

💚 Build #282685 succeeded f6ccd60
💚 Build #281921 succeeded 239b53d
💔 Build #281897 failed 0f85616
💔 Build #281646 failed bd688a2
💔 Build #281628 failed b3ed0e6
💔 Build #281594 failed 80e242e

kibanamachine · 2025-03-12T16:36:55Z

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/13816696737

kibanamachine · 2025-03-12T16:42:23Z

💔 All backports failed

Status	Branch	Result
❌	8.x	Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 212968

Questions ?

Please refer to the Backport tool documentation

) * remove `locator` from setup and start contract * remove `dashboardFeatureFlagConfig` from start contract --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 377a812) # Conflicts: # x-pack/platform/plugins/private/monitoring/tsconfig.json # x-pack/platform/plugins/shared/ml/public/application/jobs/new_job/job_from_dashboard/quick_create_job_base.ts # x-pack/platform/plugins/shared/stack_connectors/tsconfig.json # x-pack/solutions/observability/plugins/apm/tsconfig.json

nreese · 2025-03-12T16:50:49Z

💚 All backports created successfully

Status	Branch	Result
✅	8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…) (#214233) # Backport This will backport the following commits from `main` to `8.x`: - [[dashboard] clean up dashboard setup and start contracts (#212968)](#212968)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)  --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

) * remove `locator` from setup and start contract * remove `dashboardFeatureFlagConfig` from start contract --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

[dashboard] remove dashboardFeatureFlagConfig from Dashboard start co…

7a5a8a2

…ntract

tslint

7d79495

remove locator from dashboard setup and start contract

fea861e

nreese changed the title ~~[dashboard] remove dashboardFeatureFlagConfig from Dashboard start contract~~ [dashboard] clean up dashboard setup and start contracts Mar 3, 2025

ml tslint

d8ec413

nreese force-pushed the remove_dashboardFeatureFlagConfig branch from d46b299 to d8ec413 Compare March 3, 2025 21:26

nreese and others added 2 commits March 3, 2025 14:29

clean up

42a9cc7

[CI] Auto-commit changed files from 'node scripts/yarn_deduplicate'

a3e9101

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

6c2bede

…-fix'

nreese added 2 commits March 6, 2025 12:16

merge with main

a9a05f9

tslint

f38a198

[CI] Auto-commit changed files from 'node scripts/notice'

db6beb5

kibanamachine added 2 commits March 6, 2025 19:46

[CI] Auto-commit changed files from 'node scripts/styled_components_m…

8a1efd2

…apping'

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

80e242e

…-fix'

tslint

68b43e6

[CI] Auto-commit changed files from 'node scripts/yarn_deduplicate'

b3ed0e6

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

bd688a2

…-fix'

nreese added the backport:version Backport to applied version labels label Mar 7, 2025

Dosant approved these changes Mar 10, 2025

View reviewed changes

botelastic bot added Feature:Drilldowns Embeddable panel Drilldowns Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation. Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. labels Mar 10, 2025

adcoelho approved these changes Mar 10, 2025

View reviewed changes

shahzad31 approved these changes Mar 10, 2025

View reviewed changes

ThomThomson approved these changes Mar 10, 2025

View reviewed changes

darnautov self-requested a review March 11, 2025 10:21

darnautov approved these changes Mar 11, 2025

View reviewed changes

afharo approved these changes Mar 11, 2025

View reviewed changes

jennypavlova self-requested a review March 11, 2025 10:59

jennypavlova approved these changes Mar 11, 2025

View reviewed changes

Merge branch 'main' into remove_dashboardFeatureFlagConfig

f6ccd60

yngrdyn approved these changes Mar 12, 2025

View reviewed changes

merge with main

68b0198

consulthys approved these changes Mar 12, 2025

View reviewed changes

nreese merged commit 377a812 into elastic:main Mar 12, 2025
9 checks passed

nreese mentioned this pull request Mar 12, 2025

[8.x] [dashboard] clean up dashboard setup and start contracts (#212968) #214233

Merged

stephmilovic mentioned this pull request May 21, 2025

[GenAI Connectors] Resolves missing dashboard link in edit tab #221209

Merged

Conversation

nreese commented Mar 3, 2025 • edited by kibanamachine Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nreese commented Mar 3, 2025

Uh oh!

nreese commented Mar 3, 2025

Uh oh!

nreese commented Mar 3, 2025

Uh oh!

nreese commented Mar 3, 2025

Uh oh!

nreese commented Mar 3, 2025

Uh oh!

nreese commented Mar 3, 2025

Uh oh!

nreese commented Mar 6, 2025

Uh oh!

elasticmachine commented Mar 6, 2025

Uh oh!

nreese commented Mar 6, 2025

Uh oh!

nreese commented Mar 6, 2025

Uh oh!

nreese commented Mar 6, 2025

Uh oh!

nreese commented Mar 6, 2025

Uh oh!

nreese commented Mar 6, 2025

Uh oh!

elasticmachine commented Mar 10, 2025

Uh oh!

elasticmachine commented Mar 10, 2025

Uh oh!

ThomThomson left a comment

Choose a reason for hiding this comment

Uh oh!

ThomThomson Mar 10, 2025

Choose a reason for hiding this comment

Uh oh!

darnautov left a comment

Choose a reason for hiding this comment

Uh oh!

afharo left a comment

Choose a reason for hiding this comment

Uh oh!

jennypavlova left a comment

Choose a reason for hiding this comment

Uh oh!

nreese commented Mar 11, 2025

Uh oh!

consulthys left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Mar 12, 2025

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Page load bundle

API count

async chunk count

ESLint disabled line counts

References to deprecated APIs

Total ESLint disabled count

Unreferenced deprecated APIs

History

Uh oh!

Uh oh!

kibanamachine commented Mar 12, 2025

Uh oh!

kibanamachine commented Mar 12, 2025

💔 All backports failed

Manual backport

Questions ?

Uh oh!

nreese commented Mar 12, 2025

💚 All backports created successfully

Questions ?

nreese commented Mar 3, 2025 •

edited by kibanamachine

Loading