[8.x] [ES|QL] Follow ups on variables (#213040)#213745
Merged
stratoula merged 1 commit intoelastic:8.xfrom Mar 10, 2025
Merged
Conversation
## Summary This PR: - add an extra information when hovering over a variable <img width="479" alt="image" src="https://github.com/user-attachments/assets/331f7faf-89e9-468d-9887-9d58a2f66ff7" /> - passes the variables on the fields retrieval endpoint in the editor to get the fields correctly when there are variables in the query ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 90a345b) # Conflicts: # src/platform/packages/shared/kbn-monaco/src/esql/lib/hover/helpers.test.ts # src/platform/packages/shared/kbn-monaco/src/esql/lib/hover/helpers.ts # src/platform/packages/shared/kbn-monaco/src/esql/lib/hover/hover.ts # src/platform/packages/shared/kbn-monaco/tsconfig.json
1 task
Contributor
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation