Skip to content

[8.x] [ES|QL] Follow ups on variables (#213040)#213745

Merged
stratoula merged 1 commit intoelastic:8.xfrom
stratoula:backport/8.x/pr-213040
Mar 10, 2025
Merged

[8.x] [ES|QL] Follow ups on variables (#213040)#213745
stratoula merged 1 commit intoelastic:8.xfrom
stratoula:backport/8.x/pr-213040

Conversation

@stratoula
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

## Summary

This PR:

- add an extra information when hovering over a variable
<img width="479" alt="image"
src="https://github.com/user-attachments/assets/331f7faf-89e9-468d-9887-9d58a2f66ff7"
/>

- passes the variables on the fields retrieval endpoint in the editor to
get the fields correctly when there are variables in the query

### Checklist
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 90a345b)

# Conflicts:
#	src/platform/packages/shared/kbn-monaco/src/esql/lib/hover/helpers.test.ts
#	src/platform/packages/shared/kbn-monaco/src/esql/lib/hover/helpers.ts
#	src/platform/packages/shared/kbn-monaco/src/esql/lib/hover/hover.ts
#	src/platform/packages/shared/kbn-monaco/tsconfig.json
@stratoula stratoula added the backport This PR is a backport of another PR label Mar 10, 2025
@stratoula stratoula enabled auto-merge (squash) March 10, 2025 13:57
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/esql-ast 250 251 +1
@kbn/esql-editor 14 15 +1
@kbn/esql-validation-autocomplete 201 200 -1
@kbn/monaco 128 127 -1
total -0

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.5MB 1.5MB +24.0B
stackAlerts 73.2KB 73.2KB +24.0B
total +48.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/esql-ast 26 25 -1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 3.6MB 3.6MB +493.0B
Unknown metric groups

API count

id before after diff
@kbn/esql-ast 313 314 +1
@kbn/esql-editor 37 38 +1
@kbn/esql-validation-autocomplete 213 212 -1
@kbn/monaco 128 127 -1
total -0

@stratoula stratoula disabled auto-merge March 10, 2025 15:52
@stratoula stratoula merged commit 4ebb2be into elastic:8.x Mar 10, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants