[ES|QL] Follow ups on variables#213040
Merged
stratoula merged 9 commits intoelastic:mainfrom Mar 10, 2025
Merged
Conversation
stratoula
added
v9.1.0
v8.19.0
backport:version
Contributor
|
Pinging @elastic/kibana-esql (Team:ESQL) |
Contributor
💛 Build succeeded, but was flaky
Failed CI Steps
Test Failures
Metrics [docs]Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
History
|
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Contributor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/13766215967 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
stratoula
added a commit
to stratoula/kibana
that referenced
this pull request
Mar 10, 2025
## Summary This PR: - add an extra information when hovering over a variable <img width="479" alt="image" src="https://github.com/user-attachments/assets/331f7faf-89e9-468d-9887-9d58a2f66ff7" /> - passes the variables on the fields retrieval endpoint in the editor to get the fields correctly when there are variables in the query ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 90a345b) # Conflicts: # src/platform/packages/shared/kbn-monaco/src/esql/lib/hover/helpers.test.ts # src/platform/packages/shared/kbn-monaco/src/esql/lib/hover/helpers.ts # src/platform/packages/shared/kbn-monaco/src/esql/lib/hover/hover.ts # src/platform/packages/shared/kbn-monaco/tsconfig.json
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
stratoula
added a commit
that referenced
this pull request
Mar 10, 2025
# Backport This will backport the following commits from `main` to `8.x`: - [[ES|QL] Follow ups on variables (#213040)](#213040) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Stratoula Kalafateli","email":"efstratia.kalafateli@elastic.co"},"sourceCommit":{"committedDate":"2025-03-10T13:45:27Z","message":"[ES|QL] Follow ups on variables (#213040)\n\n## Summary\n\nThis PR:\n\n- add an extra information when hovering over a variable\n<img width=\"479\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/331f7faf-89e9-468d-9887-9d58a2f66ff7\"\n/>\n\n- passes the variables on the fields retrieval endpoint in the editor to\nget the fields correctly when there are variables in the query\n\n\n### Checklist\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"90a345b21a33ce90ffaa49306d61e3ceefb1a56d","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Feature:ES|QL","Team:ESQL","backport:version","v9.1.0","v8.19.0"],"title":"[ES|QL] Follow ups on variables","number":213040,"url":"https://github.com/elastic/kibana/pull/213040","mergeCommit":{"message":"[ES|QL] Follow ups on variables (#213040)\n\n## Summary\n\nThis PR:\n\n- add an extra information when hovering over a variable\n<img width=\"479\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/331f7faf-89e9-468d-9887-9d58a2f66ff7\"\n/>\n\n- passes the variables on the fields retrieval endpoint in the editor to\nget the fields correctly when there are variables in the query\n\n\n### Checklist\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"90a345b21a33ce90ffaa49306d61e3ceefb1a56d"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/213040","number":213040,"mergeCommit":{"message":"[ES|QL] Follow ups on variables (#213040)\n\n## Summary\n\nThis PR:\n\n- add an extra information when hovering over a variable\n<img width=\"479\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/331f7faf-89e9-468d-9887-9d58a2f66ff7\"\n/>\n\n- passes the variables on the fields retrieval endpoint in the editor to\nget the fields correctly when there are variables in the query\n\n\n### Checklist\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"90a345b21a33ce90ffaa49306d61e3ceefb1a56d"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Mar 22, 2025
## Summary This PR: - add an extra information when hovering over a variable <img width="479" alt="image" src="https://github.com/user-attachments/assets/331f7faf-89e9-468d-9887-9d58a2f66ff7" /> - passes the variables on the fields retrieval endpoint in the editor to get the fields correctly when there are variables in the query ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR:
Checklist