Skip to content

[8.16] [Security Solution][Notes] change upper limit for max unassociated notes advanced setting to be 10k instead of 1k (#212786)#212930

Merged
PhilippeOberti merged 1 commit intoelastic:8.16from
PhilippeOberti:backport/8.16/pr-212786
Mar 3, 2025
Merged

[8.16] [Security Solution][Notes] change upper limit for max unassociated notes advanced setting to be 10k instead of 1k (#212786)#212930
PhilippeOberti merged 1 commit intoelastic:8.16from
PhilippeOberti:backport/8.16/pr-212786

Conversation

@PhilippeOberti
Copy link
Copy Markdown
Contributor

Backport

This will backport the following commits from main to 8.16:

Questions ?

Please refer to the Backport tool documentation

…tes advanced setting to be 10k instead of 1k (elastic#212786)

## Summary

This previous [PR](elastic#194947) made
the maximum number of unassociated notes an advanced settings so that
user can change the value within a certain limit. The intent was to
allow that value to be between 1 and 10,000 (see acceptance criteria of
the [original ticket](elastic#193097))
but we missed one 0 and the maximum value allowed got set to 1000.

This PR fixes that.

#### Before

![Screenshot 2025-02-28 at 9 18
14 AM](https://github.com/user-attachments/assets/cf1d473c-5bd5-4759-a834-60888b0c8f78)

#### After

![Screenshot 2025-02-28 at 9 18
47 AM](https://github.com/user-attachments/assets/129ba898-bbad-420a-b615-b0a456640af4)

(cherry picked from commit eabf95d)
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Mar 3, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Defend Workflows Cypress Tests on Serverless #9 / Policy Details Protection updates Renders and saves protection updates should render the protection updates tab content should render the protection updates tab content

Metrics [docs]

✅ unchanged

History

@PhilippeOberti PhilippeOberti merged commit 4776c2c into elastic:8.16 Mar 3, 2025
@PhilippeOberti PhilippeOberti deleted the backport/8.16/pr-212786 branch March 3, 2025 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants