[8.16] [Security Solution][Notes] change upper limit for max unassociated notes advanced setting to be 10k instead of 1k (#212786)#212821
Closed
kibanamachine wants to merge 1 commit intoelastic:8.16from
Conversation
…tes advanced setting to be 10k instead of 1k (elastic#212786) ## Summary This previous [PR](elastic#194947) made the maximum number of unassociated notes an advanced settings so that user can change the value within a certain limit. The intent was to allow that value to be between 1 and 10,000 (see acceptance criteria of the [original ticket](elastic#193097)) but we missed one 0 and the maximum value allowed got set to 1000. This PR fixes that. #### Before  #### After  (cherry picked from commit eabf95d)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
|
Contributor
|
@elasticmachine merge upstream |
Contributor
|
There are no new commits on the base branch. |
Contributor
|
@PhilippeOberti , looks very strange. The check is failing because PR is outdated but base branch has no new commits 🤷 |
Contributor
|
@elasticmachine merge upstream |
Contributor
|
There are no new commits on the base branch. |
auto-merge was automatically disabled
March 3, 2025 15:02
Pull request was closed
Contributor
Weird indeed... I closed this PR and opened a new one, let's see! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.16:Questions ?
Please refer to the Backport tool documentation