[8.17] [Security Solution][Notes] change upper limit for max unassociated notes advanced setting to be 10k instead of 1k (#212786)#212822
Merged
kibanamachine merged 1 commit intoelastic:8.17from Feb 28, 2025
Conversation
…tes advanced setting to be 10k instead of 1k (elastic#212786) ## Summary This previous [PR](elastic#194947) made the maximum number of unassociated notes an advanced settings so that user can change the value within a certain limit. The intent was to allow that value to be between 1 and 10,000 (see acceptance criteria of the [original ticket](elastic#193097)) but we missed one 0 and the maximum value allowed got set to 1000. This PR fixes that. #### Before  #### After  (cherry picked from commit eabf95d)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
💚 Build Succeeded
Metrics [docs]
|
PhilippeOberti
added a commit
that referenced
this pull request
Mar 3, 2025
…ated notes advanced setting to be 10k instead of 1k (#212786) (#212930) # Backport This will backport the following commits from `main` to `8.16`: - [[Security Solution][Notes] change upper limit for max unassociated notes advanced setting to be 10k instead of 1k (#212786)](#212786) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Philippe Oberti","email":"philippe.oberti@elastic.co"},"sourceCommit":{"committedDate":"2025-02-28T21:21:37Z","message":"[Security Solution][Notes] change upper limit for max unassociated notes advanced setting to be 10k instead of 1k (#212786)\n\n## Summary\n\nThis previous [PR](#194947) made\nthe maximum number of unassociated notes an advanced settings so that\nuser can change the value within a certain limit. The intent was to\nallow that value to be between 1 and 10,000 (see acceptance criteria of\nthe [original ticket](https://github.com/elastic/kibana/issues/193097))\nbut we missed one 0 and the maximum value allowed got set to 1000.\n\nThis PR fixes that.\n\n#### Before\n\n\n\n#### After\n\n","sha":"eabf95d6dc157d1c1ac2bb8832c7021986285aef","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat Hunting:Investigations","backport:all-open","v8.18.0","v9.1.0","v8.19.0","v8.17.3","v8.16.5"],"title":"[Security Solution][Notes] change upper limit for max unassociated notes advanced setting to be 10k instead of 1k","number":212786,"url":"https://github.com/elastic/kibana/pull/212786","mergeCommit":{"message":"[Security Solution][Notes] change upper limit for max unassociated notes advanced setting to be 10k instead of 1k (#212786)\n\n## Summary\n\nThis previous [PR](#194947) made\nthe maximum number of unassociated notes an advanced settings so that\nuser can change the value within a certain limit. The intent was to\nallow that value to be between 1 and 10,000 (see acceptance criteria of\nthe [original ticket](https://github.com/elastic/kibana/issues/193097))\nbut we missed one 0 and the maximum value allowed got set to 1000.\n\nThis PR fixes that.\n\n#### Before\n\n\n\n#### After\n\n","sha":"eabf95d6dc157d1c1ac2bb8832c7021986285aef"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/212825","number":212825,"state":"MERGED","mergeCommit":{"sha":"aa141aa281bb5c6f6c6503536349cb8bfefa7e7b","message":"[9.0] [Security Solution][Notes] change upper limit for max unassociated notes advanced setting to be 10k instead of 1k (#212786) (#212825)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.0`:\n- [[Security Solution][Notes] change upper limit for max unassociated\nnotes advanced setting to be 10k instead of 1k\n(#212786)](https://github.com/elastic/kibana/pull/212786)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Philippe Oberti <philippe.oberti@elastic.co>"}},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/212823","number":212823,"state":"MERGED","mergeCommit":{"sha":"b32e708ffc49f3d28cec6a85cc72dfcca3e7052d","message":"[8.18] [Security Solution][Notes] change upper limit for max unassociated notes advanced setting to be 10k instead of 1k (#212786) (#212823)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.18`:\n- [[Security Solution][Notes] change upper limit for max unassociated\nnotes advanced setting to be 10k instead of 1k\n(#212786)](https://github.com/elastic/kibana/pull/212786)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Philippe Oberti <philippe.oberti@elastic.co>"}},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212786","number":212786,"mergeCommit":{"message":"[Security Solution][Notes] change upper limit for max unassociated notes advanced setting to be 10k instead of 1k (#212786)\n\n## Summary\n\nThis previous [PR](#194947) made\nthe maximum number of unassociated notes an advanced settings so that\nuser can change the value within a certain limit. The intent was to\nallow that value to be between 1 and 10,000 (see acceptance criteria of\nthe [original ticket](https://github.com/elastic/kibana/issues/193097))\nbut we missed one 0 and the maximum value allowed got set to 1000.\n\nThis PR fixes that.\n\n#### Before\n\n\n\n#### After\n\n","sha":"eabf95d6dc157d1c1ac2bb8832c7021986285aef"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/212824","number":212824,"state":"MERGED","mergeCommit":{"sha":"b35c244503bff376b44ca7e2eca2a8ba06c263b2","message":"[8.x] [Security Solution][Notes] change upper limit for max unassociated notes advanced setting to be 10k instead of 1k (#212786) (#212824)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.x`:\n- [[Security Solution][Notes] change upper limit for max unassociated\nnotes advanced setting to be 10k instead of 1k\n(#212786)](https://github.com/elastic/kibana/pull/212786)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Philippe Oberti <philippe.oberti@elastic.co>"}},{"branch":"8.17","label":"v8.17.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/212822","number":212822,"state":"MERGED","mergeCommit":{"sha":"229aac1adf86b96d2718bc66670496263c1dc6c8","message":"[8.17] [Security Solution][Notes] change upper limit for max unassociated notes advanced setting to be 10k instead of 1k (#212786) (#212822)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.17`:\n- [[Security Solution][Notes] change upper limit for max unassociated\nnotes advanced setting to be 10k instead of 1k\n(#212786)](https://github.com/elastic/kibana/pull/212786)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Philippe Oberti <philippe.oberti@elastic.co>"}},{"branch":"8.16","label":"v8.16.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.17:Questions ?
Please refer to the Backport tool documentation