Skip to content

Rename FindingsBaseEsQuery interface in CSP package#212427

Merged
albertoblaz merged 1 commit intoelastic:mainfrom
albertoblaz:rename-csp-base-query
Feb 27, 2025
Merged

Rename FindingsBaseEsQuery interface in CSP package#212427
albertoblaz merged 1 commit intoelastic:mainfrom
albertoblaz:rename-csp-base-query

Conversation

@albertoblaz
Copy link
Contributor

@albertoblaz albertoblaz commented Feb 25, 2025

Summary

Rename the FindingsBaseEsQuery interface exposed by the @kibana/cloud-security-posture package as well as all references where it's imported.

Separating this renaming into its own PR also lets us tag it with backport:prev-minor and avoid potential merge conflicts in the future.

Depends on

Checklist

  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

Identify risks

No risk whatsoever.

@albertoblaz albertoblaz added release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related backport:prev-minor labels Feb 25, 2025
@albertoblaz albertoblaz self-assigned this Feb 25, 2025
@albertoblaz albertoblaz force-pushed the rename-csp-base-query branch from 23ac305 to e5db2e8 Compare February 25, 2025 17:50
@albertoblaz albertoblaz force-pushed the rename-csp-base-query branch from e5db2e8 to 37d1c8b Compare February 27, 2025 08:05
@albertoblaz albertoblaz marked this pull request as ready for review February 27, 2025 08:06
@albertoblaz albertoblaz requested a review from a team as a code owner February 27, 2025 08:06
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

@albertoblaz albertoblaz enabled auto-merge (squash) February 27, 2025 08:08
@albertoblaz albertoblaz merged commit aac8413 into elastic:main Feb 27, 2025
9 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 9.0

https://github.com/elastic/kibana/actions/runs/13564099013

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

  • 💔 Build #279203 failed e5db2e8ba489a58cadf219f5165f6cd1f6082eca

cc @albertoblaz

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
9.0 Backport failed because of merge conflicts

You might need to backport the following PRs to 9.0:
- Upgrade EUI to v99.3.0-borealis.0 (#211671)
- Update langchain (main) (#205553)
- [refactoring] Distinguish User Controls from Risk Engine in DashboardEnablementPanel (#212441)
- Move Findings Flyout to Security Solution or Shared Package Phase 1 (#212053)
- [Perfomance] Add is_initial_load meta (#206645)
- [Dashboard Navigation] Unskip tests (#211660)

Manual backport

To create the backport manually run:

node scripts/backport --pr 212427

Questions ?

Please refer to the Backport tool documentation

albertoblaz added a commit to albertoblaz/kibana that referenced this pull request Feb 27, 2025
Rename the `FindingsBaseEsQuery` interface exposed by the
`@kibana/cloud-security-posture` package as well as all references where
it's imported.

Separating this renaming into its own PR also lets us tag it with
`backport:prev-minor` and avoid potential merge conflicts in the future.

- elastic#210938

- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

No risk whatsoever.

(cherry picked from commit aac8413)
@albertoblaz
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
9.0
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

albertoblaz added a commit that referenced this pull request Feb 27, 2025
…212636)

# Backport

This will backport the following commits from `main` to `8.x`:
- [Rename FindingsBaseEsQuery interface in CSP package
(#212427)](#212427)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Alberto
Blázquez","email":"albertoblaz@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-02-27T10:20:06Z","message":"Rename
FindingsBaseEsQuery interface in CSP package (#212427)\n\n##
Summary\n\nRename the `FindingsBaseEsQuery` interface exposed by
the\n`@kibana/cloud-security-posture` package as well as all references
where\nit's imported.\n\nSeparating this renaming into its own PR also
lets us tag it with\n`backport:prev-minor` and avoid potential merge
conflicts in the future.\n\n### Depends on\n\n-
https://github.com/elastic/kibana/pull/210938\n\n### Checklist\n\n- [x]
The PR description includes the appropriate Release Notes section,\nand
the correct `release_note:*` label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n###
Identify risks\n\nNo risk
whatsoever.","sha":"aac841353dabe25974dfb661c9f4b591eb8fe42b","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Cloud
Security","backport:prev-minor","v9.1.0"],"title":"Rename
FindingsBaseEsQuery interface in CSP
package","number":212427,"url":"https://github.com/elastic/kibana/pull/212427","mergeCommit":{"message":"Rename
FindingsBaseEsQuery interface in CSP package (#212427)\n\n##
Summary\n\nRename the `FindingsBaseEsQuery` interface exposed by
the\n`@kibana/cloud-security-posture` package as well as all references
where\nit's imported.\n\nSeparating this renaming into its own PR also
lets us tag it with\n`backport:prev-minor` and avoid potential merge
conflicts in the future.\n\n### Depends on\n\n-
https://github.com/elastic/kibana/pull/210938\n\n### Checklist\n\n- [x]
The PR description includes the appropriate Release Notes section,\nand
the correct `release_note:*` label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n###
Identify risks\n\nNo risk
whatsoever.","sha":"aac841353dabe25974dfb661c9f4b591eb8fe42b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212427","number":212427,"mergeCommit":{"message":"Rename
FindingsBaseEsQuery interface in CSP package (#212427)\n\n##
Summary\n\nRename the `FindingsBaseEsQuery` interface exposed by
the\n`@kibana/cloud-security-posture` package as well as all references
where\nit's imported.\n\nSeparating this renaming into its own PR also
lets us tag it with\n`backport:prev-minor` and avoid potential merge
conflicts in the future.\n\n### Depends on\n\n-
https://github.com/elastic/kibana/pull/210938\n\n### Checklist\n\n- [x]
The PR description includes the appropriate Release Notes section,\nand
the correct `release_note:*` label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n###
Identify risks\n\nNo risk
whatsoever.","sha":"aac841353dabe25974dfb661c9f4b591eb8fe42b"}}]}]
BACKPORT-->
albertoblaz added a commit that referenced this pull request Feb 27, 2025
…212635)

# Backport

This will backport the following commits from `main` to `9.0`:
- [Rename FindingsBaseEsQuery interface in CSP package
(#212427)](#212427)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Alberto
Blázquez","email":"albertoblaz@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-02-27T10:20:06Z","message":"Rename
FindingsBaseEsQuery interface in CSP package (#212427)\n\n##
Summary\n\nRename the `FindingsBaseEsQuery` interface exposed by
the\n`@kibana/cloud-security-posture` package as well as all references
where\nit's imported.\n\nSeparating this renaming into its own PR also
lets us tag it with\n`backport:prev-minor` and avoid potential merge
conflicts in the future.\n\n### Depends on\n\n-
https://github.com/elastic/kibana/pull/210938\n\n### Checklist\n\n- [x]
The PR description includes the appropriate Release Notes section,\nand
the correct `release_note:*` label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n###
Identify risks\n\nNo risk
whatsoever.","sha":"aac841353dabe25974dfb661c9f4b591eb8fe42b","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Cloud
Security","backport:prev-minor","v9.1.0"],"title":"Rename
FindingsBaseEsQuery interface in CSP
package","number":212427,"url":"https://github.com/elastic/kibana/pull/212427","mergeCommit":{"message":"Rename
FindingsBaseEsQuery interface in CSP package (#212427)\n\n##
Summary\n\nRename the `FindingsBaseEsQuery` interface exposed by
the\n`@kibana/cloud-security-posture` package as well as all references
where\nit's imported.\n\nSeparating this renaming into its own PR also
lets us tag it with\n`backport:prev-minor` and avoid potential merge
conflicts in the future.\n\n### Depends on\n\n-
https://github.com/elastic/kibana/pull/210938\n\n### Checklist\n\n- [x]
The PR description includes the appropriate Release Notes section,\nand
the correct `release_note:*` label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n###
Identify risks\n\nNo risk
whatsoever.","sha":"aac841353dabe25974dfb661c9f4b591eb8fe42b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212427","number":212427,"mergeCommit":{"message":"Rename
FindingsBaseEsQuery interface in CSP package (#212427)\n\n##
Summary\n\nRename the `FindingsBaseEsQuery` interface exposed by
the\n`@kibana/cloud-security-posture` package as well as all references
where\nit's imported.\n\nSeparating this renaming into its own PR also
lets us tag it with\n`backport:prev-minor` and avoid potential merge
conflicts in the future.\n\n### Depends on\n\n-
https://github.com/elastic/kibana/pull/210938\n\n### Checklist\n\n- [x]
The PR description includes the appropriate Release Notes section,\nand
the correct `release_note:*` label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n###
Identify risks\n\nNo risk
whatsoever.","sha":"aac841353dabe25974dfb661c9f4b591eb8fe42b"}}]}]
BACKPORT-->
SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this pull request Mar 4, 2025
…2427) (elastic#212636)

# Backport

This will backport the following commits from `main` to `8.x`:
- [Rename FindingsBaseEsQuery interface in CSP package
(elastic#212427)](elastic#212427)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Alberto
Blázquez","email":"albertoblaz@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-02-27T10:20:06Z","message":"Rename
FindingsBaseEsQuery interface in CSP package (elastic#212427)\n\n##
Summary\n\nRename the `FindingsBaseEsQuery` interface exposed by
the\n`@kibana/cloud-security-posture` package as well as all references
where\nit's imported.\n\nSeparating this renaming into its own PR also
lets us tag it with\n`backport:prev-minor` and avoid potential merge
conflicts in the future.\n\n### Depends on\n\n-
https://github.com/elastic/kibana/pull/210938\n\n### Checklist\n\n- [x]
The PR description includes the appropriate Release Notes section,\nand
the correct `release_note:*` label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n###
Identify risks\n\nNo risk
whatsoever.","sha":"aac841353dabe25974dfb661c9f4b591eb8fe42b","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Cloud
Security","backport:prev-minor","v9.1.0"],"title":"Rename
FindingsBaseEsQuery interface in CSP
package","number":212427,"url":"https://github.com/elastic/kibana/pull/212427","mergeCommit":{"message":"Rename
FindingsBaseEsQuery interface in CSP package (elastic#212427)\n\n##
Summary\n\nRename the `FindingsBaseEsQuery` interface exposed by
the\n`@kibana/cloud-security-posture` package as well as all references
where\nit's imported.\n\nSeparating this renaming into its own PR also
lets us tag it with\n`backport:prev-minor` and avoid potential merge
conflicts in the future.\n\n### Depends on\n\n-
https://github.com/elastic/kibana/pull/210938\n\n### Checklist\n\n- [x]
The PR description includes the appropriate Release Notes section,\nand
the correct `release_note:*` label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n###
Identify risks\n\nNo risk
whatsoever.","sha":"aac841353dabe25974dfb661c9f4b591eb8fe42b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212427","number":212427,"mergeCommit":{"message":"Rename
FindingsBaseEsQuery interface in CSP package (elastic#212427)\n\n##
Summary\n\nRename the `FindingsBaseEsQuery` interface exposed by
the\n`@kibana/cloud-security-posture` package as well as all references
where\nit's imported.\n\nSeparating this renaming into its own PR also
lets us tag it with\n`backport:prev-minor` and avoid potential merge
conflicts in the future.\n\n### Depends on\n\n-
https://github.com/elastic/kibana/pull/210938\n\n### Checklist\n\n- [x]
The PR description includes the appropriate Release Notes section,\nand
the correct `release_note:*` label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n###
Identify risks\n\nNo risk
whatsoever.","sha":"aac841353dabe25974dfb661c9f4b591eb8fe42b"}}]}]
BACKPORT-->
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Mar 22, 2025
## Summary

Rename the `FindingsBaseEsQuery` interface exposed by the
`@kibana/cloud-security-posture` package as well as all references where
it's imported.

Separating this renaming into its own PR also lets us tag it with
`backport:prev-minor` and avoid potential merge conflicts in the future.

### Depends on

- elastic#210938

### Checklist

- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

### Identify risks

No risk whatsoever.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related v8.19.0 v9.0.0 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants