Skip to content

Move Findings Flyout to Security Solution or Shared Package Phase 1#212053

Merged
animehart merged 6 commits intoelastic:mainfrom
animehart:move-findings-flyout-to-securitySolution
Feb 26, 2025
Merged

Move Findings Flyout to Security Solution or Shared Package Phase 1#212053
animehart merged 6 commits intoelastic:mainfrom
animehart:move-findings-flyout-to-securitySolution

Conversation

@animehart
Copy link
Copy Markdown
Contributor

Summary

As a part of Expandable Findings flyout, we will need to move some Constants, Types, Functions, Components into Security Solution plugin or Shared package

This PR is phase 1 for Findings (Misconfiguration flyout) which include moving constants and types into shared package or security solution plugin

@animehart
Copy link
Copy Markdown
Contributor Author

/ci

@animehart
Copy link
Copy Markdown
Contributor Author

/ci

@animehart
Copy link
Copy Markdown
Contributor Author

/ci

@animehart
Copy link
Copy Markdown
Contributor Author

/ci

@animehart animehart marked this pull request as ready for review February 24, 2025 08:42
@animehart animehart requested a review from a team as a code owner February 24, 2025 08:42
@animehart
Copy link
Copy Markdown
Contributor Author

/ci

@animehart animehart added the Team:Cloud Security Cloud Security team related label Feb 24, 2025
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

@animehart animehart added backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes v9.0.0 labels Feb 24, 2025
@animehart
Copy link
Copy Markdown
Contributor Author

/ci

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/cloud-security-posture 92 97 +5
@kbn/cloud-security-posture-common 122 135 +13
total +18

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudSecurityPosture 503.8KB 503.7KB -86.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
cloudSecurityPosture 16.8KB 16.9KB +85.0B
Unknown metric groups

API count

id before after diff
@kbn/cloud-security-posture 92 97 +5
@kbn/cloud-security-posture-common 124 137 +13
total +18

History

Copy link
Copy Markdown
Contributor

@JordanSh JordanSh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good, did made me think maybe its time to just move the entire folders into the package instead of keep expanding this split. But this is not a blocker for this PR specifically.

@animehart animehart merged commit 9d1d297 into elastic:main Feb 26, 2025
9 checks passed
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this pull request Feb 27, 2025
…lastic#212053)

## Summary

As a part of Expandable Findings flyout, we will need to move some
Constants, Types, Functions, Components into Security Solution plugin or
Shared package

This PR is phase 1 for Findings (Misconfiguration flyout) which include
moving constants and types into shared package or security solution
plugin

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@animehart animehart removed the v9.0.0 label Mar 7, 2025
@animehart animehart added v9.0.0 and removed v9.0.0 labels Mar 7, 2025
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Mar 22, 2025
…lastic#212053)

## Summary

As a part of Expandable Findings flyout, we will need to move some
Constants, Types, Functions, Components into Security Solution plugin or
Shared package

This PR is phase 1 for Findings (Misconfiguration flyout) which include
moving constants and types into shared package or security solution
plugin

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants