🌊 LLM integration follow-ups#212208
Merged
flash1293 merged 5 commits intoelastic:mainfrom Feb 24, 2025
Merged
Conversation
flash1293
added
release_note:skip
flash1293
commented
Feb 24, 2025
| const currentLicense = useObservable(licensing.license$); | ||
|
|
||
| const couldBeEnabled = | ||
| currentLicense?.hasAtLeast('enterprise') && core.application.capabilities.actions?.save; |
Contributor
Author
There was a problem hiding this comment.
Not sure whether actions.save is the right capability or not - it seems like that's what you need to add an AI connector?
Contributor
There was a problem hiding this comment.
I think so, not sure 100% but looks like it's the write permission we need here to assert the user can create a processor.
…urce-definitions/scripts/fix-location-collection.ts'
tonyghiani
reviewed
Feb 24, 2025
Comment on lines
+350
to
+355
| <EuiButton | ||
| iconType="sparkles" | ||
| href={http!.basePath.prepend( | ||
| `/app/management/insightsAndAlerting/triggersActionsConnectors/connectors` | ||
| )} | ||
| > |
Contributor
There was a problem hiding this comment.
Couple of notes on this:
- Should we show it as a link since it navigates on a different page? The button feels more like "Click and enable".
- Should we also open it in a new tab? If there is some work in progress the user will get prompted to discard changes and leave the page, which might not be desirable.
Contributor
💔 Build Failed
Failed CI Steps |
…sh1293/kibana into flash1293/unit-tests-llm-suggestions
Contributor
Author
|
Good point @tonyghiani , adjusted: |
gsoldevila
approved these changes
Feb 24, 2025
Contributor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/13499281135 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
flash1293
added a commit
that referenced
this pull request
Feb 24, 2025
JoseLuisGJ
pushed a commit
to JoseLuisGJ/kibana
that referenced
this pull request
Feb 27, 2025
This PR takes care of two follow-ups related to the LLM integration: * Shows CTA if AI assistant can be configured, but isn't (see elastic#208777 (comment)) <img width="505" alt="Screenshot 2025-02-24 at 11 24 30" src="https://github.com/user-attachments/assets/da01e782-6b02-4ec4-91ab-b46009b41e29" /> * Adds some tests --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
SoniaSanzV
pushed a commit
to SoniaSanzV/kibana
that referenced
this pull request
Mar 4, 2025
# Backport This will backport the following commits from `main` to `8.x`: - 🌊 LLM integration follow-ups (elastic#212208)](elastic#212208)
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Mar 22, 2025
This PR takes care of two follow-ups related to the LLM integration: * Shows CTA if AI assistant can be configured, but isn't (see elastic#208777 (comment)) <img width="505" alt="Screenshot 2025-02-24 at 11 24 30" src="https://github.com/user-attachments/assets/da01e782-6b02-4ec4-91ab-b46009b41e29" /> * Adds some tests --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR takes care of two follow-ups related to the LLM integration: