🌊 LLM-powered parsing suggestions#208777
Conversation
…a into tonyghiani-93-update-ui-processing
|
@tonyghiani I think I addressed all points raised except for the advertisement of the AI feature if it's not enabled. I'm going to add that in a follow-up PR This is how the screen looks when no suggestions could be found: |
|
You probably want to wait with another round of review until #209985 is merged (I pulled it in here and the diffs are mixed now) |
…t' into flash1293/llm-parsing-suggestions
…293/kibana into flash1293/llm-parsing-suggestions
|
@tonyghiani should be rebased with main - there are two things missing that I will address in a follow-up:
|
tonyghiani
left a comment
There was a problem hiding this comment.
Looks good, there are some client side parts that will probably change with the state management refactor, but I'll handle that once I rebase this work into my WIP changes.
Agree on having some API test for the suggestions, there is a lot of logic going on there and having a test safety guard seems very necessary.
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
History
|
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/13430306734 |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
This PR takes care of two follow-ups related to the LLM integration: * Shows CTA if AI assistant can be configured, but isn't (see #208777 (comment)) <img width="505" alt="Screenshot 2025-02-24 at 11 24 30" src="https://github.com/user-attachments/assets/da01e782-6b02-4ec4-91ab-b46009b41e29" /> * Adds some tests --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This PR takes care of two follow-ups related to the LLM integration: * Shows CTA if AI assistant can be configured, but isn't (see elastic#208777 (comment)) <img width="505" alt="Screenshot 2025-02-24 at 11 24 30" src="https://github.com/user-attachments/assets/da01e782-6b02-4ec4-91ab-b46009b41e29" /> * Adds some tests --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Depends on elastic#209985 Add suggestions for grok processing: <img width="594" alt="Screenshot 2025-02-05 at 10 31 27" src="https://github.com/user-attachments/assets/4b717681-aa7d-4952-a4e0-9013d9b8aaf8" /> The logic for generating suggestions works like this: * Take the current sample * Split it into patterns based on a simple regex-based grouping replacing runs of numbers with a placeholder, runs of regular numbers with a placeholder, etc. * For the top 5 found groups, pass a couple messages to the LLM in parallel to come up with a grok pattern * Check the grok patterns whether they actually match something and don't break * Report the patterns that have a positive match rate For the `Generate patterns` button to show in the UI, make sure a connector is configured and the license level is above basic (trial license is easiest to test with). I did some light refactoring on the processing routes, moving the simulation bits into a separate file - no changes in this area though. --------- Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani01@gmail.com> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com>
This PR takes care of two follow-ups related to the LLM integration: * Shows CTA if AI assistant can be configured, but isn't (see elastic#208777 (comment)) <img width="505" alt="Screenshot 2025-02-24 at 11 24 30" src="https://github.com/user-attachments/assets/da01e782-6b02-4ec4-91ab-b46009b41e29" /> * Adds some tests --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

Depends on #209985
Add suggestions for grok processing:
The logic for generating suggestions works like this:
For the
Generate patternsbutton to show in the UI, make sure a connector is configured and the license level is above basic (trial license is easiest to test with).I did some light refactoring on the processing routes, moving the simulation bits into a separate file - no changes in this area though.