[Cloud Security] Asset Inventory - Universal Flyout Header Boxes, Tags, Fields Components#211366
Merged
JordanSh merged 35 commits intoelastic:mainfrom Mar 5, 2025
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
albertoblaz
reviewed
Mar 3, 2025
..._solution/public/flyout/entity_details/universal_right/components/expandable_badge_group.tsx
Outdated
Show resolved
Hide resolved
..._solution/public/flyout/entity_details/universal_right/components/expandable_badge_group.tsx
Outdated
Show resolved
Hide resolved
..._solution/public/flyout/entity_details/universal_right/components/expandable_badge_group.tsx
Outdated
Show resolved
Hide resolved
.../security/plugins/security_solution/public/flyout/entity_details/universal_right/content.tsx
Show resolved
Hide resolved
janmonschke
approved these changes
Mar 4, 2025
Contributor
janmonschke
left a comment
There was a problem hiding this comment.
Only checked THI changes and they look good to me 👍
albertoblaz
approved these changes
Mar 4, 2025
...y_solution/public/flyout/entity_details/universal_right/components/responsive_data_cards.tsx
Outdated
Show resolved
Hide resolved
opauloh
reviewed
Mar 5, 2025
Contributor
opauloh
left a comment
There was a problem hiding this comment.
great work! left a couple of questions and suggestions
..._solution/public/flyout/entity_details/universal_right/components/expandable_badge_group.tsx
Outdated
Show resolved
Hide resolved
..._solution/public/flyout/entity_details/universal_right/components/expandable_badge_group.tsx
Show resolved
Hide resolved
..._solution/public/flyout/entity_details/universal_right/components/expandable_badge_group.tsx
Outdated
Show resolved
Hide resolved
.../security/plugins/security_solution/public/flyout/entity_details/universal_right/content.tsx
Show resolved
Hide resolved
...plugins/security_solution/public/flyout/entity_details/universal_right/header_data_cards.tsx
Outdated
Show resolved
Hide resolved
tiansivive
requested changes
Mar 5, 2025
..._solution/public/flyout/entity_details/universal_right/components/expandable_badge_group.tsx
Show resolved
Hide resolved
...s/security_solution/public/flyout/entity_details/universal_right/components/fields_table.tsx
Show resolved
Hide resolved
...s/security/plugins/security_solution/public/flyout/entity_details/universal_right/header.tsx
Outdated
Show resolved
Hide resolved
...s/security/plugins/security_solution/public/flyout/entity_details/universal_right/header.tsx
Show resolved
Hide resolved
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
cc @JordanSh |
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Mar 22, 2025
…s, Fields Components (elastic#211366)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #212862
Resolves #211487
Resolves #212863
Summary
Added header and body content for Universal Flyout
All new components are built to be reuseable and potentially to be exported from a package if we will decide we want to reuse them in other flyouts or components
Screen.Recording.2025-03-02.at.14.12.19.mov
Reuseable header data boxes
Screen.Recording.2025-02-23.at.18.34.47.mov
This solution will also scale with more/less items and will address situations of uneven amount of items
Screen.Recording.2025-02-23.at.18.36.45.mov
Expandable Badge Group
Screen.Recording.2025-02-25.at.20.16.13.mov
Screen.Recording.2025-02-26.at.18.22.58.mov
Fields Table