Merged
Conversation
CohenIdo
added
release_note:skip
Contributor
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
Ikuni17
approved these changes
Feb 13, 2025
Contributor
|
@CohenIdo universal entity is in the 8.18, 8.x (8.19) and 9.0.0 branches too, so I think we need the labels |
Contributor
Author
@hop-dev I agree, but I’m not sure it’s crucial since it’s behind a feature flag and nothing is really affected, wdyt? |
Contributor
|
@CohenIdo if we have the opportunity to remove it we should go for it, it might make backporting easier in the future, the more we can keep them in sync the easier our life is! |
Contributor
Author
I can agree with that:) I added the labels. |
CohenIdo
added
v9.0.0
backport:version
CohenIdo
force-pushed
the
deprecate-universal-entity
branch
from
5cd9e0d to
597041c
Compare
CohenIdo
force-pushed
the
deprecate-universal-entity
branch
from
5d306e7 to
5580257
Compare
tiansivive
approved these changes
Feb 17, 2025
Contributor
tiansivive
left a comment
tiansivive
left a comment
There was a problem hiding this comment.
Also all good with me 🚀
CohenIdo
force-pushed
the
deprecate-universal-entity
branch
from
1c2e9dc to
fb38624
Compare
semd
approved these changes
Feb 18, 2025
albertoblaz
approved these changes
Feb 18, 2025
Contributor
albertoblaz
left a comment
albertoblaz
left a comment
There was a problem hiding this comment.
LGTM though I'm not very knowledgable about this part of the implementation
JordanSh
requested changes
Feb 18, 2025
Contributor
JordanSh
left a comment
JordanSh
left a comment
There was a problem hiding this comment.
Please remove FE side changes form this PR.
While removing universal as an entity is one thing, the Universal Flyout is another thing and will still exist in order to display other entities than user, host, and service
Changes required for the Universal Flyout are handled here and should not concern the removal of this entity.
...ity/plugins/security_solution/public/asset_inventory/hooks/use_dynamic_entity_flyout.test.ts
Outdated
Show resolved
Hide resolved
...security/plugins/security_solution/public/asset_inventory/hooks/use_dynamic_entity_flyout.ts
Outdated
Show resolved
Hide resolved
x-pack/solutions/security/plugins/security_solution/public/asset_inventory/pages/all_assets.tsx
Outdated
Show resolved
Hide resolved
src/platform/packages/shared/kbn-securitysolution-ecs/src/entity/index.ts
Outdated
Show resolved
Hide resolved
CohenIdo
force-pushed
the
deprecate-universal-entity
branch
from
f5e9ef9 to
f65b8c4
Compare
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
|
This was referenced Feb 19, 2025
Contributor
|
Starting backport for target branches: 8.18, 8.x, 9.0 https://github.com/elastic/kibana/actions/runs/13412673840 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
This was referenced Feb 19, 2025
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
CohenIdo
added a commit
that referenced
this pull request
Feb 20, 2025
# Backport This will backport the following commits from `main` to `8.x`: - [Deprecate universal entity](#210978) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Ido Cohen","email":"90558359+CohenIdo@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-02-18T14:49:32Z","message":"Deprecate universal entity","sha":"f5c9529e37ea3dddca4db748bfa7e2391303f87e","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Cloud Security","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"Deprecate universal entity","number":210978,"url":"https://github.com/elastic/kibana/pull/210978","mergeCommit":{"message":"Deprecate universal entity","sha":"f5c9529e37ea3dddca4db748bfa7e2391303f87e"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210978","number":210978,"mergeCommit":{"message":"Deprecate universal entity","sha":"f5c9529e37ea3dddca4db748bfa7e2391303f87e"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
CohenIdo
added a commit
that referenced
this pull request
Feb 20, 2025
# Backport This will backport the following commits from `main` to `8.18`: - [Deprecate universal entity](#210978) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Ido Cohen","email":"90558359+CohenIdo@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-02-18T14:49:32Z","message":"Deprecate universal entity","sha":"f5c9529e37ea3dddca4db748bfa7e2391303f87e","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Cloud Security","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"Deprecate universal entity","number":210978,"url":"https://github.com/elastic/kibana/pull/210978","mergeCommit":{"message":"Deprecate universal entity","sha":"f5c9529e37ea3dddca4db748bfa7e2391303f87e"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210978","number":210978,"mergeCommit":{"message":"Deprecate universal entity","sha":"f5c9529e37ea3dddca4db748bfa7e2391303f87e"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
CohenIdo
added a commit
that referenced
this pull request
Feb 20, 2025
# Backport This will backport the following commits from `main` to `9.0`: - [Deprecate universal entity](#210978) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Ido Cohen","email":"90558359+CohenIdo@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-02-18T14:49:32Z","message":"Deprecate universal entity","sha":"f5c9529e37ea3dddca4db748bfa7e2391303f87e","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Cloud Security","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"Deprecate universal entity","number":210978,"url":"https://github.com/elastic/kibana/pull/210978","mergeCommit":{"message":"Deprecate universal entity","sha":"f5c9529e37ea3dddca4db748bfa7e2391303f87e"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210978","number":210978,"mergeCommit":{"message":"Deprecate universal entity","sha":"f5c9529e37ea3dddca4db748bfa7e2391303f87e"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Following our decision to change the architecture from extracting entities from logs and events that contains multiple entities in one entry, and focus on documents that represent only one entity (more on that here and here),
this PR deprecates all the logic behind universal entity: