Skip to content

[visualize] fix unsaved state when adding by-value visualize embeddable to dashboard#211264

Merged
nreese merged 3 commits intoelastic:mainfrom
nreese:issue_210125_followup
Feb 18, 2025
Merged

[visualize] fix unsaved state when adding by-value visualize embeddable to dashboard#211264
nreese merged 3 commits intoelastic:mainfrom
nreese:issue_210125_followup

Conversation

@nreese
Copy link
Copy Markdown
Contributor

@nreese nreese commented Feb 14, 2025 •
edited by kibanamachine
Loading

Follow up to #210125

8.16 and 8.17 backports for #210125 were failing functional test https://github.com/elastic/kibana/blob/8.17/test/functional/apps/dashboard/group1/dashboard_unsaved_listing.ts#L142. The functional test adds a by-value and by-reference legacy visualization to a new dashboard. Upon saving the dashboard, the dashboard still showed unsaved changes.

The reason this test did not fail main and other branches is that #208116 removed the "by-value" part of the test (since its no longer possible to add a by-value legacy visualization from within a dashboard). It is still possible to recreate the issue in main with the following steps

  1. Click "Visualize Library" in left nav
  2. Click "Create visualization" button.
  3. Click "Legacy" tab
  4. Click "Aggregation based"
  5. Click "Area"
  6. Click web logs sample data view
  7. Click "Save"
  8. Set title
  9. Under "Add to dashboard", click "New", click save
  10. save dashboard. Notice how dashboard still has unsaved changes.

8.16 and 8.17 required a new commit to resolve the issue by updating the linkedToLibrary to ignore undefined values.

This PR fixes the issue for the other branches that have already been merged.

@nreese nreese marked this pull request as ready for review February 14, 2025 16:16
@nreese nreese requested a review from a team as a code owner February 14, 2025 16:16
@nreese nreese added release_note:fix Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// release_note:skip Skip the PR/issue when compiling release notes labels Feb 14, 2025
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 14, 2025

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@nreese nreese added the backport:version Backport to applied version labels label Feb 14, 2025
dej611
dej611 approved these changes Feb 18, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested that this change doesn't introduce any regression on the current branch.

@nreese
Copy link
Copy Markdown
Contributor Author

nreese commented Feb 18, 2025

@elasticmachine merge upstream

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 18, 2025

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visualizations 364.5KB 364.6KB +37.0B

@nreese nreese merged commit 6789c94 into elastic:main Feb 18, 2025
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Feb 18, 2025

Starting backport for target branches: 8.18, 8.x, 9.0

https://github.com/elastic/kibana/actions/runs/13395181498

kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Feb 18, 2025
@nreese @kibanamachine @elasticmachine
[visualize] fix unsaved state when adding by-value visualize embeddab…
72bccb5 
…le to dashboard (elastic#211264)

Follow up to elastic#210125

[8.16](elastic#211057) and
[8.17](elastic#211054) backports for
elastic#210125 were failing functional
test
https://github.com/elastic/kibana/blob/8.17/test/functional/apps/dashboard/group1/dashboard_unsaved_listing.ts#L142.
The functional test adds a by-value and by-reference legacy
visualization to a new dashboard. Upon saving the dashboard, the
dashboard still showed unsaved changes.

The reason this test did not fail main and other branches is that
elastic#208116 removed the "by-value"
part of the test (since its no longer possible to add a by-value legacy
visualization from within a dashboard). It is still possible to recreate
the issue in main with the following steps
1) Click "Visualize Library" in left nav
2) Click "Create visualization" button.
3) Click "Legacy" tab
4) Click "Aggregation based"
5) Click "Area"
6) Click web logs sample data view
7) Click "Save"
8) Set title
9) Under "Add to dashboard", click "New", click save
10) save dashboard. Notice how dashboard still has unsaved changes.

8.16 and 8.17 required a [new
commit](elastic@1fd631c)
to resolve the issue by updating the `linkedToLibrary` to ignore
undefined values.

This PR fixes the issue for the other branches that have already been
merged.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
(cherry picked from commit 6789c94)
@kibanamachine kibanamachine mentioned this pull request Feb 18, 2025
Closed
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Feb 18, 2025
@nreese @kibanamachine @elasticmachine
[visualize] fix unsaved state when adding by-value visualize embeddab…
f6d164c 
…le to dashboard (elastic#211264)

Follow up to elastic#210125

[8.16](elastic#211057) and
[8.17](elastic#211054) backports for
elastic#210125 were failing functional
test
https://github.com/elastic/kibana/blob/8.17/test/functional/apps/dashboard/group1/dashboard_unsaved_listing.ts#L142.
The functional test adds a by-value and by-reference legacy
visualization to a new dashboard. Upon saving the dashboard, the
dashboard still showed unsaved changes.

The reason this test did not fail main and other branches is that
elastic#208116 removed the "by-value"
part of the test (since its no longer possible to add a by-value legacy
visualization from within a dashboard). It is still possible to recreate
the issue in main with the following steps
1) Click "Visualize Library" in left nav
2) Click "Create visualization" button.
3) Click "Legacy" tab
4) Click "Aggregation based"
5) Click "Area"
6) Click web logs sample data view
7) Click "Save"
8) Set title
9) Under "Add to dashboard", click "New", click save
10) save dashboard. Notice how dashboard still has unsaved changes.

8.16 and 8.17 required a [new
commit](elastic@1fd631c)
to resolve the issue by updating the `linkedToLibrary` to ignore
undefined values.

This PR fixes the issue for the other branches that have already been
merged.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
(cherry picked from commit 6789c94)
@kibanamachine kibanamachine mentioned this pull request Feb 18, 2025
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Feb 18, 2025
@nreese @kibanamachine @elasticmachine
[visualize] fix unsaved state when adding by-value visualize embeddab…
dc645c9 
…le to dashboard (elastic#211264)

Follow up to elastic#210125

[8.16](elastic#211057) and
[8.17](elastic#211054) backports for
elastic#210125 were failing functional
test
https://github.com/elastic/kibana/blob/8.17/test/functional/apps/dashboard/group1/dashboard_unsaved_listing.ts#L142.
The functional test adds a by-value and by-reference legacy
visualization to a new dashboard. Upon saving the dashboard, the
dashboard still showed unsaved changes.

The reason this test did not fail main and other branches is that
elastic#208116 removed the "by-value"
part of the test (since its no longer possible to add a by-value legacy
visualization from within a dashboard). It is still possible to recreate
the issue in main with the following steps
1) Click "Visualize Library" in left nav
2) Click "Create visualization" button.
3) Click "Legacy" tab
4) Click "Aggregation based"
5) Click "Area"
6) Click web logs sample data view
7) Click "Save"
8) Set title
9) Under "Add to dashboard", click "New", click save
10) save dashboard. Notice how dashboard still has unsaved changes.

8.16 and 8.17 required a [new
commit](elastic@1fd631c)
to resolve the issue by updating the `linkedToLibrary` to ignore
undefined values.

This PR fixes the issue for the other branches that have already been
merged.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
(cherry picked from commit 6789c94)
@kibanamachine kibanamachine mentioned this pull request Feb 18, 2025
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Feb 18, 2025

💚 All backports created successfully

Status Branch Result
✅ 8.18
✅ 8.x
✅ 9.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 18, 2025
@kibanamachine @nreese
[8.x] [visualize] fix unsaved state when adding by-value visualize em…
6231149 
…beddable to dashboard (#211264) (#211611)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[visualize] fix unsaved state when adding by-value visualize
embeddable to dashboard
(#211264)](#211264)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Nathan
Reese","email":"reese.nathan@elastic.co"},"sourceCommit":{"committedDate":"2025-02-18T16:17:42Z","message":"[visualize]
fix unsaved state when adding by-value visualize embeddable to dashboard
(#211264)\n\nFollow up to
https://github.com/elastic/kibana/pull/210125\r\n\r\n[8.16](https://github.com/elastic/kibana/pull/211057)
and\r\n[8.17](#211054) backports
for\r\nhttps://github.com//pull/210125 were failing
functional\r\ntest\r\nhttps://github.com/elastic/kibana/blob/8.17/test/functional/apps/dashboard/group1/dashboard_unsaved_listing.ts#L142.\r\nThe
functional test adds a by-value and by-reference legacy\r\nvisualization
to a new dashboard. Upon saving the dashboard, the\r\ndashboard still
showed unsaved changes.\r\n\r\nThe reason this test did not fail main
and other branches is
that\r\nhttps://github.com//pull/208116 removed the
\"by-value\"\r\npart of the test (since its no longer possible to add a
by-value legacy\r\nvisualization from within a dashboard). It is still
possible to recreate\r\nthe issue in main with the following steps\r\n1)
Click \"Visualize Library\" in left nav\r\n2) Click \"Create
visualization\" button. \r\n3) Click \"Legacy\" tab\r\n4) Click
\"Aggregation based\"\r\n5) Click \"Area\"\r\n6) Click web logs sample
data view\r\n7) Click \"Save\"\r\n8) Set title\r\n9) Under \"Add to
dashboard\", click \"New\", click save\r\n10) save dashboard. Notice how
dashboard still has unsaved changes.\r\n\r\n8.16 and 8.17 required a
[new\r\ncommit](https://github.com/elastic/kibana/pull/211054/commits/1fd631c5a30046b5ab2f63948174ec29bac6fd84)\r\nto
resolve the issue by updating the `linkedToLibrary` to
ignore\r\nundefined values.\r\n\r\nThis PR fixes the issue for the other
branches that have already
been\r\nmerged.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"6789c946885fe0b6a2e57e056831f1ff25156f73","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Visualizations","release_note:skip","v9.0.0","project:embeddableRebuild","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[visualize]
fix unsaved state when adding by-value visualize embeddable to
dashboard","number":211264,"url":"https://github.com/elastic/kibana/pull/211264","mergeCommit":{"message":"[visualize]
fix unsaved state when adding by-value visualize embeddable to dashboard
(#211264)\n\nFollow up to
https://github.com/elastic/kibana/pull/210125\r\n\r\n[8.16](https://github.com/elastic/kibana/pull/211057)
and\r\n[8.17](#211054) backports
for\r\nhttps://github.com//pull/210125 were failing
functional\r\ntest\r\nhttps://github.com/elastic/kibana/blob/8.17/test/functional/apps/dashboard/group1/dashboard_unsaved_listing.ts#L142.\r\nThe
functional test adds a by-value and by-reference legacy\r\nvisualization
to a new dashboard. Upon saving the dashboard, the\r\ndashboard still
showed unsaved changes.\r\n\r\nThe reason this test did not fail main
and other branches is
that\r\nhttps://github.com//pull/208116 removed the
\"by-value\"\r\npart of the test (since its no longer possible to add a
by-value legacy\r\nvisualization from within a dashboard). It is still
possible to recreate\r\nthe issue in main with the following steps\r\n1)
Click \"Visualize Library\" in left nav\r\n2) Click \"Create
visualization\" button. \r\n3) Click \"Legacy\" tab\r\n4) Click
\"Aggregation based\"\r\n5) Click \"Area\"\r\n6) Click web logs sample
data view\r\n7) Click \"Save\"\r\n8) Set title\r\n9) Under \"Add to
dashboard\", click \"New\", click save\r\n10) save dashboard. Notice how
dashboard still has unsaved changes.\r\n\r\n8.16 and 8.17 required a
[new\r\ncommit](https://github.com/elastic/kibana/pull/211054/commits/1fd631c5a30046b5ab2f63948174ec29bac6fd84)\r\nto
resolve the issue by updating the `linkedToLibrary` to
ignore\r\nundefined values.\r\n\r\nThis PR fixes the issue for the other
branches that have already
been\r\nmerged.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"6789c946885fe0b6a2e57e056831f1ff25156f73"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/211264","number":211264,"mergeCommit":{"message":"[visualize]
fix unsaved state when adding by-value visualize embeddable to dashboard
(#211264)\n\nFollow up to
https://github.com/elastic/kibana/pull/210125\r\n\r\n[8.16](https://github.com/elastic/kibana/pull/211057)
and\r\n[8.17](#211054) backports
for\r\nhttps://github.com//pull/210125 were failing
functional\r\ntest\r\nhttps://github.com/elastic/kibana/blob/8.17/test/functional/apps/dashboard/group1/dashboard_unsaved_listing.ts#L142.\r\nThe
functional test adds a by-value and by-reference legacy\r\nvisualization
to a new dashboard. Upon saving the dashboard, the\r\ndashboard still
showed unsaved changes.\r\n\r\nThe reason this test did not fail main
and other branches is
that\r\nhttps://github.com//pull/208116 removed the
\"by-value\"\r\npart of the test (since its no longer possible to add a
by-value legacy\r\nvisualization from within a dashboard). It is still
possible to recreate\r\nthe issue in main with the following steps\r\n1)
Click \"Visualize Library\" in left nav\r\n2) Click \"Create
visualization\" button. \r\n3) Click \"Legacy\" tab\r\n4) Click
\"Aggregation based\"\r\n5) Click \"Area\"\r\n6) Click web logs sample
data view\r\n7) Click \"Save\"\r\n8) Set title\r\n9) Under \"Add to
dashboard\", click \"New\", click save\r\n10) save dashboard. Notice how
dashboard still has unsaved changes.\r\n\r\n8.16 and 8.17 required a
[new\r\ncommit](https://github.com/elastic/kibana/pull/211054/commits/1fd631c5a30046b5ab2f63948174ec29bac6fd84)\r\nto
resolve the issue by updating the `linkedToLibrary` to
ignore\r\nundefined values.\r\n\r\nThis PR fixes the issue for the other
branches that have already
been\r\nmerged.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"6789c946885fe0b6a2e57e056831f1ff25156f73"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Nathan Reese <reese.nathan@elastic.co>
@nreese nreese removed the v8.18.0 label Feb 18, 2025
@nreese nreese mentioned this pull request Feb 18, 2025
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Feb 19, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 19, 2025
kibanamachine added a commit that referenced this pull request Feb 20, 2025
@kibanamachine @nreese @elasticmachine
[9.0] [visualize] fix unsaved state when adding by-value visualize em…
f7f8976 
…beddable to dashboard (#211264) (#211612)

# Backport

This will backport the following commits from `main` to `9.0`:
- [[visualize] fix unsaved state when adding by-value visualize
embeddable to dashboard
(#211264)](#211264)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Nathan
Reese","email":"reese.nathan@elastic.co"},"sourceCommit":{"committedDate":"2025-02-18T16:17:42Z","message":"[visualize]
fix unsaved state when adding by-value visualize embeddable to dashboard
(#211264)\n\nFollow up to
https://github.com/elastic/kibana/pull/210125\r\n\r\n[8.16](https://github.com/elastic/kibana/pull/211057)
and\r\n[8.17](#211054) backports
for\r\nhttps://github.com//pull/210125 were failing
functional\r\ntest\r\nhttps://github.com/elastic/kibana/blob/8.17/test/functional/apps/dashboard/group1/dashboard_unsaved_listing.ts#L142.\r\nThe
functional test adds a by-value and by-reference legacy\r\nvisualization
to a new dashboard. Upon saving the dashboard, the\r\ndashboard still
showed unsaved changes.\r\n\r\nThe reason this test did not fail main
and other branches is
that\r\nhttps://github.com//pull/208116 removed the
\"by-value\"\r\npart of the test (since its no longer possible to add a
by-value legacy\r\nvisualization from within a dashboard). It is still
possible to recreate\r\nthe issue in main with the following steps\r\n1)
Click \"Visualize Library\" in left nav\r\n2) Click \"Create
visualization\" button. \r\n3) Click \"Legacy\" tab\r\n4) Click
\"Aggregation based\"\r\n5) Click \"Area\"\r\n6) Click web logs sample
data view\r\n7) Click \"Save\"\r\n8) Set title\r\n9) Under \"Add to
dashboard\", click \"New\", click save\r\n10) save dashboard. Notice how
dashboard still has unsaved changes.\r\n\r\n8.16 and 8.17 required a
[new\r\ncommit](https://github.com/elastic/kibana/pull/211054/commits/1fd631c5a30046b5ab2f63948174ec29bac6fd84)\r\nto
resolve the issue by updating the `linkedToLibrary` to
ignore\r\nundefined values.\r\n\r\nThis PR fixes the issue for the other
branches that have already
been\r\nmerged.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"6789c946885fe0b6a2e57e056831f1ff25156f73","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Visualizations","release_note:skip","v9.0.0","project:embeddableRebuild","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[visualize]
fix unsaved state when adding by-value visualize embeddable to
dashboard","number":211264,"url":"https://github.com/elastic/kibana/pull/211264","mergeCommit":{"message":"[visualize]
fix unsaved state when adding by-value visualize embeddable to dashboard
(#211264)\n\nFollow up to
https://github.com/elastic/kibana/pull/210125\r\n\r\n[8.16](https://github.com/elastic/kibana/pull/211057)
and\r\n[8.17](#211054) backports
for\r\nhttps://github.com//pull/210125 were failing
functional\r\ntest\r\nhttps://github.com/elastic/kibana/blob/8.17/test/functional/apps/dashboard/group1/dashboard_unsaved_listing.ts#L142.\r\nThe
functional test adds a by-value and by-reference legacy\r\nvisualization
to a new dashboard. Upon saving the dashboard, the\r\ndashboard still
showed unsaved changes.\r\n\r\nThe reason this test did not fail main
and other branches is
that\r\nhttps://github.com//pull/208116 removed the
\"by-value\"\r\npart of the test (since its no longer possible to add a
by-value legacy\r\nvisualization from within a dashboard). It is still
possible to recreate\r\nthe issue in main with the following steps\r\n1)
Click \"Visualize Library\" in left nav\r\n2) Click \"Create
visualization\" button. \r\n3) Click \"Legacy\" tab\r\n4) Click
\"Aggregation based\"\r\n5) Click \"Area\"\r\n6) Click web logs sample
data view\r\n7) Click \"Save\"\r\n8) Set title\r\n9) Under \"Add to
dashboard\", click \"New\", click save\r\n10) save dashboard. Notice how
dashboard still has unsaved changes.\r\n\r\n8.16 and 8.17 required a
[new\r\ncommit](https://github.com/elastic/kibana/pull/211054/commits/1fd631c5a30046b5ab2f63948174ec29bac6fd84)\r\nto
resolve the issue by updating the `linkedToLibrary` to
ignore\r\nundefined values.\r\n\r\nThis PR fixes the issue for the other
branches that have already
been\r\nmerged.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"6789c946885fe0b6a2e57e056831f1ff25156f73"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/211264","number":211264,"mergeCommit":{"message":"[visualize]
fix unsaved state when adding by-value visualize embeddable to dashboard
(#211264)\n\nFollow up to
https://github.com/elastic/kibana/pull/210125\r\n\r\n[8.16](https://github.com/elastic/kibana/pull/211057)
and\r\n[8.17](#211054) backports
for\r\nhttps://github.com//pull/210125 were failing
functional\r\ntest\r\nhttps://github.com/elastic/kibana/blob/8.17/test/functional/apps/dashboard/group1/dashboard_unsaved_listing.ts#L142.\r\nThe
functional test adds a by-value and by-reference legacy\r\nvisualization
to a new dashboard. Upon saving the dashboard, the\r\ndashboard still
showed unsaved changes.\r\n\r\nThe reason this test did not fail main
and other branches is
that\r\nhttps://github.com//pull/208116 removed the
\"by-value\"\r\npart of the test (since its no longer possible to add a
by-value legacy\r\nvisualization from within a dashboard). It is still
possible to recreate\r\nthe issue in main with the following steps\r\n1)
Click \"Visualize Library\" in left nav\r\n2) Click \"Create
visualization\" button. \r\n3) Click \"Legacy\" tab\r\n4) Click
\"Aggregation based\"\r\n5) Click \"Area\"\r\n6) Click web logs sample
data view\r\n7) Click \"Save\"\r\n8) Set title\r\n9) Under \"Add to
dashboard\", click \"New\", click save\r\n10) save dashboard. Notice how
dashboard still has unsaved changes.\r\n\r\n8.16 and 8.17 required a
[new\r\ncommit](https://github.com/elastic/kibana/pull/211054/commits/1fd631c5a30046b5ab2f63948174ec29bac6fd84)\r\nto
resolve the issue by updating the `linkedToLibrary` to
ignore\r\nundefined values.\r\n\r\nThis PR fixes the issue for the other
branches that have already
been\r\nmerged.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"6789c946885fe0b6a2e57e056831f1ff25156f73"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Nathan Reese <reese.nathan@elastic.co>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Feb 20, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@nreese nreese added backport:skip This PR does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Feb 20, 2025
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Mar 22, 2025
@nreese @kibanamachine
@elasticmachine @CAWilson94
[visualize] fix unsaved state when adding by-value visualize embeddab…
dd47416 
…le to dashboard (elastic#211264)

Follow up to elastic#210125

[8.16](elastic#211057) and
[8.17](elastic#211054) backports for
elastic#210125 were failing functional
test
https://github.com/elastic/kibana/blob/8.17/test/functional/apps/dashboard/group1/dashboard_unsaved_listing.ts#L142.
The functional test adds a by-value and by-reference legacy
visualization to a new dashboard. Upon saving the dashboard, the
dashboard still showed unsaved changes.

The reason this test did not fail main and other branches is that
elastic#208116 removed the "by-value"
part of the test (since its no longer possible to add a by-value legacy
visualization from within a dashboard). It is still possible to recreate
the issue in main with the following steps
1) Click "Visualize Library" in left nav
2) Click "Create visualization" button. 
3) Click "Legacy" tab
4) Click "Aggregation based"
5) Click "Area"
6) Click web logs sample data view
7) Click "Save"
8) Set title
9) Under "Add to dashboard", click "New", click save
10) save dashboard. Notice how dashboard still has unsaved changes.

8.16 and 8.17 required a [new
commit](elastic@1fd631c)
to resolve the issue by updating the `linkedToLibrary` to ignore
undefined values.

This PR fixes the issue for the other branches that have already been
merged.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dej611 dej611 dej611 approved these changes

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting backport:version Backport to applied version labels project:embeddableRebuild release_note:fix release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v8.19.0 v9.0.0 v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nreese @elasticmachine @kibanamachine @dej611