Skip to content

[ML] Fixes an issue with failing job validation when fieldCaps object is malformed.#21116

Merged
spalger merged 1 commit intoelastic:masterfrom
walterra:ml-job-validation-aggregatable-field-fix
Jul 24, 2018
Merged

[ML] Fixes an issue with failing job validation when fieldCaps object is malformed.#21116
spalger merged 1 commit intoelastic:masterfrom
walterra:ml-job-validation-aggregatable-field-fix

Conversation

@walterra
Copy link
Contributor

Follow up to #18516 and #20867.

The combination of the two PRs above resulted in a failing test in master. This PR fixes it by more strictly checking if the fieldCaps object is properly structured.

@walterra walterra added bug Fixes for quality problems that affect the customer experience v7.0.0 v6.4.0 :ml Feature:Anomaly Detection ML anomaly detection labels Jul 23, 2018
@walterra walterra self-assigned this Jul 23, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@spalger
Copy link
Contributor

spalger commented Jul 24, 2018

I'm going to merge this since it passed CI and is blocking CI on master currently.

@spalger spalger merged commit 86a9e46 into elastic:master Jul 24, 2018
@spalger
Copy link
Contributor

spalger commented Jul 24, 2018

Looks like the backport for #21087 still hasn't gone in, so I won't be backporting this fix. Would you mind just adding it to #21104 @walterra ?

@walterra
Copy link
Contributor Author

Thanks for merging @spalger, I cherry-picked this one into #21104

@walterra walterra deleted the ml-job-validation-aggregatable-field-fix branch July 24, 2018 07:18
@walterra walterra changed the title [ML] Fixes an issue with failing job validation when fieldCaps objectis malformed. [ML] Fixes an issue with failing job validation when fieldCaps object is malformed. Jul 24, 2018
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Fixes for quality problems that affect the customer experience Feature:Anomaly Detection ML anomaly detection :ml v6.4.0 v7.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants