[ML] Job validation uses fieldCaps to check aggregatable fields to avoid triggering Elasticsearch errors.#21087
Merged
walterra merged 1 commit intoelastic:masterfrom Jul 23, 2018
Conversation
…oid triggering Elasticsearch errors.
Contributor
|
Pinging @elastic/ml-ui |
Contributor
💔 Build Failed |
Contributor
Author
|
retest |
Contributor
💚 Build Succeeded |
walterra
added a commit
to walterra/kibana
that referenced
this pull request
Jul 24, 2018
…oid triggering Elasticsearch errors. (elastic#21087) While the output in the UI was fine, certain job configurations containing non-aggregatable fields could trigger errors on the Elasticsearch side. This PR fixes it by adding an additional query for fieldCaps to check first which fields are actually aggregatable.
walterra
added a commit
that referenced
this pull request
Jul 24, 2018
… to avoid triggering Elasticsearch errors. (#21087) (#21104) While the output in the UI was fine, certain job configurations containing non-aggregatable fields could trigger errors on the Elasticsearch side. This PR fixes it by adding an additional query for fieldCaps to check first which fields are actually aggregatable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18516.
While the output in the UI was fine, certain job configurations containing non-aggregatable fields could trigger errors on the Elasticsearch side.
This PR fixes it by adding an additional query for
fieldCapsto check first which fields are actually aggregatable.Review hint: Most changes in the tests files are a refactor to allow the callrequest mocks to return different mock objects based on the types of request because the tests now need to return different data whether the job validation code uses
searchorfieldCaps.