Skip to content

[8.x] [Security Solution][THI] - replace usages of EUI vis colors (#205218)#210657

Merged
PhilippeOberti merged 1 commit intoelastic:8.xfrom
PhilippeOberti:backport/8.x/pr-205218
Feb 11, 2025
Merged

[8.x] [Security Solution][THI] - replace usages of EUI vis colors (#205218)#210657
PhilippeOberti merged 1 commit intoelastic:8.xfrom
PhilippeOberti:backport/8.x/pr-205218

Conversation

@PhilippeOberti
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…205218)

## Summary

This PR is part of a list of PRs to perform the changes necessary to get
the new Borealis theme working correctly. It focuses on replace the vis
colors for non-visualization usages by correct EUI color tokens.

2 places have been impacted:

- the alerts data table in grouping mode (for host, user and network).
The background colors are removed as they don't really mean anything,
and are not used anywhere else in Kibana. Also the icons have been
updated to match the ones used in other places (like in the flyout)

#### Host
| before | after |
| ------------- | ------------- |
|
![data-table-host-main](https://github.com/user-attachments/assets/eb15300e-6694-4fd0-a77d-09fbb7b8a5dd)
|
![data-table-host-new](https://github.com/user-attachments/assets/405eb0a5-cd17-4a50-b008-d31a0654887e)
|

#### User
| before | after |
| ------------- | ------------- |

|![data-table-user-main](https://github.com/user-attachments/assets/70d05724-610f-4c87-b2ae-cdd0be98d4b0)
|
![data-table-user-new](https://github.com/user-attachments/assets/315467f2-ea84-4c8c-a25f-f5d7d1f060b5)
|

#### Network
| before | after |
| ------------- | ------------- |
|
![data-table-network-main](https://github.com/user-attachments/assets/a26f4aad-ae24-4d67-99ec-3cd677ebf4d6)
|
![data-table-network-new](https://github.com/user-attachments/assets/eba9df1a-fe8a-484c-bfa4-c445659ab8f6)
|

- the dataprovider badge in timeline

#### Dark mode
| before | after |
| ------------- | ------------- |
|
![timeline-main-dark](https://github.com/user-attachments/assets/29f1b5a7-c9f7-46e9-b4a6-76b262102f83)
|
![timeline-new-dark](https://github.com/user-attachments/assets/1628e046-eeae-42d8-81c6-dc530114490d)
|

#### Light mode
| before | after |
| ------------- | ------------- |
|
![timeline-main-light](https://github.com/user-attachments/assets/b89f24e2-67cc-44ce-be0e-41b6a5b89bfb)
|
![timeline-new-light](https://github.com/user-attachments/assets/156a80c1-c31d-4cd6-a72c-544402beb9ab)
|

The changes have been reviewed and approved by @codearos 😄

elastic#201883
(cherry picked from commit cebd201)

# Conflicts:
#	x-pack/solutions/security/plugins/security_solution/public/detections/components/alerts_table/grouping_settings/group_panel_renderers.tsx
@PhilippeOberti PhilippeOberti merged commit 0cb9d60 into elastic:8.x Feb 11, 2025
11 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 18.7MB 18.7MB -1.8KB

@PhilippeOberti PhilippeOberti deleted the backport/8.x/pr-205218 branch February 11, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants