[Security Solution][THI] - replace usages of EUI vis colors#205218
Merged
PhilippeOberti merged 2 commits intoelastic:mainfrom Jan 10, 2025
Merged
[Security Solution][THI] - replace usages of EUI vis colors#205218PhilippeOberti merged 2 commits intoelastic:mainfrom
PhilippeOberti merged 2 commits intoelastic:mainfrom
Conversation
PhilippeOberti
added
release_note:skip
Contributor
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
angorayc
reviewed
Dec 31, 2024
Contributor
angorayc
left a comment
angorayc
left a comment
There was a problem hiding this comment.
Found that we no longer have background color of the group icons after migration, is it intended?
mgadewoll
reviewed
Jan 6, 2025
...lution/public/detections/components/alerts_table/grouping_settings/group_panel_renderers.tsx
Outdated
Show resolved
Hide resolved
...ins/security_solution/public/timelines/components/timeline/data_providers/provider_badge.tsx
Outdated
Show resolved
Hide resolved
Contributor
Author
@angorayc yeah this is intentional. The background colors behind those icons made no sense to me. I'm not sure why they were added in the first place. Why would we have colors behind I just reached out to @codearos on Slack to make sure he is ok with this change. I will update the PR description to add this information once confirmed it's validated! |
angorayc
approved these changes
Jan 10, 2025
PhilippeOberti
force-pushed
the
eui-color-vis
branch
from
9a69c3d to
c6c3afc
Compare
Contributor
Author
no background color changes approved by @codearos! |
mgadewoll
approved these changes
Jan 10, 2025
Contributor
mgadewoll
left a comment
mgadewoll
left a comment
There was a problem hiding this comment.
✅ Changes LGTM from EUI side.
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
christineweng
approved these changes
Jan 10, 2025
viduni94
pushed a commit
to viduni94/kibana
that referenced
this pull request
Jan 23, 2025
…205218) ## Summary This PR is part of a list of PRs to perform the changes necessary to get the new Borealis theme working correctly. It focuses on replace the vis colors for non-visualization usages by correct EUI color tokens. 2 places have been impacted: - the alerts data table in grouping mode (for host, user and network). The background colors are removed as they don't really mean anything, and are not used anywhere else in Kibana. Also the icons have been updated to match the ones used in other places (like in the flyout) #### Host | before | after | | ------------- | ------------- | |  |  | #### User | before | after | | ------------- | ------------- | | |  | #### Network | before | after | | ------------- | ------------- | |  |  | - the dataprovider badge in timeline #### Dark mode | before | after | | ------------- | ------------- | |  |  | #### Light mode | before | after | | ------------- | ------------- | |  |  | The changes have been reviewed and approved by @codearos 😄 elastic#201883
PhilippeOberti
added a commit
to PhilippeOberti/kibana
that referenced
this pull request
Feb 11, 2025
…205218) ## Summary This PR is part of a list of PRs to perform the changes necessary to get the new Borealis theme working correctly. It focuses on replace the vis colors for non-visualization usages by correct EUI color tokens. 2 places have been impacted: - the alerts data table in grouping mode (for host, user and network). The background colors are removed as they don't really mean anything, and are not used anywhere else in Kibana. Also the icons have been updated to match the ones used in other places (like in the flyout) #### Host | before | after | | ------------- | ------------- | |  |  | #### User | before | after | | ------------- | ------------- | | |  | #### Network | before | after | | ------------- | ------------- | |  |  | - the dataprovider badge in timeline #### Dark mode | before | after | | ------------- | ------------- | |  |  | #### Light mode | before | after | | ------------- | ------------- | |  |  | The changes have been reviewed and approved by @codearos 😄 elastic#201883 (cherry picked from commit cebd201) # Conflicts: # x-pack/solutions/security/plugins/security_solution/public/detections/components/alerts_table/grouping_settings/group_panel_renderers.tsx
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
PhilippeOberti
added a commit
that referenced
this pull request
Feb 11, 2025
…05218) (#210657) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution][THI] - replace usages of EUI vis colors (#205218)](#205218) <!--- Backport version: 9.6.4 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Philippe Oberti","email":"philippe.oberti@elastic.co"},"sourceCommit":{"committedDate":"2025-01-10T22:30:49Z","message":"[Security Solution][THI] - replace usages of EUI vis colors (#205218)\n\n## Summary\r\n\r\nThis PR is part of a list of PRs to perform the changes necessary to get\r\nthe new Borealis theme working correctly. It focuses on replace the vis\r\ncolors for non-visualization usages by correct EUI color tokens.\r\n\r\n2 places have been impacted:\r\n\r\n- the alerts data table in grouping mode (for host, user and network).\r\nThe background colors are removed as they don't really mean anything,\r\nand are not used anywhere else in Kibana. Also the icons have been\r\nupdated to match the ones used in other places (like in the flyout)\r\n\r\n#### Host\r\n| before | after |\r\n| ------------- | ------------- |\r\n|\r\n\r\n|\r\n\r\n|\r\n\r\n#### User\r\n| before | after |\r\n| ------------- | ------------- |\r\n\r\n|\r\n|\r\n\r\n|\r\n\r\n#### Network\r\n| before | after |\r\n| ------------- | ------------- |\r\n|\r\n\r\n|\r\n\r\n|\r\n\r\n- the dataprovider badge in timeline\r\n\r\n#### Dark mode\r\n| before | after |\r\n| ------------- | ------------- |\r\n|\r\n\r\n|\r\n\r\n|\r\n\r\n#### Light mode\r\n| before | after |\r\n| ------------- | ------------- |\r\n|\r\n\r\n|\r\n\r\n|\r\n\r\nThe changes have been reviewed and approved by @codearos 😄 \r\n\r\nhttps://github.com//issues/201883","sha":"cebd201981b54e62b9f50561d13617ac261cad67","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:skip","v9.0.0","Team:Threat Hunting:Investigations","EUI Visual Refresh"],"title":"[Security Solution][THI] - replace usages of EUI vis colors","number":205218,"url":"https://github.com/elastic/kibana/pull/205218","mergeCommit":{"message":"[Security Solution][THI] - replace usages of EUI vis colors (#205218)\n\n## Summary\r\n\r\nThis PR is part of a list of PRs to perform the changes necessary to get\r\nthe new Borealis theme working correctly. It focuses on replace the vis\r\ncolors for non-visualization usages by correct EUI color tokens.\r\n\r\n2 places have been impacted:\r\n\r\n- the alerts data table in grouping mode (for host, user and network).\r\nThe background colors are removed as they don't really mean anything,\r\nand are not used anywhere else in Kibana. Also the icons have been\r\nupdated to match the ones used in other places (like in the flyout)\r\n\r\n#### Host\r\n| before | after |\r\n| ------------- | ------------- |\r\n|\r\n\r\n|\r\n\r\n|\r\n\r\n#### User\r\n| before | after |\r\n| ------------- | ------------- |\r\n\r\n|\r\n|\r\n\r\n|\r\n\r\n#### Network\r\n| before | after |\r\n| ------------- | ------------- |\r\n|\r\n\r\n|\r\n\r\n|\r\n\r\n- the dataprovider badge in timeline\r\n\r\n#### Dark mode\r\n| before | after |\r\n| ------------- | ------------- |\r\n|\r\n\r\n|\r\n\r\n|\r\n\r\n#### Light mode\r\n| before | after |\r\n| ------------- | ------------- |\r\n|\r\n\r\n|\r\n\r\n|\r\n\r\nThe changes have been reviewed and approved by @codearos 😄 \r\n\r\nhttps://github.com//issues/201883","sha":"cebd201981b54e62b9f50561d13617ac261cad67"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205218","number":205218,"mergeCommit":{"message":"[Security Solution][THI] - replace usages of EUI vis colors (#205218)\n\n## Summary\r\n\r\nThis PR is part of a list of PRs to perform the changes necessary to get\r\nthe new Borealis theme working correctly. It focuses on replace the vis\r\ncolors for non-visualization usages by correct EUI color tokens.\r\n\r\n2 places have been impacted:\r\n\r\n- the alerts data table in grouping mode (for host, user and network).\r\nThe background colors are removed as they don't really mean anything,\r\nand are not used anywhere else in Kibana. Also the icons have been\r\nupdated to match the ones used in other places (like in the flyout)\r\n\r\n#### Host\r\n| before | after |\r\n| ------------- | ------------- |\r\n|\r\n\r\n|\r\n\r\n|\r\n\r\n#### User\r\n| before | after |\r\n| ------------- | ------------- |\r\n\r\n|\r\n|\r\n\r\n|\r\n\r\n#### Network\r\n| before | after |\r\n| ------------- | ------------- |\r\n|\r\n\r\n|\r\n\r\n|\r\n\r\n- the dataprovider badge in timeline\r\n\r\n#### Dark mode\r\n| before | after |\r\n| ------------- | ------------- |\r\n|\r\n\r\n|\r\n\r\n|\r\n\r\n#### Light mode\r\n| before | after |\r\n| ------------- | ------------- |\r\n|\r\n\r\n|\r\n\r\n|\r\n\r\nThe changes have been reviewed and approved by @codearos 😄 \r\n\r\nhttps://github.com//issues/201883","sha":"cebd201981b54e62b9f50561d13617ac261cad67"}}]}] BACKPORT-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is part of a list of PRs to perform the changes necessary to get the new Borealis theme working correctly. It focuses on replace the vis colors for non-visualization usages by correct EUI color tokens.
2 places have been impacted:
Host
User
Network
Dark mode
Light mode
The changes have been reviewed and approved by @codearos 😄
#201883