[9.0] [dashboard] remove legacy section from 'Add panel' flyout (#208116)

src/platform/plugins/shared/dashboard/public/dashboard_app/top_nav/add_panel_button/get_menu_item_groups.ts

@@ -11,7 +11,6 @@ import { VisGroups } from '@kbn/visualizations-plugin/public';
 import { ADD_PANEL_TRIGGER } from '@kbn/ui-actions-plugin/public';
 import {
   ADD_PANEL_ANNOTATION_GROUP,
-  ADD_PANEL_LEGACY_GROUP,
   ADD_PANEL_OTHER_GROUP,
   ADD_PANEL_VISUALIZATION_GROUP,
 } from '@kbn/embeddable-plugin/public';
@@ -23,11 +22,9 @@ import { uiActionsService, visualizationsService } from '../../../services/kiban
 import { navigateToVisEditor } from './navigate_to_vis_editor';
 import type { MenuItem, MenuItemGroup } from './types';
 
-const VIS_GROUP_TO_ADD_PANEL_GROUP: Record<VisGroups, undefined | PresentableGroup> = {
-  [VisGroups.AGGBASED]: undefined,
+const VIS_GROUP_TO_ADD_PANEL_GROUP: Record<string, PresentableGroup> = {
   [VisGroups.PROMOTED]: ADD_PANEL_VISUALIZATION_GROUP,
   [VisGroups.TOOLS]: ADD_PANEL_ANNOTATION_GROUP,
-  [VisGroups.LEGACY]: ADD_PANEL_LEGACY_GROUP,
 };
 
 export async function getMenuItemGroups(

src/platform/plugins/shared/embeddable/public/index.ts

@@ -56,6 +56,5 @@ export function plugin(initializerContext: PluginInitializerContext) {
 export {
   ADD_PANEL_ANNOTATION_GROUP,
   ADD_PANEL_OTHER_GROUP,
-  ADD_PANEL_LEGACY_GROUP,
   ADD_PANEL_VISUALIZATION_GROUP,
 } from './ui_actions/add_panel_groups';

src/platform/plugins/shared/embeddable/public/ui_actions/add_panel_groups.ts

@@ -39,12 +39,3 @@ export const ADD_PANEL_OTHER_GROUP = {
   getIconType: () => 'empty',
   order: -1, // Given an item that doesn't specify a group is assigned zero, this forces other to come after all intentionally grouped section
 };
-
-export const ADD_PANEL_LEGACY_GROUP = {
-  id: 'legacy',
-  getDisplayName: () =>
-    i18n.translate('embeddableApi.common.constants.grouping.legacy', {
-      defaultMessage: 'Legacy',
-    }),
-  order: -2, // Given an item that doesn't specify a group is assigned zero, this forces it to the bottom of the list
-};

src/platform/plugins/shared/visualizations/public/actions/constants.ts

@@ -7,5 +7,4 @@
  * License v3.0 only", or the "Server Side Public License, v 1".
  */
 
-export const ADD_AGG_VIS_ACTION_ID = 'ADD_AGG_VIS';
 export const ACTION_EDIT_IN_LENS = 'ACTION_EDIT_IN_LENS';

src/platform/plugins/shared/visualizations/public/actions/register_actions.ts

@@ -9,8 +9,8 @@
 
 import { DataPublicPluginStart } from '@kbn/data-plugin/public';
 import { CONTEXT_MENU_TRIGGER } from '@kbn/embeddable-plugin/public';
-import { ADD_PANEL_TRIGGER, type UiActionsStart } from '@kbn/ui-actions-plugin/public';
-import { ACTION_EDIT_IN_LENS, ADD_AGG_VIS_ACTION_ID } from './constants';
+import type { UiActionsStart } from '@kbn/ui-actions-plugin/public';
+import { ACTION_EDIT_IN_LENS } from './constants';
 import { TypesStart } from '../vis_types/types_service';
 
 export function registerActions(
@@ -22,9 +22,4 @@ export function registerActions(
     const { EditInLensAction } = await import('./edit_in_lens_action');
     return new EditInLensAction(data.query.timefilter.timefilter);
   });
-
-  uiActions.addTriggerActionAsync(ADD_PANEL_TRIGGER, ADD_AGG_VIS_ACTION_ID, async () => {
-    const { AddAggVisualizationPanelAction } = await import('./add_agg_vis_action');
-    return new AddAggVisualizationPanelAction(types);
-  });
 }