Skip to content

[Obs AI Assistant] Fix conversations test in MKI #208649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
viduni94 merged 1 commit into from
Jan 29, 2025
Merged

[Obs AI Assistant] Fix conversations test in MKI #208649

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions ...n/deployment_agnostic/apis/observability/ai_assistant/conversations/conversations.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,6 @@ export default function ApiTest({ getService }: DeploymentAgnosticFtrProviderCon
});

describe('Conversations', function () {
// Fails on MKI: https://github.com/elastic/kibana/issues/206549
this.tags(['failsOnMKI']);

describe('without conversations', () => {
it('returns no conversations when listing', async () => {
const { status, body } = await observabilityAIAssistantAPIClient.editor({
Expand Down Expand Up @@ -127,7 +124,8 @@ export default function ApiTest({ getService }: DeploymentAgnosticFtrProviderCon

it('returns the conversation', () => {
// delete user from response to avoid comparing it as it will be different in MKI
// delete createResponse.body.user;
delete createResponse.body.user;

expect(createResponse.body).to.eql({
'@timestamp': createResponse.body['@timestamp'],
conversation: {
Expand All @@ -140,10 +138,6 @@ export default function ApiTest({ getService }: DeploymentAgnosticFtrProviderCon
messages: conversationCreate.messages,
namespace: 'default',
public: conversationCreate.public,
user: {
id: 'u_gf3TRV5WWjD0PQCcTzkUyRE8By8uUt90gK-rT9ZPhA4_0',
name: 'elastic_editor',
},
});
});

Expand Down Expand Up @@ -186,6 +180,8 @@ export default function ApiTest({ getService }: DeploymentAgnosticFtrProviderCon

expect(response.status).to.be(200);

// delete user from response to avoid comparing it as it will be different in MKI
delete response.body.user;
expect(response.body).to.eql(createResponse.body);
});

Expand All @@ -196,8 +192,11 @@ export default function ApiTest({ getService }: DeploymentAgnosticFtrProviderCon

expect(response.status).to.be(200);

// delete user from response to avoid comparing it as it will be different in MKI
delete response.body.conversations[0].user;
expect(response.body.conversations[0]).to.eql(createResponse.body);
});

// TODO
it.skip('returns a 404 when reading it with another user', () => {});

Expand Down Expand Up @@ -247,6 +246,7 @@ export default function ApiTest({ getService }: DeploymentAgnosticFtrProviderCon
});
});
});

describe('security roles and access privileges', () => {
describe('should deny access for users without the ai_assistant privilege', () => {
let createResponse: Awaited<
Expand Down