Skip to content

[Obs AI Assistant] Fix conversations test in MKI#208649

Merged
viduni94 merged 1 commit intoelastic:mainfrom
viduni94:fix-failing-conversations-test-in-MKI
Jan 29, 2025
Merged

[Obs AI Assistant] Fix conversations test in MKI#208649
viduni94 merged 1 commit intoelastic:mainfrom
viduni94:fix-failing-conversations-test-in-MKI

Conversation

@viduni94
Copy link
Copy Markdown
Contributor

@viduni94 viduni94 commented Jan 28, 2025 •
edited by kibanamachine
Loading

Summary

Problem

With the migration to DA tests in #205194, the user has been re-introduced in the conversations response body. This makes this test fail in MKI because the user is different in MKI compared to other environments.

Solution

Remove the user from the response body.

Here's the MKI test run log:
20250128-mki-test-run.log

Checklist

  • Unit or functional tests were updated or added to match the most common scenarios
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

@viduni94 viduni94 added release_note:fix Team:Obs AI Assistant Observability AI Assistant backport:version Backport to applied version labels v8.18.0 labels Jan 28, 2025
@viduni94 viduni94 self-assigned this Jan 28, 2025
@viduni94 viduni94 requested a review from a team as a code owner January 28, 2025 22:56
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jan 28, 2025

Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant)

@viduni94 viduni94 changed the title [Obs AI Assistant] Fix conversations test in MKI (#206549) [Obs AI Assistant] Fix conversations test in MKI Jan 28, 2025
@viduni94 viduni94 linked an issue Jan 28, 2025 that may be closed by this pull request
[FailsOnMKI] Serverless Observability - Deployment-agnostic API Integration Tests.x-pack/test/api_integration/deployment_agnostic/apis/observability/ai_assistant/conversations/conversations.spec.ts #206549
Closed
@viduni94 viduni94 force-pushed the fix-failing-conversations-test-in-MKI branch from b84b0c2 to a92eeac Compare January 28, 2025 22:59
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jan 29, 2025

💚 Build Succeeded

Metrics [docs]

✅ unchanged

cc @viduni94

@viduni94 viduni94 merged commit 5413e75 into elastic:main Jan 29, 2025
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jan 29, 2025

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/13022713147

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 29, 2025
@viduni94
[Obs AI Assistant] Fix conversations test in MKI (elastic#208649)
0569735 
(cherry picked from commit 5413e75)
@kibanamachine kibanamachine mentioned this pull request Jan 29, 2025
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jan 29, 2025

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 29, 2025
@kibanamachine @viduni94
[8.x] [Obs AI Assistant] Fix conversations test in MKI (#208649) (#20…
3861cc2 
…8664)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Obs AI Assistant] Fix conversations test in MKI
(#208649)](#208649)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Viduni
Wickramarachchi","email":"viduni.wickramarachchi@elastic.co"},"sourceCommit":{"committedDate":"2025-01-29T01:16:05Z","message":"[Obs
AI Assistant] Fix conversations test in MKI
(#208649)","sha":"5413e751914281d29882a07bbf36c9b5b9e0fcad","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:Obs
AI Assistant","backport:version","v8.18.0"],"title":"[Obs AI Assistant]
Fix conversations test in
MKI","number":208649,"url":"https://github.com/elastic/kibana/pull/208649","mergeCommit":{"message":"[Obs
AI Assistant] Fix conversations test in MKI
(#208649)","sha":"5413e751914281d29882a07bbf36c9b5b9e0fcad"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/208649","number":208649,"mergeCommit":{"message":"[Obs
AI Assistant] Fix conversations test in MKI
(#208649)","sha":"5413e751914281d29882a07bbf36c9b5b9e0fcad"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Viduni Wickramarachchi <viduni.wickramarachchi@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neptunian neptunian neptunian approved these changes

Assignees

@viduni94 viduni94

Labels

backport:version Backport to applied version labels release_note:fix Team:Obs AI Assistant Observability AI Assistant v8.18.0 v9.0.0

Projects

None yet

Milestone

No milestone

4 participants

@viduni94 @elasticmachine @kibanamachine @neptunian