Skip to content

[Console] Console definitions script should generate separate prs for main and 8.x#207036

Merged
sabarasaba merged 7 commits intoelastic:mainfrom
sabarasaba:console-improve_generation_script
Jan 28, 2025
Merged

[Console] Console definitions script should generate separate prs for main and 8.x#207036
sabarasaba merged 7 commits intoelastic:mainfrom
sabarasaba:console-improve_generation_script

Conversation

@sabarasaba
Copy link
Copy Markdown
Member

@sabarasaba sabarasaba commented Jan 17, 2025

Fixes #206945

Summary

With #200935 we introduced a script that generates console definitions based on the elasticsearch-specification repo. This PR changes that script so that it generates two PRs: one for the main branch and one for 8.x in order to keep previous versions with their corresponding console definitions.

@sabarasaba sabarasaba added Feature:Console Dev Tools Console Feature Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting v9.0.0 labels Jan 17, 2025
@sabarasaba sabarasaba self-assigned this Jan 17, 2025
@sabarasaba sabarasaba requested a review from a team January 17, 2025 09:29
@sabarasaba sabarasaba marked this pull request as ready for review January 17, 2025 10:06
@sabarasaba sabarasaba requested a review from a team as a code owner January 17, 2025 10:06
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

@ElenaStoeva ElenaStoeva self-requested a review January 17, 2025 15:41
Copy link
Copy Markdown
Contributor

@ElenaStoeva ElenaStoeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving this script @sabarasaba! Changes lgtm. I'm just wondering whether the Es specification repo has an up-to-date 8.x branch (i.e. whether changes intended for 8.x are usually backported) 🤔

@sabarasaba
Copy link
Copy Markdown
Member Author

Thanks for improving this script @sabarasaba! Changes lgtm. I'm just wondering whether the Es specification repo has an up-to-date 8.x branch (i.e. whether changes intended for 8.x are usually backported) 🤔

Thanks for the review @ElenaStoeva! Yeah seems to be kept up to date, I can see almost daily commits going into it so should be alright.

@sabarasaba
Copy link
Copy Markdown
Member Author

@elasticmachine merge upstream

@sabarasaba sabarasaba requested a review from jbudz January 27, 2025 07:04
@sabarasaba
Copy link
Copy Markdown
Member Author

@elasticmachine merge upstream

@sabarasaba sabarasaba added backport:prev-minor and removed backport:skip This PR does not require backporting labels Jan 28, 2025
@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

cc @sabarasaba

@sabarasaba sabarasaba merged commit 9e60b8e into elastic:main Jan 28, 2025
@kibanamachine
Copy link
Copy Markdown
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/13012941040

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 29, 2025
…rs for main and 8.x (#207036) (#208550)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Console] Console definitions script should generate separate prs for
main and 8.x (#207036)](#207036)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Ignacio
Rivas","email":"rivasign@gmail.com"},"sourceCommit":{"committedDate":"2025-01-28T14:43:31Z","message":"[Console]
Console definitions script should generate separate prs for main and 8.x
(#207036)","sha":"9e60b8e4b8b68012d965ca3bdb42d0527c034b06","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Console","Team:Kibana
Management","release_note:skip","v9.0.0","backport:prev-minor"],"title":"[Console]
Console definitions script should generate separate prs for main and
8.x","number":207036,"url":"https://github.com/elastic/kibana/pull/207036","mergeCommit":{"message":"[Console]
Console definitions script should generate separate prs for main and 8.x
(#207036)","sha":"9e60b8e4b8b68012d965ca3bdb42d0527c034b06"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/207036","number":207036,"mergeCommit":{"message":"[Console]
Console definitions script should generate separate prs for main and 8.x
(#207036)","sha":"9e60b8e4b8b68012d965ca3bdb42d0527c034b06"}}]}]
BACKPORT-->

Co-authored-by: Ignacio Rivas <rivasign@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
SoniaSanzV added a commit that referenced this pull request May 29, 2025
## Summary

With #207036 we introduced some
changes in the script so that it generates two PRs: one for the `main`
branch and one for `8.x` in order to keep previous versions with their
corresponding console definitions.

This PR updates the branches so the script generates PRs for `main`,
`9.0`, `8.19` and `8.18`
SoniaSanzV added a commit to SoniaSanzV/kibana that referenced this pull request May 30, 2025
## Summary

With elastic#207036 we introduced some
changes in the script so that it generates two PRs: one for the `main`
branch and one for `8.x` in order to keep previous versions with their
corresponding console definitions.

This PR updates the branches so the script generates PRs for `main`,
`9.0`, `8.19` and `8.18`

(cherry picked from commit abf2c2c)

# Conflicts:
#	.buildkite/pipeline-resource-definitions/kibana-console-definitions-sync.yml
SoniaSanzV added a commit to SoniaSanzV/kibana that referenced this pull request May 30, 2025
## Summary

With elastic#207036 we introduced some
changes in the script so that it generates two PRs: one for the `main`
branch and one for `8.x` in order to keep previous versions with their
corresponding console definitions.

This PR updates the branches so the script generates PRs for `main`,
`9.0`, `8.19` and `8.18`

(cherry picked from commit abf2c2c)

# Conflicts:
#	.buildkite/pipeline-resource-definitions/kibana-console-definitions-sync.yml
SoniaSanzV added a commit to SoniaSanzV/kibana that referenced this pull request May 30, 2025
## Summary

With elastic#207036 we introduced some
changes in the script so that it generates two PRs: one for the `main`
branch and one for `8.x` in order to keep previous versions with their
corresponding console definitions.

This PR updates the branches so the script generates PRs for `main`,
`9.0`, `8.19` and `8.18`

(cherry picked from commit abf2c2c)

# Conflicts:
#	.buildkite/pipeline-resource-definitions/kibana-console-definitions-sync.yml
SoniaSanzV added a commit that referenced this pull request Jun 3, 2025
# Backport

This will backport the following commits from `main` to `9.0`:
- [Update console definitions branches
(#221888)](#221888)

<!--- Backport version: 10.0.0 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Sonia Sanz
Vivas","email":"sonia.sanzvivas@elastic.co"},"sourceCommit":{"committedDate":"2025-05-29T16:35:17Z","message":"Update
console definitions branches (#221888)\n\n## Summary\n\nWith
#207036 we introduced
some\nchanges in the script so that it generates two PRs: one for the
`main`\nbranch and one for `8.x` in order to keep previous versions with
their\ncorresponding console definitions.\n\nThis PR updates the
branches so the script generates PRs for `main`,\n`9.0`, `8.19` and
`8.18`","sha":"abf2c2c789dd3ad4f727d59ec292b32d0e9e84e8","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Console","Team:Kibana
Management","release_note:skip","backport:version","v9.1.0","v8.19.0","v9.0.2","v8.18.3"],"title":"Update
console definitions
branches","number":221888,"url":"https://github.com/elastic/kibana/pull/221888","mergeCommit":{"message":"Update
console definitions branches (#221888)\n\n## Summary\n\nWith
#207036 we introduced
some\nchanges in the script so that it generates two PRs: one for the
`main`\nbranch and one for `8.x` in order to keep previous versions with
their\ncorresponding console definitions.\n\nThis PR updates the
branches so the script generates PRs for `main`,\n`9.0`, `8.19` and
`8.18`","sha":"abf2c2c789dd3ad4f727d59ec292b32d0e9e84e8"}},"sourceBranch":"main","suggestedTargetBranches":["8.19","9.0","8.18"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/221888","number":221888,"mergeCommit":{"message":"Update
console definitions branches (#221888)\n\n## Summary\n\nWith
#207036 we introduced
some\nchanges in the script so that it generates two PRs: one for the
`main`\nbranch and one for `8.x` in order to keep previous versions with
their\ncorresponding console definitions.\n\nThis PR updates the
branches so the script generates PRs for `main`,\n`9.0`, `8.19` and
`8.18`","sha":"abf2c2c789dd3ad4f727d59ec292b32d0e9e84e8"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
SoniaSanzV added a commit that referenced this pull request Jun 3, 2025
# Backport

This will backport the following commits from `main` to `8.19`:
- [Update console definitions branches
(#221888)](#221888)

<!--- Backport version: 10.0.0 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Sonia Sanz
Vivas","email":"sonia.sanzvivas@elastic.co"},"sourceCommit":{"committedDate":"2025-05-29T16:35:17Z","message":"Update
console definitions branches (#221888)\n\n## Summary\n\nWith
#207036 we introduced
some\nchanges in the script so that it generates two PRs: one for the
`main`\nbranch and one for `8.x` in order to keep previous versions with
their\ncorresponding console definitions.\n\nThis PR updates the
branches so the script generates PRs for `main`,\n`9.0`, `8.19` and
`8.18`","sha":"abf2c2c789dd3ad4f727d59ec292b32d0e9e84e8","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Console","Team:Kibana
Management","release_note:skip","backport:version","v9.1.0","v8.19.0","v9.0.2","v8.18.3"],"title":"Update
console definitions
branches","number":221888,"url":"https://github.com/elastic/kibana/pull/221888","mergeCommit":{"message":"Update
console definitions branches (#221888)\n\n## Summary\n\nWith
#207036 we introduced
some\nchanges in the script so that it generates two PRs: one for the
`main`\nbranch and one for `8.x` in order to keep previous versions with
their\ncorresponding console definitions.\n\nThis PR updates the
branches so the script generates PRs for `main`,\n`9.0`, `8.19` and
`8.18`","sha":"abf2c2c789dd3ad4f727d59ec292b32d0e9e84e8"}},"sourceBranch":"main","suggestedTargetBranches":["8.19","9.0","8.18"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/221888","number":221888,"mergeCommit":{"message":"Update
console definitions branches (#221888)\n\n## Summary\n\nWith
#207036 we introduced
some\nchanges in the script so that it generates two PRs: one for the
`main`\nbranch and one for `8.x` in order to keep previous versions with
their\ncorresponding console definitions.\n\nThis PR updates the
branches so the script generates PRs for `main`,\n`9.0`, `8.19` and
`8.18`","sha":"abf2c2c789dd3ad4f727d59ec292b32d0e9e84e8"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
SoniaSanzV added a commit that referenced this pull request Jun 3, 2025
# Backport

This will backport the following commits from `main` to `8.18`:
- [Update console definitions branches
(#221888)](#221888)

<!--- Backport version: 10.0.0 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Sonia Sanz
Vivas","email":"sonia.sanzvivas@elastic.co"},"sourceCommit":{"committedDate":"2025-05-29T16:35:17Z","message":"Update
console definitions branches (#221888)\n\n## Summary\n\nWith
#207036 we introduced
some\nchanges in the script so that it generates two PRs: one for the
`main`\nbranch and one for `8.x` in order to keep previous versions with
their\ncorresponding console definitions.\n\nThis PR updates the
branches so the script generates PRs for `main`,\n`9.0`, `8.19` and
`8.18`","sha":"abf2c2c789dd3ad4f727d59ec292b32d0e9e84e8","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Console","Team:Kibana
Management","release_note:skip","backport:version","v9.1.0","v8.19.0","v9.0.2","v8.18.3"],"title":"Update
console definitions
branches","number":221888,"url":"https://github.com/elastic/kibana/pull/221888","mergeCommit":{"message":"Update
console definitions branches (#221888)\n\n## Summary\n\nWith
#207036 we introduced
some\nchanges in the script so that it generates two PRs: one for the
`main`\nbranch and one for `8.x` in order to keep previous versions with
their\ncorresponding console definitions.\n\nThis PR updates the
branches so the script generates PRs for `main`,\n`9.0`, `8.19` and
`8.18`","sha":"abf2c2c789dd3ad4f727d59ec292b32d0e9e84e8"}},"sourceBranch":"main","suggestedTargetBranches":["8.19","9.0","8.18"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/221888","number":221888,"mergeCommit":{"message":"Update
console definitions branches (#221888)\n\n## Summary\n\nWith
#207036 we introduced
some\nchanges in the script so that it generates two PRs: one for the
`main`\nbranch and one for `8.x` in order to keep previous versions with
their\ncorresponding console definitions.\n\nThis PR updates the
branches so the script generates PRs for `main`,\n`9.0`, `8.19` and
`8.18`","sha":"abf2c2c789dd3ad4f727d59ec292b32d0e9e84e8"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
zacharyparikh pushed a commit to zacharyparikh/kibana that referenced this pull request Jun 4, 2025
## Summary

With elastic#207036 we introduced some
changes in the script so that it generates two PRs: one for the `main`
branch and one for `8.x` in order to keep previous versions with their
corresponding console definitions.

This PR updates the branches so the script generates PRs for `main`,
`9.0`, `8.19` and `8.18`
nickpeihl pushed a commit to nickpeihl/kibana that referenced this pull request Jun 12, 2025
## Summary

With elastic#207036 we introduced some
changes in the script so that it generates two PRs: one for the `main`
branch and one for `8.x` in order to keep previous versions with their
corresponding console definitions.

This PR updates the branches so the script generates PRs for `main`,
`9.0`, `8.19` and `8.18`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:Console Dev Tools Console Feature release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// v8.18.0 v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Console] Investigate if console definitions need to be backported

5 participants