Skip to content

[APM] fix logger on telemetry#204388

Merged
rmyz merged 2 commits intoelastic:mainfrom
rmyz:199249-apm-fix-logger-call
Dec 16, 2024
Merged

[APM] fix logger on telemetry#204388
rmyz merged 2 commits intoelastic:mainfrom
rmyz:199249-apm-fix-logger-call

Conversation

@rmyz
Copy link
Copy Markdown
Contributor

@rmyz rmyz commented Dec 16, 2024

Summary

Closes #199249

This PR fixes the logger calls on APM telemetry

@rmyz rmyz requested a review from a team December 16, 2024 13:11
@botelastic botelastic Bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation. labels Dec 16, 2024
@rmyz rmyz self-assigned this Dec 16, 2024
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@github-actions
Copy link
Copy Markdown
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Copy Markdown
Contributor

@iblancof iblancof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change LGTM, I did not test locally.

@botelastic botelastic Bot added the ci:project-deploy-observability Create an Observability project label Dec 16, 2024
@github-actions
Copy link
Copy Markdown
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Copy Markdown
Member

@jennypavlova jennypavlova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Thank you for fixing that!

@elasticmachine
Copy link
Copy Markdown
Contributor

⏳ Build in-progress

  • Buildkite Build
  • Commit: 07f80f8
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-204388-07f80f84fdca

cc @rmyz

@rmyz rmyz enabled auto-merge (squash) December 16, 2024 14:58
@rmyz rmyz merged commit 5077e6d into elastic:main Dec 16, 2024
@kibanamachine
Copy link
Copy Markdown
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12355750144

@rmyz rmyz deleted the 199249-apm-fix-logger-call branch December 16, 2024 15:23
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 16, 2024
## Summary

Closes elastic#199249

This PR fixes the logger calls on APM telemetry

(cherry picked from commit 5077e6d)
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 16, 2024
# Backport

This will backport the following commits from `main` to `8.x`:
- [[APM] fix logger on telemetry
(#204388)](#204388)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Sergi
Romeu","email":"sergi.romeu@elastic.co"},"sourceCommit":{"committedDate":"2024-12-16T15:22:07Z","message":"[APM]
fix logger on telemetry (#204388)\n\n## Summary\n\nCloses
https://github.com/elastic/kibana/issues/199249\n\nThis PR fixes the
logger calls on APM
telemetry","sha":"5077e6d63de5c66c77676efd2d7d2230a1df8f93","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services"],"title":"[APM]
fix logger on
telemetry","number":204388,"url":"https://github.com/elastic/kibana/pull/204388","mergeCommit":{"message":"[APM]
fix logger on telemetry (#204388)\n\n## Summary\n\nCloses
https://github.com/elastic/kibana/issues/199249\n\nThis PR fixes the
logger calls on APM
telemetry","sha":"5077e6d63de5c66c77676efd2d7d2230a1df8f93"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204388","number":204388,"mergeCommit":{"message":"[APM]
fix logger on telemetry (#204388)\n\n## Summary\n\nCloses
https://github.com/elastic/kibana/issues/199249\n\nThis PR fixes the
logger calls on APM
telemetry","sha":"5077e6d63de5c66c77676efd2d7d2230a1df8f93"}}]}]
BACKPORT-->

Co-authored-by: Sergi Romeu <sergi.romeu@elastic.co>
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this pull request Dec 19, 2024
## Summary

Closes elastic#199249

This PR fixes the logger calls on APM telemetry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[APM] telemetry logger calls logger incorrectly, masking actual errors

5 participants