Skip to content

Sustainable Kibana Architecture: Relocate script v4#204383

Merged
gsoldevila merged 2 commits intoelastic:mainfrom
gsoldevila:kbn-team-1066-relocate-script-v4
Dec 16, 2024
Merged

Sustainable Kibana Architecture: Relocate script v4#204383
gsoldevila merged 2 commits intoelastic:mainfrom
gsoldevila:kbn-team-1066-relocate-script-v4

Conversation

@gsoldevila
Copy link
Copy Markdown
Member

@gsoldevila gsoldevila commented Dec 16, 2024 •
edited by kibanamachine
Loading

Summary

  • Auto-detect "upstream" and "origin" remotes (instead of assuming their names).
  • Allow relocating modules that are already in a "sustainable" folder.
    • Filter out modules that are in the correct locations.
  • Update the list of modules to relocate to show only those modules that are actually moved.

@gsoldevila gsoldevila added Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor labels Dec 16, 2024
@gsoldevila gsoldevila requested a review from a team as a code owner December 16, 2024 12:48
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 16, 2024

Pinging @elastic/kibana-core (Team:Core)

afharo
afharo approved these changes Dec 16, 2024
View reviewed changes
Comment thread packages/kbn-relocate/utils/git.ts
Comment on lines +20 to +30
export const findGithubLogin = async () => {
const res = await safeExec('gh auth status');
// e.g. ✓ Logged in to github.com account gsoldevila (/Users/gsoldevila/.config/gh/hosts.yml)
const loginLine = res.stdout
.split('\n')
.find((line) => line.includes('Logged in'))
?.split(/\t| /)
.filter(Boolean);

return loginLine?.[loginLine?.findIndex((fragment) => fragment === 'account') + 1];
};
Copy link
Copy Markdown
Member

@afharo afharo Dec 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is subject to break in future versions of gh. But OK for now.

Comment thread packages/kbn-relocate/utils/relocate.ts Outdated
@gsoldevila @afharo
Update packages/kbn-relocate/utils/relocate.ts
d41b8a8 
Co-authored-by: Alejandro Fernández Haro <afharo@gmail.com>
@gsoldevila gsoldevila enabled auto-merge (squash) December 16, 2024 13:53
@gsoldevila gsoldevila merged commit d18a44c into elastic:main Dec 16, 2024
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Dec 16, 2024

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12356189897

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Dec 16, 2024

💔 All backports failed

Status Branch Result
❌ 8.x Backport failed because of merge conflicts

You might need to backport the following PRs to 8.x:
- [ResponseOps][Rules] Add loading state to rule params data views selector (#203654)
- [SecuritySolution][Endpoint] Unskip ftr tests (#204405)
- [Rule Migration] (#204243)
- [APM] fix logger on telemetry (#204388)
- [MAPS] Updating file upload privileges for maps test user (#203992)
- [ResponseOps][Connectors]Migrate remaining routes. (#204042)
- [ai][assistant] Create AI Assistant Icon, Avatar, Beacon (#203879)
- Sustainable Kibana Architecture: Move modules owned by @elastic/security-threat-hunting-explore (#202852)

Manual backport

To create the backport manually run:

node scripts/backport --pr 204383

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 17, 2024
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Dec 17, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 204383 locally

@rudolf rudolf added the plugin groups Relocate all plugins and packages under their respective platform/solution groups label Dec 18, 2024
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Dec 19, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 204383 locally

JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this pull request Dec 19, 2024
@gsoldevila @afharo @JoseLuisGJ
Sustainable Kibana Architecture: Relocate script v4 (elastic#204383)
c858f49 
## Summary

* Auto-detect "upstream" and "origin" remotes (instead of assuming their
names).
* Allow relocating modules that are already in a "sustainable" folder.
  * Filter out modules that are in the correct locations.
* Update the list of _modules to relocate_ to show only those modules
that are actually moved.

---------

Co-authored-by: Alejandro Fernández Haro <afharo@gmail.com>
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Dec 20, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 204383 locally

1 similar comment
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Dec 23, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 204383 locally

@gsoldevila gsoldevila removed backport missing Added to PRs automatically when the are determined to be missing a backport. backport:prev-minor labels Dec 23, 2024
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rudolf rudolf rudolf approved these changes

@afharo afharo afharo approved these changes

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting plugin groups Relocate all plugins and packages under their respective platform/solution groups release_note:skip Skip the PR/issue when compiling release notes Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// v9.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gsoldevila @elasticmachine @kibanamachine @rudolf @afharo