Skip to content

[ResponseOps][UI]EUI Visual Refresh integration and QA - tasks 1 & 2 #203068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
georgianaonoleata1904 merged 5 commits into from
Dec 16, 2024
Merged

[ResponseOps][UI]EUI Visual Refresh integration and QA - tasks 1 & 2 #203068

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c13404f
changed successText to textSuccess - task 2
georgianaonoleata1904 Dec 5, 2024
4e0cd8e
Merge branch 'main' into eui-visual-refresh-task1-success
georgianaonoleata1904 Dec 13, 2024
f9607df
Merge branch 'main' into eui-visual-refresh-task1-success
elasticmachine Dec 16, 2024
99ecac5
replaced success with primary for buttons
georgianaonoleata1904 Dec 16, 2024
b341228
Merge branch 'main' into eui-visual-refresh-task1-success
georgianaonoleata1904 Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/response-ops/rule_form/src/rule_page/rule_page_name_input.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ export const RulePageNameInput = () => {
</EuiFlexItem>
<EuiFlexItem grow={false}>
<EuiButtonIcon
color="success"
color="primary"
iconType="check"
size="m"
onClick={onCancelEdit}
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/cases/public/components/case_view/components/edit_category.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ export const EditCategory = React.memo(({ isLoading, onSubmit, category }: EditC
<EuiFlexGroup alignItems="center" responsive={false}>
<EuiFlexItem grow={false}>
<EuiButton
color="success"
color="primary"
data-test-subj="edit-category-submit"
fill
iconType="save"
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/cases/public/components/case_view/components/edit_tags.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ export const EditTags = React.memo(({ isLoading, onSubmit, tags }: EditTagsProps
<EuiFlexGroup alignItems="center" responsive={false}>
<EuiFlexItem grow={false}>
<EuiButton
color="success"
color="primary"
data-test-subj="edit-tags-submit"
fill
iconType="save"
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/cases/public/components/custom_fields/number/edit.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ const EditComponent: CustomFieldType<CaseCustomFieldNumber>['Edit'] = ({
<EuiFlexGroup alignItems="center" responsive={false}>
<EuiFlexItem grow={false}>
<EuiButton
color="success"
color="primary"
data-test-subj={`case-number-custom-field-submit-button-${customFieldConfiguration.key}`}
fill
iconType="save"
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/cases/public/components/custom_fields/text/edit.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ const EditComponent: CustomFieldType<CaseCustomFieldText>['Edit'] = ({
<EuiFlexGroup alignItems="center" responsive={false}>
<EuiFlexItem grow={false}>
<EuiButton
color="success"
color="primary"
data-test-subj={`case-text-custom-field-submit-button-${customFieldConfiguration.key}`}
fill
iconType="save"
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/cases/public/components/edit_connector/connectors_form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ const ConnectorsFormComponent: React.FC<Props> = ({
<EuiFlexItem grow={false}>
<EuiButton
disabled={!enableSave}
color="success"
color="primary"
data-test-subj="edit-connectors-submit"
fill
iconType="save"
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/cases/public/components/markdown_editor/editable_markdown_footer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ const EditableMarkdownFooterComponent: React.FC<EditableMarkdownFooterProps> = (
<EuiFlexItem grow={false}>
<EuiButton
data-test-subj="editable-save-markdown"
color="success"
color="primary"
fill
iconType="save"
onClick={handleSaveAction}
Expand Down
2 changes: 1 addition & 1 deletion ...gers_actions_ui/public/application/sections/action_connector_form/connector_add_modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,7 @@ const ConnectorAddModal = ({
{canSave ? (
<EuiButton
fill
color="success"
color="primary"
data-test-subj="saveActionButtonModal"
type="submit"
iconType="check"
Expand Down
4 changes: 2 additions & 2 deletions ...ns_ui/public/application/sections/action_connector_form/create_connector_flyout/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ const CreateConnectorFlyoutComponent: React.FC<CreateConnectorFlyoutProps> = ({
{onTestConnector && (
<EuiFlexItem grow={false}>
<EuiButton
color="success"
color="primary"
data-test-subj="create-connector-flyout-save-test-btn"
type="submit"
isLoading={isSaving}
Expand All @@ -259,7 +259,7 @@ const CreateConnectorFlyoutComponent: React.FC<CreateConnectorFlyoutProps> = ({
<EuiFlexItem grow={false}>
<EuiButton
fill
color="success"
color="primary"
data-test-subj="create-connector-flyout-save-btn"
type="submit"
isLoading={isSaving}
Expand Down
2 changes: 1 addition & 1 deletion ...ions_ui/public/application/sections/action_connector_form/edit_connector_flyout/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ const EditConnectorFlyoutComponent: React.FC<EditConnectorFlyoutProps> = ({
<EuiButton
fill
iconType={isSaved ? 'check' : undefined}
color="success"
color="primary"
data-test-subj="edit-connector-flyout-save-btn"
isLoading={isSaving}
onClick={onClickSave}
Expand Down
2 changes: 1 addition & 1 deletion ...s_actions_ui/public/application/sections/alert_summary_widget/components/alert_counts.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export const AlertCounts = ({ activeAlertCount, recoveredAlertCount, handleClick
<AlertItem
label={ACTIVE_NOW_LABEL}
count={activeAlertCount}
color={activeAlertCount > 0 ? euiTheme.colors.dangerText : euiTheme.colors.successText}
color={activeAlertCount > 0 ? euiTheme.colors.dangerText : euiTheme.colors.textSuccess}
Comment thread
adcoelho marked this conversation as resolved.
alertType={ALERT_STATUS_ACTIVE}
handleClick={handleClick}
showWarningIcon={true}
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/triggers_actions_ui/public/application/sections/rule_form/rule_add_footer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ export const RuleAddFooter = ({
<EuiFlexItem grow={false}>
<EuiButton
fill
color="success"
color="primary"
data-test-subj="saveRuleButton"
type="submit"
iconType="check"
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/triggers_actions_ui/public/application/sections/rule_form/rule_edit.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,7 @@ export const RuleEdit = <
<EuiFlexItem grow={false}>
<EuiButton
fill
color="success"
color="primary"
data-test-subj="saveEditedRuleButton"
type="submit"
iconType="check"
Expand Down