Skip to content

[ResponseOps][UI]EUI Visual Refresh integration and QA - tasks 1 & 2#203068

Merged
georgianaonoleata1904 merged 5 commits intoelastic:ro_eui_theme_borealisfrom
georgianaonoleata1904:eui-visual-refresh-task1-success
Dec 16, 2024
Merged

[ResponseOps][UI]EUI Visual Refresh integration and QA - tasks 1 & 2#203068
georgianaonoleata1904 merged 5 commits intoelastic:ro_eui_theme_borealisfrom
georgianaonoleata1904:eui-visual-refresh-task1-success

Conversation

@georgianaonoleata1904
Copy link
Contributor

@georgianaonoleata1904 georgianaonoleata1904 commented Dec 5, 2024

Closes #202548
Closes #202549

Summary

  • no changes were needed to the use of "success" color as it was used for semantic purpose
  • replaced "textSuccess" to "successText"

@georgianaonoleata1904 georgianaonoleata1904 changed the title changed successText to textSuccess - task 2 [ResponseOps]EUI Visual Refresh integration and QA - tast 1 & 2 Dec 5, 2024
@georgianaonoleata1904 georgianaonoleata1904 changed the title [ResponseOps]EUI Visual Refresh integration and QA - tast 1 & 2 [ResponseOps]EUI Visual Refresh integration and QA - tasks 1 & 2 Dec 5, 2024
@georgianaonoleata1904 georgianaonoleata1904 self-assigned this Dec 13, 2024
@georgianaonoleata1904 georgianaonoleata1904 added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v9.0.0 EUI Visual Refresh labels Dec 13, 2024
@georgianaonoleata1904 georgianaonoleata1904 marked this pull request as ready for review December 13, 2024 08:23
@georgianaonoleata1904 georgianaonoleata1904 requested a review from a team as a code owner December 13, 2024 08:23
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@georgianaonoleata1904 georgianaonoleata1904 changed the title [ResponseOps]EUI Visual Refresh integration and QA - tasks 1 & 2 [ResponseOps][UI]EUI Visual Refresh integration and QA - tasks 1 & 2 Dec 13, 2024
@cnasikas
Copy link
Member

@elasticmachine merge upstream

@cnasikas cnasikas added v8.18.0 and removed v8.18.0 labels Dec 16, 2024
Copy link
Contributor

@mgadewoll mgadewoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Changes LGTM from EUI side

@georgianaonoleata1904 georgianaonoleata1904 changed the base branch from main to ro_eui_theme_borealis December 16, 2024 09:30
@georgianaonoleata1904 georgianaonoleata1904 merged commit 44c8e2e into elastic:ro_eui_theme_borealis Dec 16, 2024
@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 16, 2024

⏳ Build in-progress, with failures

Failed CI Steps

Test Failures

  • [job] [logs] Serverless AI Assistant - Security Solution Cypress Tests / AI Assistant Conversations Changing conversations Correctly creates and titles new conversations, and allows title updates Correctly creates and titles new conversations, and allows title updates
  • [job] [logs] AI Assistant - Security Solution Cypress Tests / AI Assistant Conversations Changing conversations Correctly creates and titles new conversations, and allows title updates Correctly creates and titles new conversations, and allows title updates
  • [job] [logs] FTR Configs #86 / Entity Manager _count API is resilient to no valid sources

History

cc @georgianaonoleata1904

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting EUI Visual Refresh release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Response Ops][UI] Update Success Text [Response Ops][UI] Update Success Color

5 participants