-
Notifications
You must be signed in to change notification settings - Fork 8.5k
Dependency ownership for Kibana Operations team, part 1 #202904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Pinging @elastic/kibana-operations (Team:Operations) |
|
Pinging @elastic/kibana-security (Team:Security) |
|
@elastic/kibana-operations I made an effort to group like-dependencies. I am absolutely positive that I've mis-categorized something due to my lack of expertise in your vast domains, so please take a look and suggest revisions as you see fit. I'm happy to make any necessary adjustments. |
jeramysoucy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a typo and some questions, otherwise LGTM! I am sure ops will have more useful feedback.
| "enabled": true | ||
| }, | ||
| { | ||
| "groupName": "picomatch", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this get lumped in with minimatch/micromatch?
renovate.json
Outdated
| "enabled": true | ||
| }, | ||
| { | ||
| "groupName": "gulp", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably my lack of experience, but can gulp and minify groups be merged into one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll defer to ops, but I suspect not
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They can be combined into minify group
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Done in 6a12c3d
Ikuni17
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the preference to use backport labels or target the other branches specifically?
It's a good question. I'm using the backport labels because that was the existing pattern in |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
|
## Summary This updates our `renovate.json` configuration to mark the Kibana Operations team as owners of their set of dependencies. --------- Co-authored-by: Jeramy Soucy <[email protected]>
## Summary This updates our `renovate.json` configuration to mark the Kibana Operations team as owners of their set of dependencies. --------- Co-authored-by: Jeramy Soucy <[email protected]>
## Summary This updates our `renovate.json` configuration to mark the Kibana Operations team as owners of their set of dependencies. --------- Co-authored-by: Jeramy Soucy <[email protected]>
Summary
This updates our
renovate.jsonconfiguration to mark the Kibana Operations team as owners of their set of dependencies.