Skip to content

Conversation

@legrego
Copy link
Member

@legrego legrego commented Dec 4, 2024

Summary

This updates our renovate.json configuration to mark the Kibana Operations team as owners of their set of dependencies.

@legrego legrego added Team:Operations Kibana-Operations Team Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t// release_note:skip Skip the PR/issue when compiling release notes dependencies Pull requests that update a dependency file backport:skip This PR does not require backporting labels Dec 4, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@legrego legrego requested review from a team December 4, 2024 12:22
@legrego
Copy link
Member Author

legrego commented Dec 4, 2024

@elastic/kibana-operations I made an effort to group like-dependencies. I am absolutely positive that I've mis-categorized something due to my lack of expertise in your vast domains, so please take a look and suggest revisions as you see fit. I'm happy to make any necessary adjustments.

Copy link
Contributor

@jeramysoucy jeramysoucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a typo and some questions, otherwise LGTM! I am sure ops will have more useful feedback.

"enabled": true
},
{
"groupName": "picomatch",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this get lumped in with minimatch/micromatch?

renovate.json Outdated
"enabled": true
},
{
"groupName": "gulp",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably my lack of experience, but can gulp and minify groups be merged into one?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll defer to ops, but I suspect not

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They can be combined into minify group

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Done in 6a12c3d

Copy link
Contributor

@Ikuni17 Ikuni17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the preference to use backport labels or target the other branches specifically?

@legrego
Copy link
Member Author

legrego commented Dec 5, 2024

Is the preference to use backport labels or target the other branches specifically?

It's a good question. I'm using the backport labels because that was the existing pattern in renovate.json, and my feeling is that this is more flexible and future-proof as our branches change over time. I'm happy for us to discuss alternative approaches as we gain more experience with this.

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #12 / AgentBasedPackagePoliciesTable renders the table with package policies
  • [job] [logs] Jest Tests #12 / StepDefinePackagePolicy default API response should display vars coming from package policy

Metrics [docs]

✅ unchanged

History

@legrego legrego merged commit e255ca2 into elastic:main Dec 6, 2024
9 checks passed
SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this pull request Dec 9, 2024
## Summary

This updates our `renovate.json` configuration to mark the Kibana
Operations team as owners of their set of dependencies.

---------

Co-authored-by: Jeramy Soucy <[email protected]>
mykolaharmash pushed a commit to mykolaharmash/kibana that referenced this pull request Dec 11, 2024
## Summary

This updates our `renovate.json` configuration to mark the Kibana
Operations team as owners of their set of dependencies.

---------

Co-authored-by: Jeramy Soucy <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
## Summary

This updates our `renovate.json` configuration to mark the Kibana
Operations team as owners of their set of dependencies.

---------

Co-authored-by: Jeramy Soucy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting dependencies Pull requests that update a dependency file release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t// v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants